1. 01 3月, 2019 1 次提交
    • R
      Refactor model and spec · 43e713eb
      Reuben Pereira 提交于
      - Move some specs into contexts
      - Let get_slugs method take a parameter and return a specific slug.
      - Add rescues when using Addressable::URI.
      43e713eb
  2. 28 2月, 2019 4 次提交
  3. 27 2月, 2019 4 次提交
  4. 26 2月, 2019 5 次提交
  5. 25 2月, 2019 4 次提交
  6. 23 2月, 2019 2 次提交
  7. 22 2月, 2019 1 次提交
  8. 21 2月, 2019 3 次提交
  9. 20 2月, 2019 2 次提交
    • M
      Change policy regarding group visibility · 211c4e59
      Małgorzata Ksionek 提交于
      211c4e59
    • S
      Make Admin::UsersController work with Ruby 2.6 · e87c255d
      Stan Hu 提交于
      Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
      Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
      will fail with a `wrong number of arguments (given 1, expected 0)`
      message because the `Enumerable#filter` implementation overrides the
      delegated `ActiveRecord::Relation#filter` method.
      
      To make Admin::UsersController compatible with Ruby 2.6, rename
      `User.filter` to `User.filter_items`.
      e87c255d
  10. 19 2月, 2019 1 次提交
    • T
      Validate session key when authorizing with GCP to create a cluster · fc8c1a77
      Tiger 提交于
      It was previously possible to link a GCP account to another
      user's GitLab account by having them visit the callback URL,
      as there was no check that they were the initiator of the
      request.
      
      We now reject the callback unless the state parameter
      matches the one added to the initiating user's session.
      fc8c1a77
  11. 18 2月, 2019 1 次提交
    • R
      Fix Projects::MergeRequests::DiffsController specs · 45ce5ff7
      Rémy Coutable 提交于
      These specs were flaky and only passing after a retry due to how
      rspec-retry works.
      
      1. The test with paths that don't exist was returning 200 on the first
        try, then 404 on the second, not because the paths don't exist, but
        because the MR IID didn't change, thus the MR couldn't be found.
        I decided to remove the test entirely since we don't seem to return
        404 for paths that don't exist.
      2. The test with a user that cannot view the merge request was failing
        the first time because the project owner wasn't removed with
        `project.team.truncate`.
        Changing the `let(:user)` to `create(:user)` and calling
        `project.add_maintainer(user)` in the `before` block fix the test.
      Signed-off-by: NRémy Coutable <remy@rymai.me>
      45ce5ff7
  12. 14 2月, 2019 4 次提交
  13. 13 2月, 2019 2 次提交
    • L
      Improve the GitHub and Gitea import feature table interface · 534a6117
      Luke Bennett 提交于
      These are backend changes.
      Use Vue for the import feature UI for "githubish"
      providers (GitHub and Gitea).
      Add "Go to project" button after a successful import.
      Use CI-style status icons and improve spacing of the
      table and its component.
      Adds ETag polling to the github and gitea import
      jobs endpoint.
      534a6117
    • R
      Admin section finds users case-insensitively · 12c70e63
      Robert Speicher 提交于
      Previously, if you entered a username in the URL manually to view a
      specific user, the lookup was done case-sensitively, despite usernames
      being case-insensitive, often resulting in a 404. We now use the same
      `find_routable!` logic as the non-admin Users controller.
      12c70e63
  14. 12 2月, 2019 5 次提交
    • S
      Log queue duration in production_json.log · 51ca7922
      Stan Hu 提交于
      `queue_duration` is a useful metric that is currently in api_json.log
      but not in production_json.log. We should add it because it tells us how
      long the request sat in Workhorse before Unicorn processed it. Having
      this field enables the support team to better troubleshoot when delays
      began to happen.
      51ca7922
    • V
      Fix access to pages domain settings · 13d2d198
      Vladimir Shushlin 提交于
      13d2d198
    • F
      Update RE used to prefix links with /help/ · 752887b9
      Frank Sauerburger 提交于
      Update the regular expression in the help controller used to prefix relative
      links on the help page with /help/. As suggested by @rymai, the look-ahead
      pattern to detect external links is simplified from `[a-zA-Z0-9.+-]` to `\w`.
      752887b9
    • F
      Fix broken links on help page · 44d0d0e6
      Frank Sauerburger 提交于
      Update the help controller to correctly handle relative links on the help pages
      when the relative link is before an external link on the same line in the
      markdown file.
      
      Test cases have been implement to check for
       - relative links before external link on same line,
       - HTTPS in query part of link,
       - URLs without '//' and
       - protocol-relative links.
      44d0d0e6
    • L
      Adapt that diverging commits could be just one bar · b502d90a
      Lin Jen-Shin 提交于
      refactors the ui for diverging commits so that it's only a single
      bar instead of two separate bars
      b502d90a
  15. 08 2月, 2019 1 次提交