1. 05 9月, 2019 1 次提交
    • E
      Add service to transfer group milestones · 7a3234c6
      Eugenia Grieff 提交于
      - Add new service that transfers milestones
      from a group to a project
      - Include new service in Projects transfer service
      - Include FromUnion module in Milestone model
      to use in transfer service
      - Add specs for new milestones service
      - Add specs for transferring milestones in
      project transfer service
      7a3234c6
  2. 04 9月, 2019 3 次提交
  3. 03 9月, 2019 4 次提交
  4. 02 9月, 2019 1 次提交
  5. 31 8月, 2019 1 次提交
  6. 30 8月, 2019 3 次提交
  7. 29 8月, 2019 3 次提交
  8. 28 8月, 2019 3 次提交
  9. 27 8月, 2019 3 次提交
  10. 26 8月, 2019 2 次提交
    • I
      Add usage pings for merge request creating · a8040a61
      Igor 提交于
      Code Review Usage Ping for Create SMAU
      a8040a61
    • P
      Add edit_note and spec for editing quick actions · a13abd67
      Patrick Derichs 提交于
      Call QuickActionsService on Note update
      
      Add support for notes which just contain
      commands after editing
      
      Return http status gone (410) if note was deleted
      
      Temporary frontend addition so it is not
      failing when a note is deleted
      
      Move specs to shared examples
      
      Fix rubocop style issue
      
      Deleting note on frontend when status is 410
      
      Use guard clause for note which got deleted
      
      Simplified condition for nil note
      
      This method should no longer be called
      with nil note
      
      Refactoring of execute method to reduce
      complexity
      
      Move errors update to delete_note method
      
      Note is now deleted visually when it only
      contains commands after update
      
      Add expectation
      
      Fix style issues
      
      Changing action to fix tests
      
      Add tests for removeNote and update
      deleteNote expectations
      a13abd67
  11. 24 8月, 2019 2 次提交
  12. 23 8月, 2019 2 次提交
    • N
      Send TODOs for comments on commits correctly · 642f6b38
      Nick Thomas 提交于
      At present, the TodoService uses the `:read_project` ability to decide
      whether a user can read a note on a commit. However, commits can have a
      visibility level that is more restricted than the project, so this is a
      security issue.
      
      This commit changes the code to use the `:read_commit` ability in this
      case instead, which ensures TODOs are only generated for commit notes
      if the users can see the commit.
      642f6b38
    • R
      Add test, reduce complexity · cc18c332
      Robert Schilling 提交于
      cc18c332
  13. 22 8月, 2019 3 次提交
  14. 21 8月, 2019 3 次提交
  15. 18 8月, 2019 1 次提交
  16. 17 8月, 2019 3 次提交
    • S
      Fix pipelines not always being created after a push · b46b9d5e
      Stan Hu 提交于
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31741 introduced
      a regression where not all the right parameters would be passed into
      `Ci::CreatePipelineService`. We fix this by breaking out the pipeline
      parameters and reusing a method from `Gitlab::DataBuilder::Push`.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66196
      b46b9d5e
    • S
      Expire project caches once per push instead of once per ref · f14647fd
      Stan Hu 提交于
      Previously `ProjectCacheWorker` would be scheduled once per ref, which
      would generate unnecessary I/O and load on Sidekiq, especially if many
      tags or branches were pushed at once. `ProjectCacheWorker` would expire
      three items:
      
      1. Repository size: This only needs to be updated once per push.
      2. Commit count: This only needs to be updated if the default branch
         is updated.
      3. Project method caches: This only needs to be updated if the default
         branch changes, but only if certain files change (e.g. README,
         CHANGELOG, etc.).
      
      Because the third item requires looking at the actual changes in the
      commit deltas, we schedule one `ProjectCacheWorker` to handle the first
      two cases, and schedule a separate `ProjectCacheWorker` for the third
      case if it is needed. As a result, this brings down the number of
      `ProjectCacheWorker` jobs from N to 2.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52046
      f14647fd
    • D
      Look up upstream commits once before queuing ProcessCommitWorkers · 97c2564f
      Douwe Maan 提交于
      Instead of checking if a commit already exists in the upstream project
      in its ProcessCommitWorker and bailing out if it does, we check the
      existence of all commits in bulk in Git::BranchHooksService, so that we
      can skip scheduling ProcessCommitWorker jobs for those commits
      that already exist upstream entirely.
      97c2564f
  17. 16 8月, 2019 2 次提交
    • N
      Only read rebase status from the model · d31b733f
      Nick Thomas 提交于
      Prior to 12.1, rebase status was looked up directly from Gitaly. In
      https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14417 , a DB
      column was added to track the status instead. However, we couldn't stop
      looking at the gitaly status immediately, since some rebases may been
      running across the upgrade.
      
      Now that we're in 12.3, it is safe to remove the direct-to-gitaly
      lookup. This also happens to fix a 500 error that is seen when viewing
      an MR for a fork where the source project has been removed.
      
      We still look at the Gitaly status in the service, just in case Gitaly
      and Sidekiq get out of sync - I assume this is possible, and it's a
      relatively cheap check.
      
      Since we atomically check and set `merge_requests.rebase_jid`, we
      should never enqueue two `RebaseWorker` jobs in parallel.
      d31b733f
    • B
      Allow disabling group/project email notifications · 3489dc3d
      Brett Walker 提交于
      - Adds UI to configure in group and project settings
      - Removes notification configuration for users when
      disabled at group or project level
      3489dc3d