- 08 3月, 2016 2 次提交
-
-
由 tiagonbotelho 提交于
-
由 Douwe Maan 提交于
Labels should be visible in dashboard and group milestone views Closes #13621 See merge request !2931
-
- 07 3月, 2016 11 次提交
-
-
由 Douwe Maan 提交于
Add support for cross project references for labels ## Summary Support for cross project references for labels. ## Rationale 1. Cross project label references are currently not supported in GitLab 1. `to_reference` method signature in `Label` model breaks the abstraction introduced in `Referable`. `concerns/referable.rb: def to_reference(_from_project = nil)` Signatures: ``` label.rb: def to_reference(format = :id) commit_range.rb: def to_reference(from_project = nil) commit.rb: def to_reference(from_project = nil) external_issue.rb: def to_reference(_from_project = nil) group.rb: def to_reference(_from_project = nil) issue.rb: def to_reference(from_project = nil) merge_request.rb: def to_reference(from_project = nil) milestone.rb: def to_reference(from_project = nil) project.rb: def to_reference(_from_project = nil) snippet.rb: def to_reference(from_project = nil) user.rb: def to_reference(_from_project = nil) ``` This MR suggests using `def to_reference(from_project = nil, format: :id)` which makes use of keyword arguments and preserves abstract interface. 1. We need support for cross project label references when we want to move issue to another project It may happen that issue description, system notes or comments contain reference to label and this reference will be invalid after moving issue to another project and will not be displayed correctly unless we have support for cross project references. Merge request that needs this feature: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831 I think that cross project label references may be useful, (example: `Hey, see our issues for CI in GitLab CE! - gitab-org/gitlab-ce~"CI"`). cc @JobV @DouweM @rspeicher See merge request !2966
-
由 Douwe Maan 提交于
More Factory cleanup Addresses nitpicks from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2847 See merge request !3108
-
由 Douwe Maan 提交于
Indicate when an MR diverged from the target branch This adds an indicator to the "Merge MR" box, to tell if and how much an MR diverged from its target branch. For instance, consider an MR to merge the branch `feature` into `master`. Some other commits were added to `master` since `feature` was created, and the two branches diverged. ```text o master | o o feature | | o o | / o ``` In this case, there will be a label in the MR Merge box stating: > This MR is by 3 commits behind the target branch `master`. ## Screenshots ### The branch diverged from the target (UI Proposal) ![UI_suggestion_1](/uploads/cd5bee3959e68026ec7d5097259d53f4/UI_suggestion_1.png) ### The branch diverged from the target (alternative UI Proposal) ![UI_suggestion_2](/uploads/f36977101b59a610850e129837dfbc83/UI_suggestion_2.png) ## How is this useful? - In a _rebase-workflow_ (MR are preferably rebased before being merged), the reviewer wants to know if an MR is rebased on the target branch before merging it. _With this indicator, the reviewer knows immediately if the branch is rebased, or if she needs to ask the committer to rebase its branch._ <br> - To keep the git history readable, a team prefers to avoid merging branches that really lag a lot behind the target branch. Merging an MR that is 10 commits behind is fine, but 200 is too much. _With this indicator, the reviewer can see on the MR page if the branch is really far behind the target – or only a few commits behind._ ## Open questions We've been using this at @captaintrain for a few months now, and found it quite useful. I guess the open-questions are mostly: what UI would be the more adequate? Any thoughts on this, on the general usefulness and/or on the code? See merge request !2217
-
由 Douwe Maan 提交于
# Conflicts: # app/models/note.rb
-
由 Douwe Maan 提交于
Remove unused DiffLine model Added in Mar 2014. Only usage removed in Sep 2014. See merge request !3105
-
由 Douwe Maan 提交于
Make better use of the `Note#for_*?` methods We've got all these polymorphic type-checking methods, might as well use 'em everywhere it makes sense. See merge request !3106
-
由 Douwe Maan 提交于
Minor Note model cleanup Remove `Note#noteable_type_name` This method was added in Dec 2012, its single use was removed two days later, and it's been there ever since. --- Remove `Note#system?` "override" This method was duplicating default Rails behavior. See merge request !3104
-
由 Rubén Dávila 提交于
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
-
- 06 3月, 2016 7 次提交
-
-
由 Achilleas Pipinellis 提交于
Add a TL;DR version in quickstart guide See merge request !3026
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
We've got all these polymorphic type-checking methods, might as well use 'em everywhere it makes sense.
-
由 Robert Speicher 提交于
Added in Mar 2014. Only usage removed in Sep 2014.
-
由 Robert Speicher 提交于
Reduce progress bar noise during brakeman run See merge request !3101
-
由 Robert Speicher 提交于
This method was duplicating default Rails behavior.
-
由 Robert Speicher 提交于
This method was added in Dec 2012, its single use was removed two days later, and it's been there ever since.
-
- 05 3月, 2016 20 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Douwe Maan 提交于
Upgrade carrierwave to 0.10.0. Closes #2805 See merge request !3084
-
由 Dmitriy Zaporozhets 提交于
Issue sidebar mobile Fixes #13592 Fixes #14037 See merge request !3050
-
由 Rubén Dávila 提交于
Closes #13628
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
* Add Labels tab to Groups * Add decorator for label so it's aware of Milestones.
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
With this change we avoid doing N+1 queries when viewing Milestone's Issues/MRs from a Group context.
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
-
由 Rubén Dávila 提交于
Make methods return ActiveRecord Relations instead of Arrays.
-
由 Sytse Sijbrandij 提交于
-
由 Robert Speicher 提交于
Properly display YAML front matter in Markdown See merge request !3072
-