1. 31 5月, 2018 1 次提交
  2. 29 5月, 2018 1 次提交
  3. 22 5月, 2018 1 次提交
  4. 10 5月, 2018 1 次提交
  5. 07 5月, 2018 2 次提交
  6. 25 4月, 2018 1 次提交
  7. 15 4月, 2018 1 次提交
  8. 28 3月, 2018 2 次提交
  9. 07 3月, 2018 2 次提交
    • S
      Memoize Repository#empty? instead of double caching the value · 611929eb
      Stan Hu 提交于
      We saw that in a customer instance, `empty?` was cached to be `true` even
      though `has_visible_content?` and `exists?` were `true`. This double caching
      can run into edge cases because there's no guarantee that the inner values
      will properly expire the outer one, especially if there is Redis replication lag.
      Consider this scenario:
      
      1. `exists?` and `has_visible_content?` are false
      2. `empty?` is expired
      3. A subsequent call to `empty?` returns `true` because `exists?` is false even though `empty` is true
      4. `exists?` and `has_visible_content?` are then expired
      5. `exists?` and `has_visible_content?` are set to true
      6. `empty?` is still stuck in the wrong value as `true`
      
      Closes #43882
      611929eb
    • A
  10. 06 3月, 2018 3 次提交
  11. 01 3月, 2018 1 次提交
  12. 23 2月, 2018 1 次提交
  13. 17 2月, 2018 1 次提交
  14. 15 2月, 2018 4 次提交
    • S
      Remove head_commit call · 85068908
      Stan Hu 提交于
      85068908
    • S
      Simplify license generator error handling · 5b3b2b82
      Stan Hu 提交于
      5b3b2b82
    • S
      Remove use of catching Rugged exceptions · bc11af67
      Stan Hu 提交于
      bc11af67
    • S
      Fix Error 500s loading repositories with no master branch · 35b3a0b9
      Stan Hu 提交于
      We removed the exception handling for Rugged errors in !16770, which
      revealed that the licensee gem attempts to retrieve a license file
      via Rugged in `refs/heads/master` by default. If that branch
      did not exist, a Rugged::ReferenceError would be thrown.
      
      There were two issues:
      
      1. Not every project uses `master` as the default branch. This
      change uses the head commit to identify the license.
      
      2. Removing the exception handling caused repositories to fail
      loading. We can safely catch and ignore any Rugged error because
      this means we weren't able to load a license file.
      
      Closes #43268
      35b3a0b9
  15. 07 2月, 2018 2 次提交
  16. 03 2月, 2018 1 次提交
  17. 01 2月, 2018 1 次提交
    • Z
      Client changes for Tag,BranchNamesContainingCommit · 0a47d192
      Zeger-Jan van de Weg 提交于
      As part of gitlab-org/gitaly#884, this commit contains the client
      implementation for both TagNamesContaintingCommit and
      BranchNamesContainingCommit. The interface in the Repository model stays
      the same, but the implementation on the serverside, e.g. Gitaly, uses
      `for-each-ref`, as opposed to `branch` or `tag` which both aren't
      plumbing command. The result stays the same.
      
      On the serverside, we have the opportunity to limit the number of names
      to return. However, this is not supported on the front end yet. My
      proposal to use this ability: gitlab-org/gitlab-ce#42581. For now, this
      ability is not used as that would change more behaviours on a feature
      flag which might lead to unexpected changes on page refresh for example.
      0a47d192
  18. 31 1月, 2018 3 次提交
  19. 30 1月, 2018 1 次提交
  20. 25 1月, 2018 2 次提交
  21. 24 1月, 2018 1 次提交
  22. 22 1月, 2018 1 次提交
  23. 19 1月, 2018 1 次提交
  24. 16 1月, 2018 2 次提交
  25. 15 1月, 2018 3 次提交