1. 22 8月, 2017 1 次提交
  2. 20 8月, 2017 1 次提交
    • S
      Fix Error 500s when attempting to destroy a protected tag · 718ecd4e
      Stan Hu 提交于
      Due to a missing `on_delete: :cascade`, users would hit the error that
      looked like:
      
      ```
      PG::ForeignKeyViolation: ERROR: update or delete on table "protected_tags"
      violates foreign key constraint "fk_rails_f7dfda8c51" on table
      "protected_tag_create_access_levels" DETAIL: Key (id)=(1385) is still
      referenced from table "protected_tag_create_access_levels". : DELETE FROM
      "protected_tags" WHERE "protected_tags"."id" = 1385
      ```
      
      Closes #36013
      718ecd4e
  3. 16 8月, 2017 1 次提交
  4. 11 8月, 2017 2 次提交
    • R
      7633945c
    • Y
      Better caching and indexing of broadcast messages · a5c8a527
      Yorick Peterse 提交于
      Caching of BroadcastMessage instances has been changed so a cache stays
      valid as long as the default cache expiration time permits, instead of
      the cache being expired after 1 minute. When modifying broadcast
      messages the cache is flushed automatically.
      
      To remove the need for performing sequence scans on the
      "broadcast_messages" table we also add an index on (starts_at, ends_at,
      id), permitting PostgreSQL to use an index scan to get all necessary
      data.
      
      Finally this commit adds a few NOT NULL constraints to the table to
      match the Rails validations.
      
      Fixes gitlab-org/gitlab-ce#31706
      a5c8a527
  5. 10 8月, 2017 3 次提交
    • Y
      Use a specialized class for querying events · aac1de46
      Yorick Peterse 提交于
      This changes various controllers to use the new EventCollection class
      for retrieving events. This class uses a JOIN LATERAL query on
      PostgreSQL to retrieve queries in a more efficient way, while falling
      back to a simpler / less efficient query for MySQL.
      
      The EventCollection class also includes a limit on the number of events
      to display to prevent malicious users from cycling through all events,
      as doing so could put a lot of pressure on the database.
      
      JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0
      and as such this optimisation is only used when using PostgreSQL 9.3 or
      newer.
      aac1de46
    • Y
      Migrate events into a new format · 0395c471
      Yorick Peterse 提交于
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
      0395c471
    • Y
      Cache Appearance instances in Redis · 26bb5041
      Yorick Peterse 提交于
      This caches the result of Appearance.first in a similar fashion to how
      ApplicationSetting instances are cached. We also add some NOT NULL
      constraints to the table and correct the timestamp types.
      
      Fixes gitlab-org/gitlab-ce#36066, fixes gitlab-org/gitlab-ce#31698
      26bb5041
  6. 08 8月, 2017 3 次提交
  7. 03 8月, 2017 1 次提交
    • Y
      Re-organise "issues" indexes for faster ordering · 9b3f0569
      Yorick Peterse 提交于
      By adding various composite indexes we can reduce the time spent
      retrieving issue lists. Because of the way these indexes are built
      column wise we can also remove some standalone indexes, keeping the
      total number of indexes in check.
      9b3f0569
  8. 31 7月, 2017 1 次提交
  9. 29 7月, 2017 1 次提交
  10. 28 7月, 2017 2 次提交
  11. 27 7月, 2017 10 次提交
  12. 26 7月, 2017 2 次提交
  13. 20 7月, 2017 2 次提交
  14. 18 7月, 2017 5 次提交
  15. 13 7月, 2017 1 次提交
    • R
      Fixes needed when GitLab sign-in is not enabled · 672a68d3
      Robin Bobbitt 提交于
      When sign-in is disabled:
       - skip password expiration checks
       - prevent password reset requests
       - don’t show Password tab in User Settings
       - don’t allow login with username/password for Git over HTTP requests
       - render 404 on requests to Profiles::PasswordsController
      672a68d3
  16. 11 7月, 2017 1 次提交
  17. 08 7月, 2017 1 次提交
  18. 07 7月, 2017 2 次提交
    • F
      Native group milestones · b5f596c3
      Felipe Artur 提交于
      b5f596c3
    • S
      Basic BE change · 5b095475
      Shinya Maeda 提交于
      Fix static-snalysis
      
      Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
      
      Separate Ci::VariableProject and Ci::VariableGroup
      
      Add the forgotton files
      
      Add migration file to update type of ci_variables
      
      Fix form_for fpr VariableProject
      
      Fix test
      
      Change the table structure according to the yorik advice
      
      Add necessary migration files. Remove unnecessary migration spec.
      
      Revert safe_model_attributes.yml
      
      Fix models
      
      Fix spec
      
      Avoid self.variable. Use becomes for correct routing.
      
      Use unique index on group_id and key
      
      Add null: false for t.timestamps
      
      Fix schema version
      
      Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
      
      Rename the rest of them
      
      Add the rest of files
      
      Basic BE change
      
      Fix static-snalysis
      
      Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
      
      Separate Ci::VariableProject and Ci::VariableGroup
      
      Add the forgotton files
      
      Add migration file to update type of ci_variables
      
      Fix form_for fpr VariableProject
      
      Fix test
      
      Change the table structure according to the yorik advice
      
      Add necessary migration files. Remove unnecessary migration spec.
      
      Revert safe_model_attributes.yml
      
      Fix models
      
      Fix spec
      
      Avoid self.variable. Use becomes for correct routing.
      
      Use unique index on group_id and key
      
      Add null: false for t.timestamps
      
      Fix schema version
      
      Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
      
      Rename the rest of them
      
      Add the rest of files
      
      Implement CURD
      
      Rename codes related to VariableGroup and VariableProject FE part
      
      Remove unneccesary changes
      
      Make Fe code up-to-date
      
      Add protected flag to migration file
      
      Protected group variables essential package
      
      Update schema
      
      Improve doc
      
      Fix logic and spec for models
      
      Fix logic and spec for controllers
      
       Fix logic and spec for views(pre feature)
      
      Add feature spec
      
      Fixed bugs. placeholder. reveal button. doc.
      
      Add changelog
      
      Remove unnecessary comment
      
      godfat nice catches
      
      Improve secret_variables_for arctecture
      
      Fix spec
      
      Fix StaticAnlysys & path_regex spec
      
      Revert "Improve secret_variables_for arctecture"
      
      This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.
      
      Use ayufan suggestion for secret_variables_for
      
      Use find instead of find_by
      
      Fix spec message for variable is invalid
      
      Fix spec remove variable.group_id = group.id
      
      godffat spec nitpicks
      
      Use include Gitlab::Routing.url_helpers for presenter spec
      5b095475