1. 08 10月, 2018 1 次提交
    • Y
      Clean up ActiveRecord code in TodosFinder · 4c1dc310
      Yorick Peterse 提交于
      This refactors the TodosFinder finder according to the new code reuse
      rules, as enforced by the CodeReuse cops. I also changed some of the
      methods to use regular if statements, instead of assignments and/or
      early returns. This results in a more natural flow when reading the
      code, and it makes it harder to accidentally return the wrong result.
      4c1dc310
  2. 07 10月, 2018 2 次提交
  3. 06 10月, 2018 11 次提交
  4. 05 10月, 2018 18 次提交
  5. 04 10月, 2018 8 次提交
    • A
      fix method name in stage spec · acfe7ec6
      Alessio Caiazza 提交于
      acfe7ec6
    • S
      Fix N+1 for notification recipients on private projects · 28e6af88
      Sean McGivern 提交于
      If we don't call #to_a, we're relying on the members already being loaded from
      elsewhere. Otherwise we'll do a separate query for each user:
      
          [1] pry(main)> Project.first.team.members.include?(User.first)
            Project Load (0.7ms)  SELECT  "projects".* FROM "projects"  ORDER BY "projects"."id" ASC LIMIT 1
            ↳ (pry):3
            User Load (1.8ms)  SELECT  "users".* FROM "users"  ORDER BY "users"."id" ASC LIMIT 1
            ↳ (pry):3
            User Exists (0.6ms)  SELECT  1 AS one FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1 AND "users"."id" = $2 LIMIT 1  [["project_id", 1], ["id", 1]]
            ↳ (pry):3
          => true
          [2] pry(main)> Project.first.team.members.to_a.include?(User.first)
            Project Load (12.8ms)  SELECT  "projects".* FROM "projects"  ORDER BY "projects"."id" ASC LIMIT 1
            ↳ (pry):1
            User Load (9.6ms)  SELECT "users".* FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1  [["project_id", 1]]
            ↳ (pry):1
            User Load (0.6ms)  SELECT  "users".* FROM "users"  ORDER BY "users"."id" ASC LIMIT 1
            ↳ (pry):1
          => true
      28e6af88
    • S
      Fix N+1 for notification recipients in subscribers · 819ecd5f
      Sean McGivern 提交于
      819ecd5f
    • F
      Renders empty states in the Vue app in Job page · e13baff0
      Filipa Lacerda 提交于
      e13baff0
    • W
      Add component tests for scheduled job frontend · 0fc93df0
      Winnie Hellmann 提交于
      0fc93df0
    • S
      Groomed specs · 4741c07f
      Shinya Maeda 提交于
      4741c07f
    • S
      Add limitation for start_in keyword · e84230eb
      Shinya Maeda 提交于
      e84230eb
    • S
      Allow Gitaly N+1s in MR finder spec · 36a73449
      Sean McGivern 提交于
      These can be triggered by project creation in the setup phase if a spec uses the
      RequestStore, but we really don't care about that - it's not an N+1, it's just
      several projects being created!
      36a73449