- 01 7月, 2016 2 次提交
-
-
由 Paco Guzman 提交于
-
由 Eric K Idema 提交于
This stands as an alternative to using OAuth to access a user's Github repositories. This is setup in such a way that it can be used without OAuth configuration. From a UI perspective, the how to import modal has been replaced by a full page, which includes a form for posting a personal access token back to the Import::GithubController. If the user has logged in via GitHub, skip the Personal Access Token and go directly to Github for an access token via OAuth.
-
- 30 6月, 2016 8 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Yorick Peterse 提交于
IssueReferenceFilter will end up processing internal issue references when a project uses an external issues tracker while still using internal issue references (in the form of `#\d+`). This commit ensures that these links are rendered as external issue links, regardless of whether the project one currently views uses an internal or external issues tracker. Fixes gitlab-org/gitlab-ce#19036, gitlab-com/performance#16
-
由 Z.J. van de Weg 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
If Redis were not running or USE_DB were set to false, the application settings retrieval would fail completely. This change only attempts to use the cache if the system actually wants to connect to the DB and rescues any failures in talking to Redis. Closes #17557
-
- 29 6月, 2016 3 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Drew Blessing 提交于
-
由 Z.J. van de Weg 提交于
-
- 28 6月, 2016 12 次提交
-
-
由 Yorick Peterse 提交于
Process.clock_gettime allows getting the real time in nanoseconds as well as allowing one to get a monotonic timestamp. This offers greater accuracy without the overhead of having to allocate a Time instance. In general using Time.now/Time.new is about 2x slower than using Process.clock_gettime(). For example: require 'benchmark/ips' Benchmark.ips do |bench| bench.report 'Time.now' do Time.now.to_f end bench.report 'clock_gettime' do Process.clock_gettime(Process::CLOCK_MONOTONIC, :millisecond) end bench.compare! end Running this benchmark gives: Calculating ------------------------------------- Time.now 108.052k i/100ms clock_gettime 125.984k i/100ms ------------------------------------------------- Time.now 2.343M (± 7.1%) i/s - 11.670M clock_gettime 4.979M (± 0.8%) i/s - 24.945M Comparison: clock_gettime: 4979393.8 i/s Time.now: 2342986.8 i/s - 2.13x slower Another benefit of using Process.clock_gettime() is that we can simplify the code a bit since it can give timestamps in nanoseconds out of the box.
-
由 Grzegorz Bizon 提交于
-
由 Paco Guzman 提交于
In any case if just want the value which is always ‘gitlab’ require 'benchmark/ips' Project.first # To load database things GitlabIssueTrackerService.first # To load database things Benchmark.ips do |x| x.config(:time => 5, :warmup => 2) x.report("current") do Project.new.default_issue_tracker.to_param end x.report("") do 'gitlab' end x.compare! end Calculating ------------------------------------- current 4.000 i/100ms 30.938k i/100ms ------------------------------------------------- current 47.298 (±10.6%) i/s - 232.000 4.366M (±20.9%) i/s - 17.202M Comparison: : 4366456.0 i/s current: 47.3 i/s - 92318.26x slower
-
由 Z.J. van de Weg 提交于
Depends on the changes in Workhorse (gitlab-org/gitlab-workhorse!48).
-
由 Grzegorz Bizon 提交于
1. Return 404 if commit is not found (RESTful resource not found) 2. Return an empty array if pipeline is not found (resource present, no associated builds found) 3. Return an empty array if pipeline found but no builds there (resource present, no associated builds)
-
由 Grzegorz Bizon 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
paired with @stanhu
-
由 Drew Blessing 提交于
-
由 Robert Speicher 提交于
-
- 27 6月, 2016 2 次提交
-
-
由 Connor Shea 提交于
Add max-height to prevent images from displaying larger than the provided screen size. Also fix a failing test and add a new one.
-
由 James Lopez 提交于
-
- 24 6月, 2016 3 次提交
-
-
由 Yorick Peterse 提交于
This commit changes the way certain documents are rendered (currently only Notes) and how documents are redacted. Previously both rendering and redacting would run on a per document basis. The result of this was that for every document we'd have to run countless queries just to figure out if we could display a set of links or not. This commit changes things around so that redacting Markdown documents is no longer tied into the html-pipeline Gem. This in turn allows it to redact multiple documents in a single pass, thus reducing the number of queries needed. In turn rendering issue/merge request notes has been adjusted to take advantage of this new setup. Instead of rendering Markdown somewhere deep down in a view the Markdown is rendered and redacted in the controller (taking the current user and all that into account). This has been done in such a way that the "markdown()" helper method can still be used on its own. This particular commit also paves the way for caching rendered HTML on object level. Right now there's an accessor method Note#note_html which is used for setting/getting the rendered HTML. Once we cache HTML on row level we can simply change this field to be a column and call a "save" whenever needed and we're pretty much done.
-
由 James Lopez 提交于
Fix tmp file being deleted after the request plus some cleanup and improved erroring for this situation
-
由 Marc Siegfriedt 提交于
rely only on IssuesFinder docs and changelog
-
- 23 6月, 2016 2 次提交
-
-
由 Paco Guzman 提交于
-
由 Drew Blessing 提交于
-
- 22 6月, 2016 3 次提交
-
-
由 James Lopez 提交于
-
由 Yorick Peterse 提交于
In the past this class would use Project#get_issue to retrieve an issue by its ID. This method would automatically determine whether to return an Issue or ExternalIssue. This commit changes IssueReferenceFilter to handle external issues again and in a somewhat more explicit manner than before. Fixes gitlab-org/gitlab-ce#18827
-
由 James Lopez 提交于
-
- 21 6月, 2016 5 次提交
-
-
由 Yorick Peterse 提交于
The method Banzai::Renderer.pre_process would always be called, regardless of whether the Markdown to render was already cached or not. In cache the document _was_ cached the output of the pre-processing pipeline was ignored resulting in it doing nothing but wasting CPU cycles. This commit moves Banzai::Renderer.pre_process into Banzai::Renderer.render_result so that it's _only_ used when needed.
-
由 Alejandro Rodríguez 提交于
A lot of git operations were being repeated, for example, to build a url you would ask if the path was a Tree, which would call a recursive routine in Gitlab::Git::Tree#where, then ask if the path was a Blob, which would call a recursive routine at Gitlab::Git::Blob#find, making reference to the same git objects several times. Now we call Rugged::Tree#path, which allows us to determine the type of the path in one pass. Some other minor improvement added, like saving commonly used references instead of calculating them each time.
-
由 Grzegorz Bizon 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-