fixed bug to do with calculating durations

Fixes a couple of small bugs while calculating durations in cycle analytics - probably due to some bad refactoring

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24796

See merge request !7663

Merge branch '24804-wrong-render-index-should-be-render-show-in-projects-pipelinessettingscontroller-update' into 'master'

Resolve "Wrong `render 'index'`, should be `render 'show'` in `Projects::PipelinesSettingsController#update`"

Closes #24804

See merge request !7665

See merge request !7672

Issue creation now accepts trailing whitespace

See merge request !7633

Add shortcuts for adding users to a project team with a specific role

Closes #20944

See merge request !7565

Do not use MergeRequest#commits in define_pipelines_vars

## What does this MR do?

`MergeRequest#commits` requires merge_request_diff to be present.
This is not the case when creating a new merge request.

## What are the relevant issue numbers?

Fix up for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7568

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24798

See merge request !7664

Allow admins to stop impersonating users without e-mail addresses

Closes #24576

See merge request !7550

Fix IID filter for merge requests and milestones

I updated the example in the docs and added a test. The milestones API was also broken for the same reason.

Related to !7358 and !7373

See merge request !7648

Handle orphans when removing soft deleted groups

This fixes the migration from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7528 so it handles orphans as mentioned in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7528/diffs#note_18800962.

This needs to go in 8.14.0 as otherwise customers may run into the same problem.

See merge request !7657

Add new image for Cycle Analytics

See merge request !7666

Add concern for reuse pagination params declaration in API

Closes #23532

See merge request !7646

[ci skip]

Signed-off-by: NRémy Coutable <remy@rymai.me>

Revert "Merge branch 'docs/jira-old' into 'master'"

See merge request !7531

MergeRequest#commits requires merge_request_diff to be present.
This is not the case when creating a new merge request.

There may be more tables but these were the tables that were problematic
for GitLab.com due to foreign key constraints (without cascading
deletes).

Improve readability of environments table

## What does this MR do?
Fix the environments table columns width

## Before
![Screen_Shot_2016-11-21_at_18.13.00](/uploads/1771b0546eb3cb15f4894b719fd44286/Screen_Shot_2016-11-21_at_18.13.00.png)

## After
![Screen_Shot_2016-11-21_at_18.11.18](/uploads/a20194a055b6ec0f7989f0c1499883d3/Screen_Shot_2016-11-21_at_18.11.18.png)
## Does this MR meet the acceptance criteria?

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !7628

Add help section for MM commands

## What should this MR do

Check @pedroms' design for the Mattermost service screen: https://gitlab.com/gitlab-org/gitlab-ce/issues/22540

Now this has to be implemented, I've created a clean canvas for you, @lbennett, to draw on.

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !7558

External jobs do not have show page nor traces

Fixes #24677

See merge request !7617

Avoid helper call with default parameters

The helpers can ultimately be removed when the issue API uses the Grape DSL.

See merge request !7649

This reverts merge request !7365

Add Approve and Remove approval to UX Guide terminology table

Updating UX Guide page on terminology to include guidance on 'Approve' and 'Remove approval'.

See merge request !7632

fixed manage_large_binaries_with_git_lfs.md typo

See merge request !7612

add missing sudo skip-auto-migration

## What does this MR do?

Fixes minor documentation issue where adding `skip-auto-migration` file does not work because `sudo` is not used.

See merge request !7435

Change docker backup command in readme

See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html

## What does this MR do?

MR fixes wrong order of parameters in the command given for backing up gitlab in a docker container

## Moving docs to a new location?

No

See merge request !7468

Add example image to pipelines docs

See merge request !7652

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24767

[ci skip]

Object state models docs

Object state models docs for issues and merge requests.

This is to start documenting object models, focused more on users and how they experience the product.

See merge request !7544

Docs on Mattermost commands

Still needs some screenshots, depends on: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7558

/cc @ayufan @SeanPackham

See merge request !7567

[ci skip]

Preserve optional second parameter in NewNoteWorker jobs
    
Closes #24678

See merge request !7602