- 22 10月, 2018 1 次提交
-
-
由 Yorick Peterse 提交于
This moves the logic of Project#rename_repo and all methods _only_ used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically. During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users. I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments. This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
-
- 21 9月, 2018 1 次提交
-
-
由 Semyon Pupkov 提交于
-
- 25 7月, 2018 1 次提交
-
-
由 Lin Jen-Shin 提交于
-
- 21 6月, 2017 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 21 3月, 2017 1 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 13 3月, 2017 1 次提交
-
-
由 Dmitriy Zaporozhets 提交于
That have wildcard routes associated and not reserved yet: artifacts, graphs, badges and refs Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 23 2月, 2017 3 次提交
-
-
由 Douwe Maan 提交于
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 06 1月, 2017 1 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 25 12月, 2016 3 次提交
-
-
由 Yorick Peterse 提交于
This return is redundant as the query now uses "WHERE EXISTS (...)" to filter out projects without a namespace.
-
由 Yorick Peterse 提交于
This ensures threads don't re-use the same connection object, and use fewer queries to perform the work.
-
由 Dmitriy Zaporozhets 提交于
We cant have project with name 'project' or 'tree' anymore. This merge request containts a migration that will find and rename all projects using reserved names by adding N digit to the end of the name. Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-