1. 15 12月, 2017 1 次提交
    • N
      Import gitlab_projects.rb from gitlab-shell · 4b785df2
      Nick Thomas 提交于
      By importing this Ruby code into gitlab-rails (and gitaly-ruby), we avoid
      200ms of startup time for each gitlab_projects subprocess we are eliminating.
      
      By not having a gitlab_projects subprocess between gitlab-rails / sidekiq and
      any git subprocesses (e.g. for fork_project, fetch_remote, etc, calls), we can
      also manage these git processes more cleanly, and avoid sending SIGKILL to them
      4b785df2
  2. 14 12月, 2017 1 次提交
  3. 13 12月, 2017 11 次提交
  4. 12 12月, 2017 2 次提交
    • Z
      Use memoization for commits on diffs · 3ab026b7
      Zeger-Jan van de Weg 提交于
      The Gitaly CommitService is being hammered by n + 1 calls, mostly when
      finding commits. This leads to this gRPC being turned of on production:
      https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378
      
      Hunting down where it came from, most of them were due to
      MergeRequest#show. To prove this, I set a script to request the
      MergeRequest#show page 50 times. The GDK was being scraped by
      Prometheus, where we have metrics on controller#action and their Gitaly
      calls performed. On both occations I've restarted the full GDK so all
      caches had to be rebuild.
      
      Current master, 806a68a8, needed 435 requests
      After this commit, 154 requests
      3ab026b7
    • B
      Create models directly in migration specs · 5ac98f93
      Bob Van Landuyt 提交于
      Instead of using the factories. Since the factories might be using
      columns that aren't available in the schema at version the particular
      spec is running in.
      5ac98f93
  5. 11 12月, 2017 5 次提交
  6. 09 12月, 2017 3 次提交
  7. 08 12月, 2017 8 次提交
    • J
      Use prefix for TableOfContents filter hrefs · 3e83d9f7
      Jan Provaznik 提交于
      TableOfContents filter generates hrefs for each header in markdown,
      if the header text consists from digits and redacted symbols only,
      e.g. "123" or "1.0 then the auto-generated href has the same format
      as issue references.
      
      If the generated id contains only digits, then 'anchor-' prefix is
      prepended to the id.
      
      Closes #38473
      3e83d9f7
    • K
      Fix Rubocop · 99101f94
      Kamil Trzcinski 提交于
      99101f94
    • K
      Add Chain::Command specs · b5f6a5f9
      Kamil Trzcinski 提交于
      b5f6a5f9
    • K
      ad3be46b
    • G
      Fix invalid pipeline build chain tag evaluation · b30e0e06
      Grzegorz Bizon 提交于
      b30e0e06
    • B
      Move the circuitbreaker check out in a separate process · f1ae1e39
      Bob Van Landuyt 提交于
      Moving the check out of the general requests, makes sure we don't have
      any slowdown in the regular requests.
      
      To keep the process performing this checks small, the check is still
      performed inside a unicorn. But that is called from a process running
      on the same server.
      
      Because the checks are now done outside normal request, we can have a
      simpler failure strategy:
      
      The check is now performed in the background every
      `circuitbreaker_check_interval`. Failures are logged in redis. The
      failures are reset when the check succeeds. Per check we will try
      `circuitbreaker_access_retries` times within
      `circuitbreaker_storage_timeout` seconds.
      
      When the number of failures exceeds
      `circuitbreaker_failure_count_threshold`, we will block access to the
      storage.
      
      After `failure_reset_time` of no checks, we will clear the stored
      failures. This could happen when the process that performs the checks
      is not running.
      f1ae1e39
    • J
      Clean test path between merge request handler tests · b2e0f609
      Jan Provaznik 提交于
      create_merge_request_handler_spec needs a repository for some tests but
      this repository lasts on disk by default which causes failures of other
      tests. TestEnv.clean_test_path is used to get rid of the repository
      after each test.
      
      Closes #40900
      b2e0f609
    • M
      fix #39233 - 500 in merge request · b7a5125f
      Martin Nowak 提交于
      - handle unchanged empty lines in inline diff
      b7a5125f
  8. 07 12月, 2017 8 次提交
  9. 06 12月, 2017 1 次提交