- 01 6月, 2016 20 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
Fix 404 page when viewing TODOs that contain milestones or labels in different projects A user viewing the TODOs page will see a 404 if there are mentioned milestones or labels in multiple different projects. This is likely a caching bug and only occurs when Markdown rendering occurs across multiple projects, which is why it's so tricky to reproduce. This is what I think is happening: 1. LabelReferenceFilter#references_in encounters label ~X for ProjectA and finds the label in the DB as id = 1. 2. LabelReferenceFilter.references_in yields [1, 'X', nil, ...] 3. Since project_ref is nil, AbstractReferenceFilter#project_from_ref_cache caches nil => ProjectA. 4. LabelReferenceFilter#references_in encounters label ~Y for ProjectB and finds the label in the DB as id = 2. 5. LabelReferenceFilter.references_in yields [2, 'Y', nil, ...] 6. AbstractReferenceFilter#project_from_ref_cache lookups nil and returns ProjectA. It was supposed to be ProjectB. 7. A is the wrong project, so the label lookup fails. This MR expands the `project_ref` to the right value as soon as we have it to avoid this caching bug. Closes #17898 See merge request !4312
-
由 Rémy Coutable 提交于
Amend jira service api docs [ci skip] ## What does this MR do? Amends the API documentation for jira service integration ## Are there points in the code the reviewer needs to double check? No ## Why was this MR needed? The current documentation omits the username and password parameters ## What are the relevant issue numbers? ## Screenshots (if relevant) See merge request !4382
-
由 Rémy Coutable 提交于
Fix error 500 when sorting issues by milestone due date and filtering by labels fixes #15557 See merge request !4327
-
由 Dmitriy Zaporozhets 提交于
-
由 Dmitriy Zaporozhets 提交于
Add tooltips for common Event feed entries This adds tooltips to the event target for events like "opened merge request !XYZ" After https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4090#note_11712839, several references in the event feed had titles but were still missing tooltips. See merge request !4371
-
由 Stan Hu 提交于
A user viewing the TODOs page will see a 404 if there are mentioned labels in multiple different projects. This is likely a caching bug and only occurs when Markdown rendering occurs across multiple projects, which is why it's so tricky to reproduce. This is what I think is happening: 1. LabelReferenceFilter#references_in encounters label ~X for ProjectA and finds the label in the DB as id = 1. 2. LabelReferenceFilter.references_in yields [1, 'X', nil, ...] 3. Since project_ref is nil, AbstractReferenceFilter#project_from_ref_cache caches nil => ProjectA. 4. LabelReferenceFilter#references_in encounters label ~Y for ProjectB and finds the label in the DB as id = 2. 5. LabelReferenceFilter.references_in yields [2, 'Y', nil, ...] 6. AbstractReferenceFilter#project_from_ref_cache lookups nil and returns ProjectA. It was supposed to be ProjectB. 7. A is the wrong project, so the label lookup fails. This MR caches Markdown references if the key is present. Closes #17898
-
由 Jacob Schatz 提交于
New style for close buttons ## What does this MR do? Adds new style for all `Close` buttons ## What are the relevant issue numbers? Closes #17756 ## Screenshots (if relevant) <img src="/uploads/a1d4cb8c22facb4c170e9cf3b4ae439a/Screen_Shot_2016-05-31_at_2.26.42_PM.png" width="800px"> <img src="/uploads/d567694d79ec6bd5da0ff2faf8b262b0/Screen_Shot_2016-05-31_at_2.26.09_PM.png" width="800px"> <img src="/uploads/f5e23d8031427079a334d4e03da466b0/Screen_Shot_2016-05-31_at_2.29.01_PM.png" width="800px"> cc @dzaporozhets See merge request !4388
-
由 Felipe Artur 提交于
-
由 Robert Speicher 提交于
Upgrade Kaminari from 0.16.3 to 0.17.0. Changelog: https://github.com/amatsuda/kaminari/blob/master/CHANGELOG.rdoc#0170 Deprecates `num_pages` in favor of `total_pages` and includes Rails 5 support. Working towards #14286. See merge request !4387
-
由 Stan Hu 提交于
Create the specified remote directory during backup This is idempotent, so there's no harm calling it if the directory already exists. Closes #12710 See merge request !4383
-
由 Annabel Dunstone 提交于
-
由 Connor Shea 提交于
Changelog: https://github.com/amatsuda/kaminari/blob/master/CHANGELOG.rdoc#0170 Deprecates num_pages in favor of total_pages and includes Rails 5 support.
-
由 Robert Speicher 提交于
Confidential notes data leak Fixes part of https://gitlab.com/gitlab-org/gitlab-ee/issues/575 See merge request !1967
-
由 Robert Speicher 提交于
Remove redundant factory namespace in build specs Extracted from !4351. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4351#note_12154604 See merge request !4373
-
由 Valery Sizov 提交于
-
由 Rémy Coutable 提交于
Include Wiki attributes in Wiki page events webhook The hook data we are sending is not 100% correct (we send details of the project, but should also send details of the "ProjectWiki" attributes like URLs and repositories relative to the wiki itself). This is a follow up to #17506 Fixes #17507 See merge request !4138
-
由 Robert Speicher 提交于
This is idempotent, so there's no harm calling it if the directory already exists. Closes #12710
-
由 Stan Hu 提交于
Remove project notification settings associated with deleted projects On GitLab.com, there are 1560 project notification settings with no valid project all created on 2016-04-15 10:38:53 for some reason. This migration should purge those entries. b8f38437 should prevent this issue from occurring in the first place. Closes gitlab-com/support-forum#678 See merge request !4311
-
由 Richard Grainger 提交于
-
- 31 5月, 2016 20 次提交
-
-
由 Douwe Maan 提交于
Add Application Setting to configure Container Registry token expire delay (default 5min) This adds an option to configure Container Registry token expire delay. The default is set to 5mins (something that is also used by Docker Hub). What is left: * [x] Write test to check the expire_delay Fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/17890 @stanhu I think that this should land in patch release of 8.8. See merge request !4364
-
由 Gabriel Mazetto 提交于
-
由 Gabriel Mazetto 提交于
-
由 Gabriel Mazetto 提交于
Added "wiki" section and removed "repository"
-
由 Kamil Trzcinski 提交于
This is not needed when we specify a default.
-
由 Kamil Trzcinski 提交于
-
由 Felipe Artur 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Robert Schilling 提交于
Update docs: previous version is 8.7 The old version is 8.7. See merge request !4288
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Rémy Coutable 提交于
Enable Wiki Page events from Webhook admin UI in a Project * Added UI to enable page wiki events * Documentation for this event in Webhooks page Fixes #17506 --- ![new_webhook_UI](/uploads/63ef24b4ccef13ac7a5fda83e9ce64ad/new_webhook_UI.png) See merge request !4135
-
由 Grzegorz Bizon 提交于
Conflicts: spec/models/build_spec.rb
-
由 Stan Hu 提交于
Merge branch 'make-container-registry-authentication-service-compatible-with-older-docker' into 'master' Make authentication service for Container Registry to be compatible with < Docker 1.11 This removes the usage of `offline_token` which is only present when using `Docker 1.11.x` instead we relay on `scope`. This should make it compatible with any client starting from 1.6 (I did test only 1.8 and up). Right now we return 403 if unauthorized user doesn't have access to anything. In all other cases we return token, but with empty `access`, which simply disallow requested action. See merge request !4363
-
由 Robert Speicher 提交于
This adds tooltips to the event target for events like "opened merge request !XYZ"
-
由 Robert Speicher 提交于
Fix typo Add missing "of" to CI YAML docs. [ci skip] See merge request !4331