Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261

 Update to add all issues to be updated.
 Added functionality, proper tests, documentation and changelog.

social sharing image

commit 79858a631af97c2857700fa44c0e7ba09d621e12
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Fri Aug 25 23:33:04 2017 +0900

    Fix doc

commit d0c864c7f1522bd254458a7d6e1002352f34a143
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Tue Aug 22 22:27:32 2017 +0900

    Add tests

commit 1628eb8598f8ad0e6b573f3fb4fdcf5c3776885b
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Tue Aug 22 10:14:44 2017 +0000

    Update .gitlab-ci.yml

commit 440a3cdd0bb5d7b83f861f6d3762510b40df984a
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Fri Aug 18 14:46:56 2017 +0000

    Update build.rb

commit e925951e35c889bfc0520ce056e7df7befdeb93b
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Thu Aug 17 18:13:17 2017 +0900

    Add changelog

commit 7de5b4f50fc1ff6987c9a861c057c816d4fb285d
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Thu Aug 17 18:11:53 2017 +0900

    ini

`allowed_key_types` is removed and the `minimum_<type>_bits` fields are
renamed to `<tech>_key_restriction`. A special sentinel value (`-1`) signifies
that the key type is disabled.

This also feeds through to the UI - checkboxes per key type are out, inline
selection of "forbidden" and "allowed" (i.e., no restrictions) are in.

As with the previous model, unknown key types are disallowed, even if the
underlying ssh daemon happens to support them. The defaults have also been
changed from the lowest known bit size to "no restriction". So if someone
does happen to have a 768-bit RSA key, it will continue to work on upgrade, at
least until the administrator restricts them.

This is an amalgamation of:

* Cory Hinshaw: Initial implementation !5552
* Rémy Coutable: Updates !9350
* Nick Thomas: Resolve conflicts and add ED25519 support !13712