- 19 11月, 2016 2 次提交
-
-
由 Filipa Lacerda 提交于
-
由 Kamil Trzcinski 提交于
-
- 18 11月, 2016 38 次提交
-
-
由 Adam Niedzielski 提交于
We need to handle annotated tags that are created via GitLab UI. Annotated tags have their own SHA. We have to pass this SHA to post-receive hook to mirror what happens when someone creates an annotated tag in their local repository and pushes it via command line. In order to obtain tag SHA we first have to create it. This is a bit confusing because we create the tag before executing pre-hooks, but there is no way to create a tag outside the repository. If pre-hooks fail we have to clean up after ourselves.
-
由 Z.J. van de Weg 提交于
-
由 Lin Jen-Shin 提交于
This would fix long standing failures running tests on my development machine, which set `Gitlab.config.gitlab.host` to another host because it's not my local computer. Now I finally cannot withstand it and decided to fix them once and for all.
-
由 Felipe Artur 提交于
-
由 James Lopez 提交于
-
由 jacopo-beschi-intersail 提交于
Settings This is done by passing a visibility_level option to the group edit _form. The visibility_level is set to @group.visibility_level in edit ation and to default_group_visibility in the new action.
-
由 Z.J. van de Weg 提交于
This prevents leakage of project names on an endpoint which is unauthenticated and thus open to the world.
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 Rémy Coutable 提交于
It ensures we rely on `Gitlab::Shell`'s public API and not on its internal. Since `Gitlab::Shell` is caching the value of its token, the only way to get the correct token is to call `Gitlab::Shell.secret_token`, not to read the `Gitlab.config.gitlab_shell.secret_file` file! Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Z.J. van de Weg 提交于
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Timothy Andrew 提交于
- Use multiple threads / database connections to: 1. Escape the transaction the spec seems to be running in (`config.use_transactional_fixtures` is off, but `ActiveRecord::Base.connection.open_transactions` is not empty at the beginning of the spec. 2. Simulate a Sidekiq worker performing the hard delete outside of the soft-delete transaction. - The spec is a little clunky, but it was the smallest thing I could get working - and even this took a couple of hours. Let me know if you have any suggestions to improve it!
-
由 James Lopez 提交于
-
由 Timothy Andrew 提交于
Javascript does not support the negative lookbehind assertion (?<!) used in the Ruby regex (to disallow usernames ending in `.git` or `.atom`. Getting the client side code to fully support this format is non-trivial, since we'd either have to heavily complicate the regex used, or modify the frontend code to support more complex validation schemes (it currently uses HTML5 validations). The pragmatic choice is to create a `Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a Javascript-compatible version of `NAMESPACE_REGEX_STR`. The client-side code will not display an error for usernames ending in `.git` and `.atom`, but these will be caught by the server-side validation.
-
由 Andrew Smith 提交于
Ref #24073
-
由 Filipa Lacerda 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
[ci skip]
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
This is the structure Kamil proposed, which leaves us with a bunch of smaller classes. This commits deletes outdated files and tests everything from the SlashCommandService and down (child classes and subcommands)
-
由 Z.J. van de Weg 提交于
Now, each subcommand has its own service, plus I've introduced presenters to be able to delegate the generation of the views.
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
This commit includes a couple of thing: - A chatops controller - Mattermost::CommandService - Mattermost::Commands::(IssueService|MergeRequestService) The controller is the point where mattermost, and later slack will have to fire their payload to. This in turn will execute the CommandService. Thats where the authentication and authorization should happen. So far this is not yet implemented. This should happen in later commits. Per subcommand, in case of `/gitlab issue show 123` issue whould be the subcommand, there is a service to parse the data, and fetch the resource. The resource is passed back to the CommandService which structures the data.
-
由 Kamil Trzcinski 提交于
-
由 Annabel Dunstone Gray 提交于
-
由 Grzegorz Bizon 提交于
-
由 Sean McGivern 提交于
Allow `order_by` and `sort` parameters to `/api/v3/groups.json`. At present, only ordering by name and path is supported, and the default sort is name ascending (alphabetical order).
-
-
-
-
-