Signed-off-by: NRémy Coutable <remy@rymai.me>

Signed-off-by: NRémy Coutable <remy@rymai.me>

So we don't have to do it in CreateDeploymentService
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11695#note_31322649

it a bit more robust against missing options,
which we did guard on for some cases.

To make sure that we're accessing the same instance, so ending up
with `env.external` = `env.external_url` shall be fine.

methods directly from job, avoid duplicating the works.

to the external_url from persisted environment,
and make the other utility methods private as
we don't really need to use them outside of the job.

When getting the max member access for a group of users, we stored the results
in RequestStore. However, this will only return results for project members, so
anyone who wasn't a member of the project would be checked once at the start,
and then once for each comment they made. These queries are generally quite
fast, but no query is faster!

This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.

To avoid the use of slow queries, remove some deprecated methods and encourage
the use of ProjectFinder to find projects.

Add a scope to search for the projects that are starred by a certain user.

This partially reverts be25bbc4.
Signed-off-by: NRémy Coutable <remy@rymai.me>

This reverts commit c425f366, reversing
changes made to 82f6c0f5.
Signed-off-by: NRémy Coutable <remy@rymai.me>

'New issue'/'New merge request' dropdowns should show only projects with issues/merge requests feature enabled