1. 24 4月, 2018 1 次提交
  2. 23 4月, 2018 2 次提交
  3. 20 4月, 2018 1 次提交
  4. 19 4月, 2018 9 次提交
    • D
      Resolve "Improve tooltips of collapsed sidebars" · 49b85262
      Dennis Tang 提交于
      49b85262
    • J
      Moves Uniquify counter in the initializer · 9000626a
      Jacopo 提交于
      9000626a
    • J
      Uses Uniquify to calculate Issue#suggested_branch_name · 6ae3098e
      Jacopo 提交于
      6ae3098e
    • J
      Shows new branch/mr button even when branch exists · 5a29a304
      Jacopo 提交于
      5a29a304
    • K
      Fix direct_upload when records with null file_store are used · a28f25b5
      Kamil Trzciński 提交于
      Old records have a null value of file_store column.
      This causes the problems with current direct_upload implementation,
      as this makes it to choose Store::REMOTE instead of Store::LOCAL.
      
      This change moves the store save when change saving the object.
      a28f25b5
    • D
      Update ProjectStatistics#build_artifacts_size synchronously without summing (#41059) · 03b020f2
      Dylan Griffith 提交于
      Previously we scheduled a worker to just some this but we were running
      into performance issues when the build table was getting too large. So
      now we've updated the code such that this column is updated immediately
      and incremented/decremented by the correct amount whenever artifacts are
      created or deleted.
      
      We've also added the performance optimization that we do not update this
      statistic if a project is deleted because it could result in many
      updates for a project with many builds.
      03b020f2
    • S
      Fix N+1 queries when loading participants for a commit note · 775211bc
      Stan Hu 提交于
      We saw about 10,000 SQL queries for some commits in the NewNoteWorker,
      which stalled the Sidekiq queue for other new notes. The notification
      service took up to 8 minutes to process the commits. Avoiding this
      N+1 query brings the time down significantly.
      
      Closes #45526
      775211bc
    • B
      [Rails5] Fix `User#manageable_groups` · 90716733
      blackst0ne 提交于
      In `arel 7.0` (`7.1.4` version is used for rails5) there were introduced
      some changes that break our code in the `User#manageable_groups` method.
      
      The problem is that `arel_table[:id].in(Arel::Nodes::SqlLiteral)` generates
      wrong `IN ()` construction. The selection for `IN` is missing:
      
      => "\"namespaces\".\"id\" IN (0)"
      
      That caused such spec errors for the `rails5` branch:
      
      ```
      4) User groups with child groups #manageable_groups does not include duplicates if a membership was added for the subgroup
          Failure/Error: expect(user.manageable_groups).to contain_exactly(group, subgroup)
      
            expected collection contained:  [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
            actual collection contained:    []
            the missing elements were:      [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
          # ./spec/models/user_spec.rb:699:in `block (5 levels) in <top (required)>'
          # ./spec/spec_helper.rb:188:in `block (2 levels) in <top (required)>'
          # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:112:in `block in run'
          # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `loop'
          # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `run'
          # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
          # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:30:in `block (2 levels) in setup'
      ```
      
      This commit changes `User#manageable_groups` in the way to drop the usage of
      `Arel::Nodes::SqlLiteral` and adds usage of raw SQL query.
      This change should be updated when we're migrated to Rails 5.2 because arel
      was fixed in `9.0.0` (which is used in Rails 5.2).
      90716733
    • F
      e8a27a67
  5. 18 4月, 2018 3 次提交
  6. 17 4月, 2018 2 次提交
  7. 16 4月, 2018 1 次提交
    • A
      Double-check next value for internal ids. · 14acbf24
      Andreas Brandl 提交于
      This is useful for a transition period to migrate away from
      `NoninternalAtomicId`. In a situation where both the old and new code to
      generate a iid value is run at the same time (for example, during a
      deploy different nodes may serve both versions), this will lead to
      problems regarding the correct `last_value`. That is, what we track in
      `InternalId` may get out of sync with the maximum iid present for
      issues.
      
      With this change, we double-check that and correct the `last_value` with
      the maximum iid found in issues if necessary.
      
      This is subject to be removed with the 10.8 release and tracked over
      here: https://gitlab.com/gitlab-org/gitlab-ce/issues/45389
      
      Closes #45269.
      14acbf24
  8. 15 4月, 2018 1 次提交
  9. 12 4月, 2018 2 次提交
  10. 11 4月, 2018 2 次提交
  11. 10 4月, 2018 3 次提交
  12. 09 4月, 2018 6 次提交
  13. 08 4月, 2018 1 次提交
  14. 07 4月, 2018 6 次提交