1. 21 9月, 2019 1 次提交
  2. 18 9月, 2019 1 次提交
  3. 13 9月, 2019 1 次提交
  4. 06 9月, 2019 1 次提交
  5. 04 9月, 2019 1 次提交
  6. 11 7月, 2019 1 次提交
  7. 05 5月, 2019 1 次提交
  8. 18 4月, 2019 1 次提交
  9. 13 3月, 2019 1 次提交
  10. 12 2月, 2019 1 次提交
    • S
      Log queue duration in production_json.log · 51ca7922
      Stan Hu 提交于
      `queue_duration` is a useful metric that is currently in api_json.log
      but not in production_json.log. We should add it because it tells us how
      long the request sat in Workhorse before Unicorn processed it. Having
      this field enables the support team to better troubleshoot when delays
      began to happen.
      51ca7922
  11. 24 1月, 2019 1 次提交
  12. 16 1月, 2019 2 次提交
  13. 07 1月, 2019 1 次提交
  14. 05 1月, 2019 1 次提交
    • S
      Fix multipart attachments not uploading · 7d28e39f
      Stan Hu 提交于
      Mixing and matching the use of Rack::Request and ActionDispatch::Request
      in Rails 5 is bad, particularly if you have middleware that
      manipulates or accesses environment variables.
      
      `Gitlab::Middleware::Multipart` attempts to rewrite request parameters
      to the proper values (e.g. replacing `data_file` with
      `UploadedFile`). It does this by calling `Rack::Request#update_params`,
      which essentially updates `env['rack.request.form_hash']`.
      
      By changing to `ActionDispatch::Request`, the Go middleware was causing
      the request parameters to be stored inside
      `env['action_dispatch.request.request_parameters']`. Later calls to
      `Rack::Request#update_params` would not have any effect because it would
      attempt to update `env['rack.request.form_has']` instead of
      `env['action_dispatch.request.request_parameters']`. As a result, the
      controller still saw the old parameters.
      
      Since the Go middleware appears to be using `ActionDispatch::Request`
      for authorization methods, we can switch the multipart middleware to
      use it too.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9035
      7d28e39f
  15. 03 1月, 2019 3 次提交
  16. 16 12月, 2018 1 次提交
  17. 07 12月, 2018 2 次提交
  18. 17 11月, 2018 1 次提交
    • G
      Enable even more frozen string for lib/gitlab · 7ec8af50
      gfyoung 提交于
      Enables frozen string for the following:
      
      * lib/gitlab/hook_data/**/*.rb
      * lib/gitlab/i18n/**/*.rb
      * lib/gitlab/import/**/*.rb
      * lib/gitlab/import_export/**/*.rb
      * lib/gitlab/kubernetes/**/*.rb
      * lib/gitlab/legacy_github_import/**/*.rb
      * lib/gitlab/manifest_import/**/*.rb
      * lib/gitlab/metrics/**/*.rb
      * lib/gitlab/middleware/**/*.rb
      
      Partially addresses gitlab-org/gitlab-ce#47424.
      7ec8af50
  19. 10 11月, 2018 1 次提交
  20. 06 9月, 2018 1 次提交
  21. 21 8月, 2018 1 次提交
    • J
      Add public/uploads/tmp to allowed upload paths · 4ca9f3b4
      Jan Provaznik 提交于
      When direct_upload is enabled and a for file is being uploaded,
      then workhorse uses `public/uploads/tmp` path. If `uploads.storage_path`
      i sset to a different directory, then upload fails because
      `public/uploads/tmp` is not in allowed paths.
      4ca9f3b4
  22. 29 7月, 2018 2 次提交
  23. 08 7月, 2018 1 次提交
    • J
      Add FileUploader.root to allowed upload paths · e2ec97a9
      Jan Provaznik 提交于
      Currently we check if uploaded file is under
      `Gitlab.config.uploads.storage_path`, the problem is that
      uploads are placed in `uploads` subdirectory which is symlink.
      
      In allow_path? method we check real (expanded) paths, which causes
      that `Gitlab.config.uploads.storage_path` is expaned into symlink
      path and there is a mismatch with upload file path.
      
      By adding `Gitlab.config.uploads.storage_path/uploads` into allowed
      paths, this path is expaned during path check.
      
      `Gitlab.config.uploads.storage_path` is left there intentionally in case
      some uploader wouldn't use `uploads` subdir.
      e2ec97a9
  24. 07 7月, 2018 1 次提交
  25. 02 7月, 2018 1 次提交
  26. 27 6月, 2018 1 次提交
  27. 02 5月, 2018 1 次提交
  28. 05 4月, 2018 1 次提交
  29. 22 3月, 2018 1 次提交
  30. 08 3月, 2018 1 次提交
  31. 03 3月, 2018 1 次提交
  32. 23 2月, 2018 1 次提交
  33. 13 2月, 2018 1 次提交
    • A
      Honour workhorse provided file name · 34c2a59c
      Alessio Caiazza 提交于
      In the attempt to unify file uploading at workhorse level gitlab-org/gitlab-workhorse!230
      we moved to a prefix-based tempfile creation in order to avoid upload collisions.
      
      Artifacts and LFS uploads already set original_filename to workhorse provided filename
      
      This commit add the same feature to `Gitlab::Middleware::Multipart`
      34c2a59c
  34. 07 2月, 2018 2 次提交