1. 03 6月, 2016 6 次提交
  2. 02 6月, 2016 29 次提交
  3. 01 6月, 2016 5 次提交
    • D
      Merge branch 'separate-banzai-references' into 'master' · 2d084dd8
      Douwe Maan 提交于
      Separate reference gathering from rendering
      
      This is a required step to allow batch processing when gathering references. This in turn would allow grabbing (for example) all mentioned users of an issue/merge request using a single query.
      
      cc @rspeicher @DouweM 
      
      See merge request !3969
      2d084dd8
    • Y
      Refactor Participable · 580d2501
      Yorick Peterse 提交于
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
      580d2501
    • D
      Merge branch 'fix-cancelable-retryable' into 'master' · ef6fe42e
      Douwe Maan 提交于
      Fix cancelability and retriablity of pipeline with generic statuses
      
      Currently it's not possible to cancel or retry generic status since this is external thing to GitLab.
      
      This fixes shown actions of pipelines containing only these actions.
      
      
      See merge request !4380
      ef6fe42e
    • R
      Merge branch 'fix/error-500-in-pipeline-when-fork' into 'master' · 4581e71c
      Rémy Coutable 提交于
      Use project that belongs to pipeline in view
      
      ## What does this MR do?
      
      This MR makes project in pipelines view match the one that pipeline has been created for.
      
      Closes #17943 
      
      See merge request !4376
      4581e71c
    • R
      Don't advertise the use of "ci skip" in the CONTRIBUTING guide · ea80259b
      Rémy Coutable 提交于
      Now that we autoscale runner, we don't need to optimize for their usage
      anymore. Abusing of "ci skip", for instance for view changes can lead to
      broken specs, so let's just not use it!
      Signed-off-by: NRémy Coutable <remy@rymai.me>
      ea80259b