- 18 7月, 2017 11 次提交
-
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Andrew Newdigate 提交于
-
由 Simon Knox 提交于
don't treat aborted requests as failures, they are often triggered during unload (e.g after clicking a link)
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
We also try to use instance variable to cache the result if RequestStore is not available, so we could keep the same logic, using the same cache key. Also introduce a way to specify method specific cache key
-
- 17 7月, 2017 7 次提交
-
-
由 Lin Jen-Shin 提交于
I don't like the idea of `RequestStore` at all, because it's just a global state which shouldn't be used at all. But we have a number of places calling `ProtectedBranch.protected?` and `ProtectedTag.protected?` in a loop for the same user, project, and ref whenever we're checking against if the jobs for a given pipeline is accessible for a given user. This means we're effectively making N queries for the same thing over and over. To properly fix this, we need to change how we check the permission, and that could be a huge work. To solve this quickly, adding a cache layer for the given request would be quite simple to do. We're already doing this in Commit#author, and this is extending that idea and make it generalized.
-
由 Grzegorz Bizon 提交于
Simply re-raise an exception when it occurs, but guarantee that no background migration is lost in the process.
-
由 Nick Thomas 提交于
In EE, we make use of `namespace#public?` in projects. When the project is in a personal namespace, this breaks as the `public?` helper isn't present.
-
由 Lin Jen-Shin 提交于
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
It also makes it possible to gracefully retry a migration in order to avoid problems like deadlocks.
-
由 Mark Fletcher 提交于
-
- 15 7月, 2017 2 次提交
-
-
由 Lin Jen-Shin 提交于
So that whenever this failed: expect(response).to have_gitlab_http_status(200) We see what's the response there. Here's an example: ``` 1) API::Settings Settings PUT /application/settings custom repository storage type set in the config updates application settings Failure/Error: expect(response).to have_gitlab_http_status(200) expected the response to have status code 200 but it was 400. The response was: {"error":"password_authentication_enabled, signin_enabled are mutually exclusive"} ```
-
由 Jacob Vosmaer 提交于
-
- 14 7月, 2017 15 次提交
-
-
由 Filipa Lacerda 提交于
-
由 Tiago Botelho 提交于
-
由 Jacob Vosmaer 提交于
-
由 Grzegorz Bizon 提交于
-
由 Jacob Vosmaer 提交于
-
由 kushalpandya 提交于
-
由 Grzegorz Bizon 提交于
-
由 Sean McGivern 提交于
This reverts merge request !12633
-
由 Yorick Peterse 提交于
These indexes are not recorded in the WAL (at least until PostgreSQL 10) and this isn't worth the minor performance improvement over btree indexes.
-
由 Grzegorz Bizon 提交于
We first pop a job from the Sidekiq queue / scheduled set and only if this has been successfully deleted we process the job. This makes it possible to minimize a possibility of a race condition happening.
-
由 kushalpandya 提交于
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
由 Stan Hu 提交于
Somehow Rails.cache.fetch occasionally returns `nil` values, which causes this endpoint to crash. Closes #35094
-
- 13 7月, 2017 5 次提交
-
-
由 Robin Bobbitt 提交于
When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController
-
由 Grzegorz Bizon 提交于
-
由 Jacob Vosmaer 提交于
-
由 Shinya Maeda 提交于
-
由 Bob Van Landuyt 提交于
Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
-