- 03 12月, 2016 27 次提交
-
-
由 Achilleas Pipinellis 提交于
This reverts merge request !7909
-
由 Achilleas Pipinellis 提交于
Link to old patch update guide now that we install workhorse with a raketask Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/25284 See merge request !7909
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Fatih Acet 提交于
Resolve "Highlighting lines is broken" ## What does this MR do? Add line highlighting back to diff view. This was working in the MR "changes" tab, but not on a commit page such as https://gitlab.com/winniehell/reproduction-area/commit/9101e66f5761929002956e0f2dd65d7f8643903d ~~This MR also fixes the `scrollToElement` method in `MergeRequestTabs` to account for the extra height of the tab links which are now fixed in place once they are scrolled to the top of the screen.~~ (removed in favor of !7051) This MR also refactors much of the `Diff` and `MergeRequestTabs` classes to es6 syntax in an effort to increase readability. ## Are there points in the code the reviewer needs to double check? Check out both MR "change" tabs and commit diff pages and ensure that line highlighting works and that loading a page with one of these permalink hashes correctly highlights and scrolls to the line. Ensure I didn't break anything in the transition to es6 syntax. Check the functionality of the tabs on MR pages, as well as diff page interactivity (unfolding hidden lines in diff files, adding comments to diffs, etc). I have checked these myself, but another set of eyes would be a good idea. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23696 See merge request !7090
-
由 Sean McGivern 提交于
If SSH prototol is disabled don't say the user requires SSH keys Closes #24921 See merge request !7840
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Luke Bennett 提交于
re-apply MR !6285 "Added forceLoad ability to singleFileDiffs, added callback to getContentHTML, added conditional force load if a collapsed diff line anchor is found" Use url utility to retrieve hash
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
temporarily revert "Added forceLoad ability to singleFileDiffs, added callback to getContentHTML, added conditional force load if a collapsed diff line anchor is found" This reverts commit d2ee3808.
-
由 Jacob Schatz 提交于
Use system font Just for fun.... ### macOS Chrome (San Francisco):  ### macOS Safari (San Francisco):  #### Ubuntu Firefox (Ubuntu):  #### Windows 7 IE 11 (Segoe UI):  See merge request !7545
-
由 Rémy Coutable 提交于
Adds a default commit message when adding a README (#25167) Closes #25167 See merge request !7903
-
由 Jacob Schatz 提交于
Change ref property to commitRef ## What does this MR do? Changes `ref` prop to `commitRef` because `ref` is a reserved word in Vue.js ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #25264 //cc @selfup See merge request !7901
-
由 mattl 提交于
-
由 mattl 提交于
-
由 Alfredo Sumaran 提交于
Clean up common_utils.js ## What does this MR do? - Remove unused functions from `common_utils.js`. - Move functions which are used from only one file to that file. ## Why was this MR needed? Because some utils weren't that common (anymore). See merge request !7318
-
- 02 12月, 2016 13 次提交
-
-
由 Rémy Coutable 提交于
Fixes ActionView::Template::Error: undefined method `text?` for nil:NilClass Closes #25251 See merge request !7893
-
由 Filipa Lacerda 提交于
-
由 Filipa Lacerda 提交于
-
由 Filipa Lacerda 提交于
-
由 Annabel Dunstone Gray 提交于
Enable ColorVariable in scss-lint ## What does this MR do? - Enable the ColorVariable rule in`.scss-lint.yml` - Change all color literals in `app/assets/stylesheets` to color variables ## Why was this MR needed? - Enforce the usage of color variables to better constrain the various color values being used ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23500 See merge request !7319
-
由 Annabel Dunstone Gray 提交于
Fixed row margins on Pipeline Settings page in order to unify styles On the ```project-name/pipelines/settings``` page, I removed the ```.row``` styling on ```.build-status``` and ```.coverage-report``` as it was causing those rows to not have the same margins as the "CI/CD Pipeline" row. Now, they are even as you can see below:   Closes #25098 cc: @filipa See merge request !7881
-
由 Andrew Smith 提交于
-
由 Rémy Coutable 提交于
Simplify `branch_name` in bin/changelog The `--short` option has existed since at least 1.8.1: https://git-scm.com/docs/git-symbolic-ref/1.8.1 See merge request !7891
-
由 Valery Sizov 提交于
-
由 Rémy Coutable 提交于
Speed up project snippet security request specs Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899 See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7779 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7813 See merge request !7890
-
由 Robert Speicher 提交于
Use gitlab-workhorse 1.1.0. Adds Prometheus support and more. See merge request !7868
-
由 Robert Speicher 提交于
The `--short` option has existed since at least 1.8.1: https://git-scm.com/docs/git-symbolic-ref/1.8.1
-