- 07 7月, 2017 1 次提交
-
-
由 Rémy Coutable 提交于
-
- 06 7月, 2017 8 次提交
-
-
由 tauriedavis 提交于
-
由 Timothy Andrew 提交于
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
由 Timothy Andrew 提交于
-
由 Timothy Andrew 提交于
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
由 Timothy Andrew 提交于
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
由 Tiago Botelho 提交于
-
由 Douwe Maan 提交于
-
由 Sean McGivern 提交于
This reverts merge request !11963
-
- 05 7月, 2017 6 次提交
-
-
由 Phil Hughes 提交于
Closes #34711
-
由 Lin Jen-Shin 提交于
-
由 Filipa Lacerda 提交于
-
由 Phil Hughes 提交于
-
由 Phil Hughes 提交于
Closes #34670
-
- 04 7月, 2017 8 次提交
-
-
由 Jose Ivan Vargas 提交于
-
由 Diego Souza 提交于
-
由 Phil Hughes 提交于
-
由 Lin Jen-Shin 提交于
-
由 Timothy Andrew 提交于
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
由 Timothy Andrew 提交于
-
由 Timothy Andrew 提交于
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
由 Timothy Andrew 提交于
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']` - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
- 03 7月, 2017 6 次提交
-
-
由 Bryce Johnson 提交于
-
由 Simon Knox 提交于
-
由 Dimitrie Hoekstra 提交于
-
由 Luke "Jared" Bennett 提交于
-
由 Z.J. van de Weg 提交于
Earlier, this was part of another MR, but that got split. Didn't pick that commit, as there were many merge conflicts. Vim macros seemed faster.
-
由 Bryce Johnson 提交于
-
- 01 7月, 2017 2 次提交
-
-
由 tauriedavis 提交于
-
由 Phil Hughes 提交于
-
- 30 6月, 2017 8 次提交
-
-
由 Sean McGivern 提交于
This runs a slightly slower query to get the issue and MR counts in the navigation, but caches by user type (can see all / none confidential issues) for two minutes.
-
由 Sean McGivern 提交于
When we are filtering by a single project, and the current user has access to see confidential issues on that project, we don't need to filter by confidentiality at all - just as if the user were an admin. The filter by confidentiality often picks a non-optimal query plan: for instance, AND-ing the results of all issues in the project (a relatively small set), and all issues in the states requested (a huge set), rather than just starting small and winnowing further.
-
由 Lin Jen-Shin 提交于
-
由 Nick Thomas 提交于
-
由 Tim Zallmann 提交于
-
由 Douwe Maan 提交于
-
由 Taurie Davis 提交于
-
由 Bryce Johnson 提交于
This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
-
- 29 6月, 2017 1 次提交
-
-
由 Annabel Dunstone Gray 提交于
-