1. 12 8月, 2016 1 次提交
    • S
      Fix bug where destroying a namespace would not always destroy projects · cb8a425b
      Stan Hu 提交于
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      
      Closes #17893
      cb8a425b
  2. 11 8月, 2016 1 次提交
    • S
      Clean up project destruction · 4955a47c
      Stan Hu 提交于
      Instead of redirecting from the project service to the service and back to the model,
      put all destruction code in the service. Also removes a possible source of failure
      where run_after_commit may not destroy the project.
      4955a47c
  3. 16 3月, 2016 1 次提交
  4. 29 1月, 2016 1 次提交
  5. 03 6月, 2015 3 次提交