- 05 3月, 2015 25 次提交
-
-
由 Robert Schilling 提交于
Update rugments, fixes #8900
-
由 Stefan Tatschner 提交于
-
由 Dmitriy Zaporozhets 提交于
Improve projects list * Add search filtering for group projects * Show all user projects on dashboard * Refactor projects list into one view * Hide big list of projects with 'Show all' button For #2069 See merge request !1636
-
由 Dmitriy Zaporozhets 提交于
Increase timeout for Git-over-HTTP requests. Fixes #2081 and https://gitlab.com/gitlab-org/gitlab-ce/issues/232. Normal web requests are bound by the `Rack::Timeout` timeout of 60 seconds, while Grack Git-over-HTTP requests are only bound by Unicorn's timeout which is now set to 1 hour, which should be plenty. The omnibus package should be updated to no longer use `unicorn['worker_timeout']` for the Unicorn timeout, but to set the `Slowpoke.timeout`. See merge request !1619
-
由 Dmitriy Zaporozhets 提交于
-
由 Dmitriy Zaporozhets 提交于
* Add search filtering for group projects * Show all user projects on dashboard * Refactor projects list into one view * Hide big list of projects with 'Show all' button
-
由 Dmitriy Zaporozhets 提交于
Update spring to 1.3.3 See merge request !1635
-
由 Dmitriy Zaporozhets 提交于
Re-annotate models See merge request !1634
-
由 Dmitriy Zaporozhets 提交于
-
由 Douwe Maan 提交于
-
由 Dmitriy Zaporozhets 提交于
-
由 Dmitriy Zaporozhets 提交于
Add more Slack notifications for issue and merge request events From https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/237 by Stan Hu. See merge request !1556
-
由 Marin Jankovski 提交于
-
由 Marin Jankovski 提交于
-
由 Marin Jankovski 提交于
-
由 Dmitriy Zaporozhets 提交于
Web Hook sends email of pusher See merge request !1630
-
由 Marin Jankovski 提交于
Add Service Templates to CHANGELOG See merge request !1633
-
由 Dmitriy Zaporozhets 提交于
Advise on how to help others. See merge request !1632
-
由 Dmitriy Zaporozhets 提交于
Bump gitlab_git to rc15 For #2033 See merge request !1631
-
由 Patricio Cano 提交于
-
由 Sytse Sijbrandij 提交于
-
由 Dmitriy Zaporozhets 提交于
Add dashboard milestones. Closes #1422. ![Screen_Shot_2015-03-03_at_16.20.36](https://dev.gitlab.org/gitlab/gitlabhq/uploads/795b480a2552e1d26436c3db2158cb81/Screen_Shot_2015-03-03_at_16.20.36.png) See merge request !1621
-
由 Dmitriy Zaporozhets 提交于
-
由 Dmitriy Zaporozhets 提交于
-
由 Valery Sizov 提交于
-
- 04 3月, 2015 15 次提交
-
-
由 Robert Schilling 提交于
Connect GitLab buttons doc The "GitLab buttons in Gmail" documentation was not linked from anywhere else. Instead of assuming that these docs are not current, or should not be accessible, I've linked to them from doc/integrations/README.md. If linking is the less desirable approach, please advise. See merge request !339
-
由 Ewan Edwards 提交于
Merge branch 'connect_gitlab_buttons_doc' of gitlab.com:perforce/gitlab-ce into connect_gitlab_buttons_doc
-
由 Ewan Edwards 提交于
-
由 Ewan Edwards 提交于
else. It is now linked.
-
由 Douwe Maan 提交于
-
由 Marin Jankovski 提交于
Autosave title and description of new issues/MRs. Closes #2048. See merge request !1595
-
由 Marin Jankovski 提交于
Commits statistic grammar Fixes #2089 Changed spelling from Commits statistic to Commit statistics See merge request !1625
-
由 Marin Jankovski 提交于
Changed to 'View Build Page' Fixes #2093 Changes 'Build Page' to 'View build page' See merge request !1626
-
由 Dmitriy Zaporozhets 提交于
-
由 Sabba Petri 提交于
-
由 Sabba Petri 提交于
-
由 Sabba Petri 提交于
-
由 Marin Jankovski 提交于
Fix namespace in merge request url building Changes in 42387b73 now require namespace specification and broke abc69c89. There are additional helper functions in c530ca00, but this seemed easier not to rely on them. See merge request !363
-
由 Stan Hu 提交于
-
由 Marin Jankovski 提交于
Fix server error when editing a note to "+1" or "-1" ### Summary If a user edits a comment with "+1" or "-1" in the beginning, the POST returns an Internal Server error. (issue #1151). This merge request resolves that error. ### Steps to reproduce 1. Comment on an issue with "Test comment". 2. Edit the issue. 3. Write "+1" and click "Save Comment". ### Expected behavior The edited note should be saved and refreshed. Any previous upvotes/downvotes from the user should contain a strikethrough. ### Observed behavior Internal Error ### Relevant logs ``` Started PUT "/avocode/avocode-manager/notes/4996" for 185.33.136.107 at 2015-02-28 17:11:53 +0100 Processing by Projects::NotesController#update as JS Parameters: {"utf8"=>"✓", "authenticity_token"=>"*removed*", "note"=>{"note"=>"+1\r\n\r\nYes"}, "commit"=>"Save Comment", "project_id"=>"avocode/avocode-manager", "id"=>"4996"} Completed 500 Internal Server Error in 86ms ActionView::Template::Error (undefined method `each' for nil:NilClass): 28: %span.note-last-update 29: = note_timestamp(note) 30: 31: - if note.superceded?(@notes) 32: - if note.upvote? 33: %span.vote.upvote.label.label-gray.strikethrough 34: %i.fa.fa-thumbs-up app/models/note.rb:495:in `superceded?' app/views/projects/notes/_note.html.haml:31:in `_app_views_projects_notes__note_html_haml___812277000516355462_69988235638820' app/controllers/projects/notes_controller.rb:71:in `note_to_html' app/controllers/projects/notes_controller.rb:103:in `render_note_json' app/controllers/projects/notes_controller.rb:39:in `block (2 levels) in update' app/controllers/projects/notes_controller.rb:38:in `update' ``` ### Fix It turns out no tests were present for the "Edit Issue" functionality. I added spinach tests to exercise this and reproduced the error. Most of the routes in `notes_controller.rb` appear to render all notes for the given discussion. `_form.html.haml` needs the full list of notes commented by the user to add strikethroughs for older upvotes/downvotes. However, only the `index` route appeared to obtain this information. The fix is to add a `before_filter` to obtain all the user's notes beforehand, except in the delete case where this information is not needed. Things to watch: `NotesFinder` needs `target_type` and `target_id` to determine what to do. I'm not sure if there is a conscious effort to phase these keywords out in favor of `noteable_type` and `noteable_id`. See merge request !360
-