- 09 10月, 2018 2 次提交
-
-
由 Mike Greiling 提交于
-
由 Stan Hu 提交于
Closes #51003
-
- 08 10月, 2018 2 次提交
-
-
由 Yorick Peterse 提交于
This refactors the TodoService class according to our code reuse guidelines. The resulting code is a wee bit more verbose, but it allows us to decouple the column names from the input, resulting in fewer changes being necessary when we change the schema. One particular noteworthy line in TodoService is the following: todos_ids = todos.update_state(state) Technically this is a violation of the guidelines, because `update_state` is a class method, which services are not supposed to use (safe for a few allowed ones). I decided to keep this, since there is no alternative. `update_state` doesn't produce a relation so it doesn't belong in a Finder, and we can't move it to another Service either. As such I opted to just use the method directly. Cases like this may happen more frequently, at which point we should update our documentation with some sort of recommendation. For now, I want to refrain from doing so until we have a few more examples.
-
由 Yorick Peterse 提交于
This refactors the TodosFinder finder according to the new code reuse rules, as enforced by the CodeReuse cops. I also changed some of the methods to use regular if statements, instead of assignments and/or early returns. This results in a more natural flow when reading the code, and it makes it harder to accidentally return the wrong result.
-
- 07 10月, 2018 2 次提交
-
-
由 Brett Walker 提交于
-
由 Dmitriy Zaporozhets 提交于
-
- 06 10月, 2018 13 次提交
-
-
由 George Tsiolis 提交于
-
由 Jasper Maes 提交于
-
由 Jasper Maes 提交于
-
由 Oswaldo Ferreira 提交于
-
由 Oswaldo Ferreira 提交于
-
由 Gabriel Mazetto 提交于
In EE it will render a Geo Status widget when Geo is enabled and it is in a secondary node. Also added minimal specs to that action.
-
由 Alessio Caiazza 提交于
Auto DevOps deployment strategies now supports timed incremental rollout. We are deprecating the usage of INCREMENTAL_ROLLOUT_ENABLED environment variable in Auto DevOps template. The new behavior will be driven by the INCREMENTAL_ROLLOUT_MODE variable that can either be manual (same as INCREMENTAL_ROLLOUT_ENABLED) or timed. Rollout deployments will be executed using a 5 minute delay between each job.
-
由 Brett Walker 提交于
-
由 Alessio Caiazza 提交于
-
由 Jeremy Watson 提交于
-
由 Jeremy Watson 提交于
-
由 Jeremy Watson 提交于
-
由 Simon Knox 提交于
-
- 05 10月, 2018 18 次提交
-
-
由 Tuomo Ala-Vannesluoma 提交于
-
由 Gilbert Roulot 提交于
Adds CI_SERVER_VERSION_MAJOR, CI_SERVER_VERSION_MINOR, CI_SERVER_VERSION_PATCH to the list of environment variables passed to CI jobs.
-
由 Sean McGivern 提交于
EE needs :request_store to cache license queries - otherwise we will blow past the query limit just with `SELECT * FROM licenses` over and over.
-
由 Sean McGivern 提交于
We don't think this is needed any more - see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21521, and https://gitlab.com/gitlab-org/gitlab-ce/issues/52271 for removing the flag.
-
由 Nick Thomas 提交于
-
由 Sean McGivern 提交于
-
由 Fabian Schneider 提交于
-
由 Shinya Maeda 提交于
-
由 Winnie Hellmann 提交于
-
由 Shinya Maeda 提交于
-
由 Shinya Maeda 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Marc Schwede 提交于
-
由 Jasper Maes 提交于
Rails5 has params[:file_type] as '' if file_type is included as nil in the request
-
由 Robert Speicher 提交于
This will allow an explicitly-disabled feature flag to override a feature being available for a project. As an extreme example, we could quickly disable issues across all projects at runtime by running `Feature.disable(:issues)`.
-
由 Felipe Artur 提交于
Moves the related_branches method from Issue model to RelatedBranchesService
-
由 Brett Walker 提交于
-
由 Mario de la Ossa 提交于
Changes `Banzai::CrossProjectReference#parent_from_ref` to return the project in the context if the project's `full_path` matches the ref we're looking for, as it makes no sense to go to the database to find a Project we already have loaded.
-
- 04 10月, 2018 3 次提交
-
-
由 Alessio Caiazza 提交于
-
由 Sean McGivern 提交于
If we don't call #to_a, we're relying on the members already being loaded from elsewhere. Otherwise we'll do a separate query for each user: [1] pry(main)> Project.first.team.members.include?(User.first) Project Load (0.7ms) SELECT "projects".* FROM "projects" ORDER BY "projects"."id" ASC LIMIT 1 ↳ (pry):3 User Load (1.8ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1 ↳ (pry):3 User Exists (0.6ms) SELECT 1 AS one FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1 AND "users"."id" = $2 LIMIT 1 [["project_id", 1], ["id", 1]] ↳ (pry):3 => true [2] pry(main)> Project.first.team.members.to_a.include?(User.first) Project Load (12.8ms) SELECT "projects".* FROM "projects" ORDER BY "projects"."id" ASC LIMIT 1 ↳ (pry):1 User Load (9.6ms) SELECT "users".* FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1 [["project_id", 1]] ↳ (pry):1 User Load (0.6ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1 ↳ (pry):1 => true
-
由 Sean McGivern 提交于
-