1. 16 10月, 2019 1 次提交
  2. 09 10月, 2019 1 次提交
  3. 19 10月, 2018 1 次提交
  4. 08 6月, 2018 1 次提交
  5. 17 4月, 2018 1 次提交
  6. 11 4月, 2018 1 次提交
  7. 06 4月, 2018 1 次提交
  8. 04 4月, 2018 1 次提交
  9. 19 7月, 2017 1 次提交
  10. 14 7月, 2017 1 次提交
  11. 06 3月, 2017 1 次提交
  12. 06 8月, 2016 4 次提交
  13. 29 7月, 2016 5 次提交
    • T
      Implement final review comments from @rymai. · cebcc417
      Timothy Andrew 提交于
      1. Instantiate `ProtectedBranchesAccessSelect` from `dispatcher`
      
      2. Use `can?(user, ...)` instead of `user.can?(...)`
      
      3. Add `DOWNTIME` notes to all migrations added in !5081.
      
      4. Add an explicit `down` method for migrations removing the
         `developers_can_push` and `developers_can_merge` columns, ensuring that
         the columns created (on rollback) have the appropriate defaults.
      
      5. Remove duplicate CHANGELOG entries.
      
      6. Blank lines after guard clauses.
      cebcc417
    • T
      Use `Gitlab::Access` to protected branch access levels. · 0a8aeb46
      Timothy Andrew 提交于
      1. It makes sense to reuse these constants since we had them duplicated
         in the previous enum implementation. This also simplifies our
         `check_access` implementation, because we can use
         `project.team.max_member_access` directly.
      
      2. Use `accepts_nested_attributes_for` to create push/merge access
         levels. This was a bit fiddly to set up, but this simplifies our code
         by quite a large amount. We can even get rid of
         `ProtectedBranches::BaseService`.
      
      3. Move API handling back into the API (previously in
         `ProtectedBranches::BaseService#translate_api_params`.
      
      4. The protected branch services now return a `ProtectedBranch` rather
         than `true/false`.
      
      5. Run `load_protected_branches` on-demand in the `create` action, to
         prevent it being called unneccessarily.
      
      6. "Masters" is pre-selected as the default option for "Allowed to Push"
         and "Allowed to Merge".
      
      7. These changes were based on a review from @rymai in !5081.
      0a8aeb46
    • T
    • T
      Allow setting "Allowed To Push/Merge" while creating a protected branch. · 12387b4d
      Timothy Andrew 提交于
      1. Reuse the same dropdown component that we used for updating these
         settings (`ProtectedBranchesAccessSelect`). Have it accept options
         for the parent container (so we can control the elements it sees) and
         whether or not to save changes via AJAX (we need this for update, but
         not create).
      
      2. Change the "Developers" option to "Developers + Masters", which is
         clearer.
      
      3. Remove `developers_can_push` and `developers_can_merge` from the
         model, since they're not needed anymore.
      12387b4d
    • T
      Add "No One Can Push" to the protected branches UI. · ab6096c1
      Timothy Andrew 提交于
      1. Move to dropdowns instead of checkboxes. One each for "Allowed to
         Push" and "Allowed to Merge"
      
      2. Refactor the `ProtectedBranches` coffeescript class into
         `ProtectedBranchesAccessSelect`.
      
      3. Modify the backend to accept the new parameters.
      ab6096c1
  14. 18 7月, 2016 1 次提交
  15. 14 7月, 2016 1 次提交
  16. 13 7月, 2016 2 次提交
  17. 05 7月, 2016 1 次提交
    • T
      Modify the frontend for wildcard protected branches. · 2a5cb7ec
      Timothy Andrew 提交于
      1. Allow entering any branch name for a protected branch.
      
          - Either pick from a list of options, or enter it manually
          - You can enter wildcards.
      
      2. Display branches matching a protected branch.
      
          -  Add a `ProtectedBranches#show` page that displays the branches
             matching the given protected branch, or a message if there are no
             matches.
      
          - On the `index` page, display the last commit for an exact match,
            or the number of matching branches for a wildcard match.
      
          -  Add an `iid` column to `protected_branches` - this is what we use for
             the `show` page URL.
      
          -  On the off chance that this feature is unnecessary, this commit
             encapsulates it neatly, so it can be removed without affecting
             anything else.
      
      3. Remove the "Last Commit" column from the list of protected branches.
      
          - There's no way to pull these for wildcard protected branches, so it's
            best left for the `show` page.
      
          - Rename the `@branches` instance variable to `@protected_branches`
      
          - Minor styling changes with the "Unprotect" button - floated right
            like the "Revoke" button for personal access tokens
      
      4. Paginate the list of protected branches.
      
      5. Move the instructions to the left side of the page.
      2a5cb7ec
  18. 03 6月, 2016 2 次提交
  19. 16 5月, 2016 1 次提交
  20. 26 4月, 2016 1 次提交
  21. 19 10月, 2015 1 次提交
  22. 14 3月, 2015 1 次提交
  23. 15 2月, 2015 1 次提交
    • V
      Upgrade to Rails 4.1.9 · 76aad9b7
      Vinnie Okada 提交于
      Make the following changes to deal with new behavior in Rails 4.1.2:
      
      * Use nested resources to avoid slashes in arguments to path helpers.
      76aad9b7
  24. 30 12月, 2014 1 次提交
  25. 27 12月, 2014 1 次提交
  26. 26 12月, 2014 1 次提交