In case we end up wanting to use it in Spinach as well.

This fixes spec/mailers/notify_spec

Also only require email_spec in the one place it's used

Signed-off-by: NJeroen van Baarsen <jeroenvanbaarsen@gmail.com>

Closes #1815

Fixes #2384.

See: https://github.com/gitlabhq/gitlabhq/pull/9368#issuecomment-110350335

Fix 403 Access Denied error messages when accessing Labels section in a project that has MRs disabled but issues enabled

Closes #1813

Now it executes a single query instead of a possible three at the cost
of some scary-looking ARel calls.

Minor refactoring, add specs, changes arguments to use keywords.

Code tweaks in 45e9150a caused the ldap_person method to not return expected results.
Improved tests to cover the ldap_person method, which was previously stubbed.

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

The creation of cross references for external issues (which would fail)
is now prevented.

Fixes #1650, GH-9333.