- 30 4月, 2019 19 次提交
-
-
由 Vladimir Shushlin 提交于
Domain will be removed by verification worker after 1 week of being disabled
-
由 Francisco Javier López 提交于
In order to make `LfsImportService` more reusable, we need to extract the logic inside `ImportService` and encapsulate it into the service.
-
由 Dylan Griffith 提交于
-
由 Dylan Griffith 提交于
-
由 Dylan Griffith 提交于
-
由 Dylan Griffith 提交于
These builder methods are using user provided input inside a public_send but this is safe to do in this instance because before they are called we check before calling them that they match an expected application name.
-
由 Dylan Griffith 提交于
In order to not miss any errors since we are not checking the return value of update
-
由 Dylan Griffith 提交于
-
由 Thong Kuah 提交于
Basically does the reverse of after_transition to :installed.
-
由 Thong Kuah 提交于
Add endpoint to delete/uninstall a cluster application
-
由 Thong Kuah 提交于
Add specs
-
由 Thong Kuah 提交于
Only prometheus can be uninstalled atm, the rest will be dealt with later. Presumption is that new application types will have uninstallation implmemented at the same time.
-
由 Thong Kuah 提交于
Rescue and put into :uninstall_errored if something goes wrong while destroying, which can happen. I think it is safe to expose the full error message from the destroy error. Remove the :uninstalled state as no longer used.
-
由 Thong Kuah 提交于
+ to monitor progress of uninstallation pod
-
由 Thong Kuah 提交于
Added :uninstalled state as wasn't sure if we should be destroying the cluster apps
-
由 Stan Hu 提交于
We've seen a significant performance penalty when using `BatchLoader#__replace_with!`. This defines methods on the batch loader that proxy to the 'real' object using send. The alternative is `method_missing`, which is slower. However, we've noticed that `method_missing` can be faster if: 1. The objects being loaded have a large interface. 2. We don't call too many methods on the loaded object. Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
-
由 Shinya Maeda 提交于
Source branch can be removed after the merge and we have to make sure to avoid rendering links if it's the case.
-
由 Brandon Labuschagne 提交于
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
由 Brandon Labuschagne 提交于
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. This commit only targets the Vanilla JS files. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
- 29 4月, 2019 12 次提交
-
-
由 Brandon Labuschagne 提交于
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
由 Peter Leitzen 提交于
Stop using `Rails.env.test?` in views.
-
由 Sean McGivern 提交于
`Todos::Destroy::EntityLeaveService#project_ids` was returning ActiveRecord objects with IDs, not simply IDs. That means we were serialising more than we needed to in Sidekiq. We can simply rename this method to `#projects` as this class doesn't use any of the superclass methods that would use `#project_ids`.
-
由 Brandon Labuschagne 提交于
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
由 Stan Hu 提交于
In Rails 5, including `ActionView::Context` can have a significant and hidden performance penalty because this module also includes `ActionView::CompiledTemplates`. This means that any module that includes ActionView::Context becomes a descendant of `CompiledTemplates`. When a partial is rendered for the first time, it runs `ActionView::CompiledTemplates#module_eval`, which will evaluate a string that defines a new method for that partial. For example, the source of partial might be this string: ``` def _app_views_project_show_html_haml___12345(local_assigns, output) "hello world" end ``` When this string is evaluated, the Ruby interpreter will define the method and clear the global method cache for all descendants of `ActionView::CompiledTemplates`. Previous to this change, we inadvertently made a number of modules fall into this category: * GroupChildEntity * NoteUserEntity * Notify * MergeRequestUserEntity * AnalyticsCommitEntity * CommitEntity * UserEntity * Kaminari::Helpers::Paginator * CurrentUserEntity * ActionView::Base * ActionDispatch::DebugExceptions::DebugView * MarkupHelper * MergeRequestPresenter After this change: * Kaminari::Helpers::Paginator * ActionView::Base * ActionDispatch::DebugExceptions::DebugView Each time a partial is rendered for the first time, all methods for those modules will have to be redefined. This can exact a significant performance penalty. How bad is this penalty? Using the following benchmark script, we can use DTrace to sample the Ruby interpreter: ``` Benchmark.bm do |x| x.report do 1000.times do ActionView::CompiledTemplates.module_eval("def testme\nend") end end end ``` This revealed a 11x jump in the time spent in `core#define_method` alone. Rails 6 fixes this behavior by moving the `include CompiledTemplates` into ActionView::Base so that including `ActionView::Context` doesn't quietly affect other modules in this way. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
-
由 Shinya Maeda 提交于
With Pipelines for Merge Requests feature, users cannout keep using $CI_COMMIT_REF_NAME and _SLUG predefined variables for dynamic environments. We fix this problem by explicitly looking at the source ref.
-
由 khm 提交于
This commit contains the patch suggested by @fjsanpedro in the issue covering broken links in wiki search results. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
-
由 Peter Leitzen 提交于
When showing the HTML version of the environment metrics we don't need to fetch their metrics because we don't use them anymore on the HTML version. We use additional_metrics.json endpoint now.
-
-
由 Bob Van Landuyt 提交于
This ports the changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/ to CE
-
由 Heinrich Lee Yu 提交于
-
- 28 4月, 2019 2 次提交
-
-
由 Stan Hu 提交于
-
由 Shinya Maeda 提交于
Currently, PipelineScheduleWorker is fired in a short period on our production server. We can stop this behavior by locking the execution thread with in_lock method.
-
- 27 4月, 2019 5 次提交
-
-
由 Bastian Blank 提交于
The instance specific help text was not rendered in any way compatible with the look and feel of the rest of the page. Just re-use the wiki style like the rest of the page.
-
由 Vladimir Shushlin 提交于
Store Let's Encrypt account email in application settings Also add explicit terms of service consent
-
由 Jason Goodman 提交于
This enables sending a chat message to Slack or Mattermost upon a successful, failed, or canceled deployment
-
由 Sam Bigelow 提交于
All `renderGFM()` calls are finished before the system note is mounted so this MR inits the popover for each system note, and only the elements in the system note
-
由 Reuben Pereira 提交于
This new table will be used to store the external_dashboard_url which allows users to add a link to their external dashboards (ex Grafana) to the Metrics dashboard.
-
- 26 4月, 2019 2 次提交
-
-
由 Filipa Lacerda 提交于
-
由 Enrique Alcantara 提交于
-