- 30 10月, 2015 2 次提交
-
-
由 Yorick Peterse 提交于
-
由 Yorick Peterse 提交于
This query used to rely on a JOIN, effectively producing the following SQL: SELECT users.* FROM users LEFT OUTER JOIN emails ON emails.user_id = users.id WHERE (users.email = X OR emails.email = X) LIMIT 1; The use of a JOIN means having to scan over all Emails and users, join them together and then filter out the rows that don't match the criteria (though this step may be taken into account already when joining). In the new setup this query instead uses a sub-query, producing the following SQL: SELECT * FROM users WHERE id IN (select user_id FROM emails WHERE email = X) OR email = X LIMIT 1; This query has the benefit that it: 1. Doesn't have to JOIN any rows 2. Only has to operate on a relatively small set of rows from the "emails" table. Since most users will only have a handful of Emails associated (certainly not hundreds or even thousands) the size of the set returned by the sub-query is small enough that it should not become problematic. Performance of the old versus new version can be measured using the following benchmark: # Save this in ./bench.rb require 'benchmark/ips' email = 'yorick@gitlab.com' def User.find_by_any_email_old(email) user_table = arel_table email_table = Email.arel_table query = user_table. project(user_table[Arel.star]). join(email_table, Arel::Nodes::OuterJoin). on(user_table[:id].eq(email_table[:user_id])). where(user_table[:email].eq(email).or(email_table[:email].eq(email))) find_by_sql(query.to_sql).first end Benchmark.ips do |bench| bench.report 'original' do User.find_by_any_email_old(email) end bench.report 'optimized' do User.find_by_any_email(email) end bench.compare! end Running this locally using "bundle exec rails r bench.rb" produces the following output: Calculating ------------------------------------- original 1.000 i/100ms optimized 93.000 i/100ms ------------------------------------------------- original 11.103 (± 0.0%) i/s - 56.000 optimized 948.713 (± 5.3%) i/s - 4.743k Comparison: optimized: 948.7 i/s original: 11.1 i/s - 85.45x slower In other words, the new setup is 85x faster compared to the old setup, at least when running this benchmark locally. For GitLab.com these improvements result in User.find_by_any_email taking only ~170 ms to run, instead of around 800 ms. While this is "only" an improvement of about 4.5 times (instead of 85x) it's still significantly better than before. Fixes #3242
-
- 29 10月, 2015 8 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Ben Ford 提交于
Simply type a name with a `/` directory separator and new directories will be created. This does not do the fancy UI work that github.com does, but it will get the job done. I could not find tests for file creation, so I didn't add a test for this slight behaviour modification. I did test directory traversals though, using both absolute paths like `/tmp/foo.txt` and relative paths like `../../foo.txt`. Neither case escaped the repository, though attempting to traverse with a relative path resulted in a 500 error that did not affect application stability upon reload.
-
由 Douwe Maan 提交于
Force update refs/merge-requests/X/head upon a push to the source branch of a merge request If a user rebases and does a force push, GitLab would not update the `refs/merge-requests/X/head` link. Using the -f flag forces this to happen. Closes #3138 See merge request !1683
-
由 Dmitriy Zaporozhets 提交于
Start putting shared files in "shared" See merge request !1691
-
由 Sytse Sijbrandij 提交于
-
由 Sytse Sijbrandij 提交于
-
由 Stan Hu 提交于
Closes #3138
-
- 28 10月, 2015 11 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Add copy paste text for closing down the Github issue tracker @sytses I think we talked about closing down the Issue tracker on Github. A first step can be closing all the older issues and steering people towards the gitlab.com issue tracker. What do you think about this text? See merge request !1689
-
由 Dmitriy Zaporozhets 提交于
Use issue editor as cross reference comment author when issue is edited with a new mention. Fixes #3244. See merge request !1696
-
由 Dmitriy Zaporozhets 提交于
Bump nprogress-rails to 0.1.6.7 Closes #2866 See merge request !1686
-
由 Dmitriy Zaporozhets 提交于
-
由 Dmitriy Zaporozhets 提交于
Remove deprecated CI events from project settings page Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @ayufan Part of #2594 See merge request !1694
-
由 Jeroen van Baarsen 提交于
Signed-off-by: NJeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-
由 Achilleas Pipinellis 提交于
Fixed the permission doc The guest users was missing "Pull project code" and "Download project". /cc @axil See merge request !1695
-
由 Douwe Maan 提交于
-
由 Hannes Rosenögger 提交于
The guest users was missing "Pull project code" and "Download project".
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
由 Dmitriy Zaporozhets 提交于
Bump gitlab-shell to v2.6.6 See merge request !1673
-
- 27 10月, 2015 4 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Bump jquery-atwho-rails to ~> 1.3.2 Closes #2858 See merge request !1687
-
由 Robert Speicher 提交于
Add projects path index Fixes performance regression introduced by !1649 See merge request !1692
-
由 Kamil Trzciński 提交于
Add builds to the docs as a valid skip option for backups. See merge request !1666
-
由 Kamil Trzcinski 提交于
Fixes performance regression introduced by MR1649
-
- 26 10月, 2015 15 次提交
-
-
由 Stan Hu 提交于
Fix: 500 error returned if destroy request without HTTP referer
-
由 Robert Speicher 提交于
[ci skip]
-
由 Robert Speicher 提交于
Fix CI badge The previous code relied on having on ref stored in commit, however the ref was moved to the build. Fixes #3104 See merge request !1690
-
由 Jacob Vosmaer 提交于
-
由 Robert Speicher 提交于
Fix visibility of specific runners See merge request !1688
-
由 Jacob Vosmaer 提交于
-
由 Kamil Trzcinski 提交于
The previous code relied on having on ref stored in commit, however the ref was moved to the build.
-
由 Robert Speicher 提交于
Add migration to remove the contents of the satellites dir See merge request !1681
-
由 Kamil Trzcinski 提交于
-
由 Robert Speicher 提交于
Closes #2858
-
由 Robert Speicher 提交于
Closes #2866
-
由 kazubu 提交于
-
由 kazubu 提交于
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
Fix some grammatical issues
-