- 04 11月, 2016 26 次提交
-
-
由 Bryce Johnson 提交于
-
由 Alfredo Sumaran 提交于
eslint: Fix invalid filename validation Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced. ``` /builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6 2:1 error Filename 'gl_field_error.js.es6' does not match the naming convention filenames/match-regex ``` This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$` This new regex allows the following filenames to pass as valid: - `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js` - `gl_foo_bar.js` which base name translates to `gl_foo_bar` - `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific) See merge request !7281
-
由 Alfredo Sumaran 提交于
-
由 Alfredo Sumaran 提交于
-
由 Fatih Acet 提交于
Add new icon for skipped builds; show created state in mini graph ![Screen_Shot_2016-11-03_at_1.31.02_PM](/uploads/69be86d59f5939329cd869804e86cb87/Screen_Shot_2016-11-03_at_1.31.02_PM.png) ![Screen_Shot_2016-11-03_at_1.30.46_PM](/uploads/0d568ad94e3f072beb0728b402aa695a/Screen_Shot_2016-11-03_at_1.30.46_PM.png) Closes #22914 See merge request !7276
-
由 Fatih Acet 提交于
Hides registry if project repository is disabled ## What does this MR do? When disabling the projects repository it now hides the container registry as well. ## Screenshots (if relevant) ![Screen_Shot_2016-10-21_at_11.23.29](/uploads/e07d74e0666348748690689ab993f9d8/Screen_Shot_2016-10-21_at_11.23.29.png) ![Screen_Shot_2016-10-21_at_11.23.32](/uploads/e2f0757397a4524eca5aa069c1fabad3/Screen_Shot_2016-10-21_at_11.23.32.png) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/19734#note_17224181 See merge request !7036
-
由 Fatih Acet 提交于
Unify dropdown button styles Unifies dropdown styles across app (use one shade of gray for border, always use caret instead of chevron) Before: ![Screen_Shot_2016-11-02_at_1.39.20_PM](/uploads/f0a2808c97aaa404626631683da32380/Screen_Shot_2016-11-02_at_1.39.20_PM.png) After: ![Screen_Shot_2016-11-02_at_1.39.45_PM](/uploads/cca0d40138d48f11cfc7183b202abad9/Screen_Shot_2016-11-02_at_1.39.45_PM.png) Should affect _all_ dropdowns ![Screen_Shot_2016-11-02_at_1.35.12_PM](/uploads/73874a46d79144a7a854eab57030c2bc/Screen_Shot_2016-11-02_at_1.35.12_PM.png) See merge request !7250
-
由 Alfredo Sumaran 提交于
This allows us to pass .js.es6 files as valid filenames;
-
由 Alfredo Sumaran 提交于
-
由 Fatih Acet 提交于
Add custom text to column Before: ![Screen_Shot_2016-11-03_at_9.46.27_AM](/uploads/ba26761b1e1a5af30b19aac88c0060a1/Screen_Shot_2016-11-03_at_9.46.27_AM.png) After: ![Screen_Shot_2016-11-03_at_9.46.20_AM](/uploads/a959a30a3e11ab64bb1412e662692f2b/Screen_Shot_2016-11-03_at_9.46.20_AM.png) Closes #24133 See merge request !7269
-
由 Alfredo Sumaran 提交于
Remove underline focus state on statuses Before: ![Screen_Shot_2016-11-02_at_9.21.03_AM](/uploads/60d49c0cde418b45ee245d1a60d6ece7/Screen_Shot_2016-11-02_at_9.21.03_AM.png) After: ![Screen_Shot_2016-11-02_at_9.20.43_AM](/uploads/820c91d961b01d775465671ebceeba98/Screen_Shot_2016-11-02_at_9.20.43_AM.png) See merge request !7244
-
由 Robert Speicher 提交于
DRY up the bin/changelog specs Depends on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7252 See merge request !7253
-
由 Sean McGivern 提交于
Fixes #24102 See merge request !7267
-
由 Annabel Dunstone Gray 提交于
-
由 Rémy Coutable 提交于
Add and update .gitignore & .gitlab-ci.yml templates for 8.14 Following https://gitlab.com/gitlab-org/gitlab-ce/issues/24134 See merge request !7272
-
由 Annabel Dunstone Gray 提交于
-
由 Robert Speicher 提交于
[ci skip]
-
由 Alfredo Sumaran 提交于
Adds JavaScript validation for group path editing ## What does this MR do? - Prevents group_edit form submission when special characters are included in the new group name - Enhances gl_field_errors to support this use case and be more re-usable. ## Are there points in the code the reviewer needs to double check? **The implementation of validation is here: https://gitlab.com/gitlab-org/gitlab-ce/commit/73d997046cac376ccdbcaac6f183002bc19b9a1f** The rest of the diff for this MR is augmenting gl_field_errors ## Why was this MR needed? - Currently we allow submission and a 500 error is returned. ## Screenshots (if relevant) ![2016-10-21_14.11.21](/uploads/2bef5764d3f2429dd0f900661153eef7/2016-10-21_14.11.21.gif) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922 See merge request !7041
-
由 Robert Speicher 提交于
-
由 Annabel Dunstone Gray 提交于
-
由 Annabel Dunstone Gray 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Annabel Dunstone Gray 提交于
-
由 Rémy Coutable 提交于
Don't include Gitlab::Routing.url_helpers on top-level namespace (fix error for url_for) ## What does this MR do? Tries to fix: ``` ActionView::Template::Error: arguments passed to url_for can't be handled. Please require routes or provide your own implementation ``` One of the failed build: https://gitlab.com/gitlab-org/gitlab-ce/builds/5825797 See merge request !7265
-
由 Rémy Coutable 提交于
Expose more info for SystemHooks See merge request !6964
-
由 Alejandro Rodríguez 提交于
-
- 03 11月, 2016 14 次提交
-
-
由 Rémy Coutable 提交于
Update "Installation from source" guide for 8.14.0 Following the steps from https://gitlab.com/gitlab-org/release-tools/blob/master/doc/release-candidates.md#creating-rc1. See merge request !7271
-
由 Alejandro Rodríguez 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Douwe Maan 提交于
Fix symlink vulnerability in Import/Export Replaces https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2018 made by @james Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23822 See merge request !2022 Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Douwe Maan 提交于
Fix Import/Export foreign key issue to do with project members Cleans-up any foreign keys in `ProjectMember` - same as we do with the rest of the models when importing. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23837 and https://gitlab.com/gitlab-org/gitlab-ce/issues/23739 See merge request !2020 Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Lin Jen-Shin 提交于
-
由 Robert Speicher 提交于
[ci skip]
-
由 Lin Jen-Shin 提交于
-
由 Robert Speicher 提交于
[ci skip]
-
由 Rémy Coutable 提交于
Add a `--force` option to bin/changelog See merge request !7252
-
由 Robert Speicher 提交于
-
由 Fatih Acet 提交于
Check that JavaScript file names match convention ## What does this MR do? Introduce a new ESLint rule to check JavaScript file names. ## What are the relevant issue numbers? fixes #23118 See merge request !7238
-
由 Fatih Acet 提交于
Updated Sortable JS plugin ## What does this MR do? Updates Sortable JS plugin for issue boards. The older version stopped the issue cards being draggable. ## What are the relevant issue numbers? Closes #23048 See merge request !6734
-
由 Rémy Coutable 提交于
Removes spaces in log messages. refs: - 6f7ccea6 - 7121a58e - f54bf003 none of them seem to have added extra space deliberately (commit message is about something else) ## Why was this MR needed? The spaces caused confusion when trying to analyze the logs, there was no space in user name, but log message indicated there was. See merge request !7223
-