- 23 7月, 2015 1 次提交
-
-
由 Douwe Maan 提交于
-
- 22 7月, 2015 22 次提交
-
-
由 Douwe Maan 提交于
-
由 Valery Sizov 提交于
revert caching of note text This MR reverts the caching of note texts because what is rendered as a link in Markdown depends on the user's access to other projects and groups. Until we find a solution that doesn't decrease security, let's not use the cache for this. See discussion in gitlab-org/gitlab-ce!911 for more information. /cc @DouweM @stanhu @vsizov See merge request !1014
-
由 Douwe Maan 提交于
Speed up security feature specs Before: `rspec spec/features/security/ 0.12s user 0.04s system 0% cpu 3:38.00 total` After: `rspec spec/features/security/ 0.12s user 0.04s system 0% cpu 1:40.58 total` The majority of the speed improvements is from two things: 1. Instead of using our standard `login_as` helper in the matchers, we take advantage of the `Warden::Test::Helpers` version of the method which bypasses the login form and logs the user in directly. We were essentially testing that filling out the login form works hundreds of times. 2. There were many tests that verified if a user of a certain access level (master, owner, reporter, guest) had access to a resource. Unfortunately we were creating every type of user for each test even though a test was only verifying one of them at a time. Now the tests only create the one user role they're testing. See merge request !1023
-
由 Marin Jankovski 提交于
-
由 Job van der Voort 提交于
Added Fork Project document to GitLab Basics See merge request !1909
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
The user being created was no different than what `be_allowed_for` was doing behind the scenes so we were essentially testing all user-level accesses twice.
-
由 Robert Speicher 提交于
It was only used in one test, and the test was kind of redundant.
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
-
由 Stan Hu 提交于
the repository expire_cache method
-
由 Stan Hu 提交于
Remove 7.14 entry that was pushed to 7.13 See merge request !1020
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
Fix 404 error in files view after deleting the last file in a repository Here's the logic: 1. In `TreeController`, `require_non_empty_project` will prevent `show` from being called if the project is empty. That means all calls to `show` will be guaranteed to have at least 1 commit. 2. If the ref name is not valid, then return a 404. This ensures that at least the controller is looking at a valid branch/tag/SHA ID. 3. This leaves a number of cases: ``` 3a. Valid ref, valid directory 3b. Valid ref, valid filename 3c. Valid ref, invalid path 3d. Valid ref, no files ``` Case 3a: The tree will not be `empty?` and will pass through the whole function. Case 3b: The tree will be `empty?` but the `blob_at` will resolve properly and trigger a redirect to the file. Case 3c: In this case, a path is given. Return 404 if it cannot be resolved neither as a tree nor a blob. Case 3d: In this case, no path is given. If the tree is empty, this means it's an empty branch and just fall through. Example broken branch: https://gitlab.com/gitlab-org/gitlab-test/tree/empty-branch Closes #1362 See merge request !1010
-
由 karen Carias 提交于
-
由 karen Carias 提交于
-
由 Hannes Rosenögger 提交于
Fix full screen mode for snippet comments ZenMode is now initialized for snippet pages. Fixes #2036. See merge request !1016
-
由 Stan Hu 提交于
Closes #1362
-
由 Daniel Gerhardt 提交于
ZenMode is now initialized for snippet pages. Fixes #2036.
-
- 21 7月, 2015 12 次提交
-
-
由 Valery Sizov 提交于
You need to store your DB encryption key You can break two-factor authentication for existing users when restoring a backup if you lost your DB encryption key. See merge request !1015
-
由 Jacob Vosmaer 提交于
-
由 Hannes Rosenögger 提交于
-
由 Valery Sizov 提交于
Update changelog See merge request !1013
-
由 Valery Sizov 提交于
-
由 Valery Sizov 提交于
Don't stop if database.sql.gz already exists The existing behavior of the backups is to overwrite whatever data was still there in the scratch directories. This broke when we added a 'gzip' step because 'gzip database.sql' will fail if 'database.sql.gz' already exists. Doing 'rm -f database.sql.gz' before the 'gzip' avoids this failure. See merge request !1011
-
由 Jacob Vosmaer 提交于
The existing behavior of the backups is to overwrite whatever data was still there in the scratch directories. This broke when we added a 'gzip' step because 'gzip database.sql' will fail if 'database.sql.gz' already exists. Doing 'rm -f database.sql.gz' before the 'gzip' avoids this failure.
-
由 Robert Schilling 提交于
Fix change log for 7.11 and move entry to 7.12 The change log for 7.11 was accidentally split in 3865a1d9. Additionally, the change added with this commit did not make it into 7.11 according to `git branch --contains` and it has not been cherry picked to 7-11-stable so the entry is moved to 7.12. Refs GH-5625, GH-9318. See merge request !1009
-
由 Daniel Gerhardt 提交于
The change log for 7.11 was accidentally split in 3865a1d9. Additionally, the change added with this commit did not make it into 7.11 according to `git branch --contains` and it has not been cherry picked to 7-11-stable so the entry is moved to 7.12. Refs GH-5625, GH-9318. [ci skip]
-
由 Stan Hu 提交于
GoogleCode importer: Do not care about casing of image file extensions When a GoogleCode repository contains an attached image with an UPPERCASE file extension, it's not inlined. /CC @DouweM See merge request !1003
-
由 Stan Hu 提交于
Fix (i.e. prevent) access to disabled features for unauthenticated users Unauthenticated users had access to disabled features of public projects. The code has been slightly refactored so that feature checks are done in a separate method and can also be applied for public access. See merge request !1006
-
由 Stan Hu 提交于
merge_requests: add fetch command to the MR page In our instance, users asked for an easy way to get the contents of the MR into their local clone. This adds a command line which can be used to fetch the contents of the MR. Screenshot: ![fetch-command](https://gitlab.com/gitlab-org/gitlab-ce/uploads/d83acfbdb69f023d13b45dff5d583ac1/fetch-command.png) See merge request !678
-
- 20 7月, 2015 5 次提交
-
-
由 Ben Boeckel 提交于
-
由 Valery Sizov 提交于
Remove repository graph log to fix slow cache updates after push event Recalculating `graph_log` took minutes on a large repository since each of the 6000 commits would need to calculate the diff. Since graph_log does not appear to be used, remove it from the list of things to update. For the Linux kernel repository, this reduced the `ProjectCacheWorker` time from 8+ minutes to 16 seconds. Closes #2016 See merge request !1005
-
由 Valery Sizov 提交于
Remove redundant last push event if activity feed is set to main page ### What does this MR do? This MR eliminates a redundant last push event message if the user's preferences are set to the main activity feed. ### Why was this MR needed? Lots of wasted space was introduced as a result. ### Screenshots #### Before ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/e7fdeb58b2017ec45443bf0d54a94685/image.png) #### After ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/d4a15113127be119e7c33ff501020f16/image.png) ### What are the relevant issue numbers? Closes #2009 See merge request !995
-
由 Valery Sizov 提交于
Public project activity page asks for sign-in https://gitlab.com/gitlab-org/gitlab-ce/issues/2021 See merge request !1007
-
由 Marin Jankovski 提交于
-