- 04 1月, 2018 3 次提交
-
-
- 09 12月, 2017 1 次提交
-
-
由 Mayra Cabrera 提交于
-
- 05 12月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
On the `show` of a project that is part of a fork network. We check if the user already created a fork of this project in their personal namespace. We do this in several places, so caching the result of this query in the request store prevents us from repeating it.
-
- 27 11月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 25 11月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 06 11月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 10 10月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
-
- 07 10月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
-
- 15 9月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
Prior to this commit running Namespace#force_share_with_group_lock_on_descendants would result in updating _all_ namespaces in the namespaces table, not just the descendants. This is the result of ActiveRecord::Relation#update_all not taking into account the CTE. To work around this we use the CTE query as a sub-query instead of directly calling #update_all. To prevent this from happening the relations returned by Gitlab::GroupHierarchy are now marked as read-only, resulting in an error being raised when methods such as #update_all are used. Fortunately on GitLab.com our statement timeouts appear to have prevented this query from actually doing any damage other than causing a very large amount of dead tuples. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
-
- 07 9月, 2017 2 次提交
-
-
由 Michael Kozono 提交于
-
由 Michael Kozono 提交于
…when needed
-
- 31 8月, 2017 1 次提交
-
-
由 Zeger-Jan van de Weg 提交于
In this instance its subgroups, and given we can't deploy it, we shouldn't allow it to be shown. Fixes gitlab-org/gitlab-ce#34864
-
- 14 8月, 2017 1 次提交
-
-
由 Nick Thomas 提交于
-
- 01 8月, 2017 2 次提交
-
-
由 Gabriel Mazetto 提交于
-
由 Gabriel Mazetto 提交于
-
- 17 7月, 2017 1 次提交
-
-
由 Nick Thomas 提交于
In EE, we make use of `namespace#public?` in projects. When the project is in a personal namespace, this breaks as the `public?` helper isn't present.
-
- 06 7月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
-
- 30 6月, 2017 1 次提交
-
-
由 Stan Hu 提交于
Group#destroy would actually hard-delete all associated projects even though the acts_as_paranoia gem is used, preventing Projects::DestroyService from doing any work. We first noticed this while trying to log all projects deletion to the Geo log.
-
- 29 6月, 2017 2 次提交
-
-
由 Tiago Botelho 提交于
-
由 Tiago Botelho 提交于
-
- 21 6月, 2017 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 03 6月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 18 5月, 2017 2 次提交
-
-
由 Douwe Maan 提交于
-
由 Yorick Peterse 提交于
This hides/disables some UI elements and API parameters related to nested groups when MySQL is used, since nested groups are not supported for MySQL.
-
- 17 5月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 12 5月, 2017 2 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 11 5月, 2017 1 次提交
-
-
由 Rémy Coutable 提交于
Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 01 5月, 2017 2 次提交
-
-
由 Bob Van Landuyt 提交于
This reflects better that it validates paths instead of a namespace model
-
由 Bob Van Landuyt 提交于
-
- 05 4月, 2017 1 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 03 4月, 2017 2 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
- 30 3月, 2017 1 次提交
-
-
由 Rémy Coutable 提交于
Use full path for moving directories when changing namespace path See merge request !2078
-
- 23 3月, 2017 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 22 3月, 2017 1 次提交
-
-
由 Jarka Kadlecova 提交于
-
- 24 2月, 2017 2 次提交
-
-
由 Timothy Andrew 提交于
- Have `Uniquify` take a block instead of a Proc/function. This is more idiomatic than passing around a function in Ruby. - Block a user before moving their issues to the ghost user. This avoids a data race where an issue is created after the issues are migrated to the ghost user, and before the destroy takes place. - No need to migrate issues (to the ghost user) in a transaction, because we're using `update_all` - Other minor changes
-
由 Timothy Andrew 提交于
1. Create a `Uniquify` class, which generalizes the process of generating unique strings, by accepting a function that defines what "uniqueness" means in a given context. 2. WIP: Make sure tests for `Namespace` pass, add more if necessary. 3. WIP: Add tests for `Uniquify`
-