Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
fed15484
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fed15484
编写于
3月 23, 2020
作者:
G
GitLab Bot
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add latest changes from gitlab-org/gitlab@12-9-stable-ee
上级
3f242b6b
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
22 addition
and
13 deletion
+22
-13
app/workers/authorized_keys_worker.rb
app/workers/authorized_keys_worker.rb
+6
-4
app/workers/gitlab_shell_worker.rb
app/workers/gitlab_shell_worker.rb
+1
-1
changelogs/unreleased/212178-fix-authorized-keys-worker.yml
changelogs/unreleased/212178-fix-authorized-keys-worker.yml
+5
-0
spec/workers/authorized_keys_worker_spec.rb
spec/workers/authorized_keys_worker_spec.rb
+7
-5
spec/workers/gitlab_shell_worker_spec.rb
spec/workers/gitlab_shell_worker_spec.rb
+3
-3
未找到文件。
app/workers/authorized_keys_worker.rb
浏览文件 @
fed15484
...
...
@@ -3,7 +3,7 @@
class
AuthorizedKeysWorker
include
ApplicationWorker
PERMITTED_ACTIONS
=
[
:add_key
,
:
remove_key
].
freeze
PERMITTED_ACTIONS
=
%w[add_key
remove_key]
.
freeze
feature_category
:source_code_management
urgency
:high
...
...
@@ -13,11 +13,13 @@ class AuthorizedKeysWorker
def
perform
(
action
,
*
args
)
return
unless
Gitlab
::
CurrentSettings
.
authorized_keys_enabled?
case
action
when
:add_key
case
action
.
to_s
when
'add_key'
authorized_keys
.
add_key
(
*
args
)
when
:remove_key
when
'remove_key'
authorized_keys
.
remove_key
(
*
args
)
else
raise
"Unknown action:
#{
action
.
inspect
}
"
end
end
...
...
app/workers/gitlab_shell_worker.rb
浏览文件 @
fed15484
...
...
@@ -13,7 +13,7 @@ class GitlabShellWorker # rubocop:disable Scalability/IdempotentWorker
# enqueued in the previous release, so handle them here.
#
# See https://gitlab.com/gitlab-org/gitlab/-/issues/25095 for more details
if
AuthorizedKeysWorker
::
PERMITTED_ACTIONS
.
include?
(
action
)
if
AuthorizedKeysWorker
::
PERMITTED_ACTIONS
.
include?
(
action
.
to_s
)
AuthorizedKeysWorker
.
new
.
perform
(
action
,
*
arg
)
return
...
...
changelogs/unreleased/212178-fix-authorized-keys-worker.yml
0 → 100644
浏览文件 @
fed15484
---
title
:
Fix updating the authorized_keys file
merge_request
:
27798
author
:
type
:
fixed
spec/workers/authorized_keys_worker_spec.rb
浏览文件 @
fed15484
...
...
@@ -17,7 +17,7 @@ describe AuthorizedKeysWorker do
expect
(
instance
).
to
receive
(
:add_key
).
with
(
'foo'
,
'bar'
)
end
worker
.
perform
(
:add_key
,
'foo'
,
'bar'
)
worker
.
perform
(
'add_key'
,
'foo'
,
'bar'
)
end
end
...
...
@@ -27,15 +27,17 @@ describe AuthorizedKeysWorker do
expect
(
instance
).
to
receive
(
:remove_key
).
with
(
'foo'
,
'bar'
)
end
worker
.
perform
(
:remove_key
,
'foo'
,
'bar'
)
worker
.
perform
(
'remove_key'
,
'foo'
,
'bar'
)
end
end
describe
'all other commands'
do
it
'
does nothing
'
do
it
'
raises an error
'
do
expect
(
Gitlab
::
AuthorizedKeys
).
not_to
receive
(
:new
)
worker
.
perform
(
:foo
,
'bar'
,
'baz'
)
expect
do
worker
.
perform
(
'foo'
,
'bar'
,
'baz'
)
end
.
to
raise_error
(
'Unknown action: "foo"'
)
end
end
end
...
...
@@ -48,7 +50,7 @@ describe AuthorizedKeysWorker do
it
'does nothing'
do
expect
(
Gitlab
::
AuthorizedKeys
).
not_to
receive
(
:new
)
worker
.
perform
(
:add_key
,
'foo'
,
'bar'
)
worker
.
perform
(
'add_key'
,
'foo'
,
'bar'
)
end
end
end
...
...
spec/workers/gitlab_shell_worker_spec.rb
浏览文件 @
fed15484
...
...
@@ -12,7 +12,7 @@ describe GitlabShellWorker do
expect
(
instance
).
to
receive
(
:add_key
).
with
(
'foo'
,
'bar'
)
end
worker
.
perform
(
:add_key
,
'foo'
,
'bar'
)
worker
.
perform
(
'add_key'
,
'foo'
,
'bar'
)
end
end
...
...
@@ -22,7 +22,7 @@ describe GitlabShellWorker do
expect
(
instance
).
to
receive
(
:remove_key
).
with
(
'foo'
,
'bar'
)
end
worker
.
perform
(
:remove_key
,
'foo'
,
'bar'
)
worker
.
perform
(
'remove_key'
,
'foo'
,
'bar'
)
end
end
...
...
@@ -32,7 +32,7 @@ describe GitlabShellWorker do
expect
(
instance
).
to
receive
(
:foo
).
with
(
'bar'
,
'baz'
)
end
worker
.
perform
(
:foo
,
'bar'
,
'baz'
)
worker
.
perform
(
'foo'
,
'bar'
,
'baz'
)
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录