Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
fd54d7a2
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fd54d7a2
编写于
1月 12, 2018
作者:
L
Lin Jen-Shin
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add some more docs to doc/development/utilities.md
上级
cfd75101
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
49 addition
and
1 deletion
+49
-1
doc/development/ee_features.md
doc/development/ee_features.md
+4
-1
doc/development/utilities.md
doc/development/utilities.md
+45
-0
未找到文件。
doc/development/ee_features.md
浏览文件 @
fd54d7a2
...
...
@@ -87,7 +87,7 @@ still having access the class's implementation with `super`.
There are a few gotchas with it:
-
you should always
`extend ::Gitlab::Utils::Override`
and use
`override`
to
-
you should always
[
`extend ::Gitlab::Utils::Override`
]
and use
`override`
to
guard the "overrider" method to ensure that if the method gets renamed in
CE, the EE override won't be silently forgotten.
-
when the "overrider" would add a line in the middle of the CE
...
...
@@ -192,6 +192,8 @@ module EE
end
```
[
`extend ::Gitlab::Utils::Override`
]:
utilities.md#override
#### Use self-descriptive wrapper methods
When it's not possible/logical to modify the implementation of a
...
...
@@ -212,6 +214,7 @@ end
In EE, the implementation
`ee/app/models/ee/users.rb`
would be:
```
ruby
override
:full_private_access?
def
full_private_access?
super
||
auditor?
end
...
...
doc/development/utilities.md
浏览文件 @
fd54d7a2
...
...
@@ -45,6 +45,51 @@ We developed a number of utilities to ease development.
[:hello, "world", :this, :crushes, "an entire", "hash"]
```
## [`Override`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/utils/override.rb)
*
This utility could help us check if a particular method would override
another method or not. It has the same idea of Java's
`@Override`
annotation
or Scala's
`override`
keyword. However we only do this check when
`ENV['STATIC_VERIFICATION']`
is set to avoid production runtime overhead.
This is useful to check:
* If we have typos in overriding methods.
* If we renamed the overridden methods, making original overriding methods
overrides nothing.
Here's a simple example:
``` ruby
class Base
def execute
end
end
class Derived < Base
extend ::Gitlab::Utils::Override
override :execute # Override check happens here
def execute
end
end
```
This also works on modules:
``` ruby
module Extension
extend ::Gitlab::Utils::Override
override :execute # Modules do not check this immediately
def execute
end
end
class Derived < Base
prepend Extension # Override check happens here, not in the module
end
```
## [`StrongMemoize`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/utils/strong_memoize.rb)
*
Memoize the value even if it is
`nil`
or
`false`
.
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录