Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
f849ef79
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
f849ef79
编写于
9月 05, 2016
作者:
P
Phil Hughes
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixed issue board label filtering not removing labels
Closes #21417
上级
1e042ac2
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
23 addition
and
3 deletion
+23
-3
CHANGELOG
CHANGELOG
+1
-0
app/assets/javascripts/labels_select.js
app/assets/javascripts/labels_select.js
+3
-3
spec/features/boards/boards_spec.rb
spec/features/boards/boards_spec.rb
+19
-0
未找到文件。
CHANGELOG
浏览文件 @
f849ef79
...
...
@@ -37,6 +37,7 @@ v 8.12.0 (unreleased)
- Use 'git update-ref' for safer web commits !6130
- Automatically expand hidden discussions when accessed by a permalink !5585 (Mike Greiling)
- Remove unused mixins (ClemMakesApps)
- Fix issue board label filtering appending already filtered labels
- Add search to all issue board lists
- Fix groups sort dropdown alignment (ClemMakesApps)
- Add horizontal scrolling to all sub-navs on mobile viewports (ClemMakesApps)
...
...
app/assets/javascripts/labels_select.js
浏览文件 @
f849ef79
...
...
@@ -273,12 +273,12 @@
if
(
page
===
'
projects:boards:show
'
)
{
if
(
label
.
isAny
)
{
gl
.
issueBoards
.
BoardsStore
.
state
.
filters
[
'
label_name
'
]
=
[];
}
else
if
(
label
.
title
)
{
}
else
if
(
$el
.
hasClass
(
'
is-active
'
)
)
{
gl
.
issueBoards
.
BoardsStore
.
state
.
filters
[
'
label_name
'
].
push
(
label
.
title
);
}
else
{
var
filters
=
gl
.
issueBoards
.
BoardsStore
.
state
.
filters
[
'
label_name
'
];
filters
=
filters
.
filter
(
function
(
l
abel
)
{
return
label
!==
$el
.
text
().
trim
()
;
filters
=
filters
.
filter
(
function
(
filteredL
abel
)
{
return
filteredLabel
!==
label
.
title
;
});
gl
.
issueBoards
.
BoardsStore
.
state
.
filters
[
'
label_name
'
]
=
filters
;
}
...
...
spec/features/boards/boards_spec.rb
浏览文件 @
f849ef79
...
...
@@ -467,6 +467,25 @@ describe 'Issue Boards', feature: true, js: true do
end
end
it
'removes filtered labels'
do
page
.
within
'.labels-filter'
do
click_button
(
'Label'
)
wait_for_ajax
page
.
within
'.dropdown-menu-labels'
do
click_link
(
testing
.
title
)
end
expect
(
page
).
to
have_css
(
'input[name="label_name[]"]'
,
visible:
false
)
page
.
within
'.dropdown-menu-labels'
do
click_link
(
testing
.
title
)
end
expect
(
page
).
not_to
have_css
(
'input[name="label_name[]"]'
,
visible:
false
)
end
end
it
'infinite scrolls list with label filter'
do
50
.
times
do
create
(
:labeled_issue
,
project:
project
,
labels:
[
testing
])
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录