Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
ef78f67f
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ef78f67f
编写于
12月 09, 2017
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add a spec for rate limiting pipeline schedules
上级
54f13b1e
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
12 addition
and
2 deletion
+12
-2
app/controllers/projects/pipeline_schedules_controller.rb
app/controllers/projects/pipeline_schedules_controller.rb
+2
-2
spec/controllers/projects/pipeline_schedules_controller_spec.rb
...ontrollers/projects/pipeline_schedules_controller_spec.rb
+10
-0
未找到文件。
app/controllers/projects/pipeline_schedules_controller.rb
浏览文件 @
ef78f67f
...
...
@@ -45,7 +45,7 @@ class Projects::PipelineSchedulesController < Projects::ApplicationController
limiter
=
::
Gitlab
::
ActionRateLimiter
.
new
(
action:
'play_pipeline_schedule'
)
if
limiter
.
throttled?
(
throttle_key
,
1
)
flash
[
:
notice
]
=
'You cannot play this scheduled pipeline at the moment. Please wait a minute.'
flash
[
:
alert
]
=
'You cannot play this scheduled pipeline at the moment. Please wait a minute.'
return
redirect_to
pipeline_schedules_path
(
@project
)
end
...
...
@@ -53,7 +53,7 @@ class Projects::PipelineSchedulesController < Projects::ApplicationController
flash
[
:notice
]
=
if
job_id
"Successfully scheduled a pipeline to run. Go to the <a href=
\"
#{
project_pipelines_path
(
@project
)
}
\"
>Pipelines page</a> for details"
.
html_safe
"Successfully scheduled a pipeline to run. Go to the <a href=
\"
#{
project_pipelines_path
(
@project
)
}
\"
>Pipelines page</a> for details
.
"
.
html_safe
else
'Unable to schedule a pipeline to run immediately'
end
...
...
spec/controllers/projects/pipeline_schedules_controller_spec.rb
浏览文件 @
ef78f67f
...
...
@@ -385,6 +385,16 @@ describe Projects::PipelineSchedulesController do
expect
(
flash
[
:notice
]).
to
start_with
'Successfully scheduled a pipeline to run'
expect
(
response
).
to
have_gitlab_http_status
(
302
)
end
it
'prevents users from scheduling the same pipeline repeatedly'
do
2
.
times
do
post
:play
,
namespace_id:
project
.
namespace
.
to_param
,
project_id:
project
,
id:
pipeline_schedule
.
id
end
expect
(
flash
.
to_a
.
size
).
to
eq
(
2
)
expect
(
flash
[
:alert
]).
to
eq
'You cannot play this scheduled pipeline at the moment. Please wait a minute.'
expect
(
response
).
to
have_gitlab_http_status
(
302
)
end
end
context
'when a developer attempts to schedule a protected ref'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录