Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
ee92dd16
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
ee92dd16
编写于
4月 26, 2015
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Unescape branch names in compare commit
Closes #1399 Closes
https://github.com/gitlabhq/gitlabhq/issues/9105
上级
39a55bdf
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
28 addition
and
2 deletion
+28
-2
CHANGELOG
CHANGELOG
+2
-0
app/controllers/projects/compare_controller.rb
app/controllers/projects/compare_controller.rb
+4
-2
spec/controllers/projects/compare_controller_spec.rb
spec/controllers/projects/compare_controller_spec.rb
+22
-0
未找到文件。
CHANGELOG
浏览文件 @
ee92dd16
...
...
@@ -21,6 +21,8 @@ v 7.11.0 (unreleased)
- Add default project and snippet visibility settings to the admin web UI.
-
- Fix bug where commit data would not appear in some subdirectories (Stan Hu)
- Unescape branch names in compare commit (Stan Hu)
-
- Fix bug where Slack service channel was not saved in admin template settings. (Stan Hu)
- Move snippets UI to fluid layout
- Improve UI for sidebar. Increase separation between navigation and content
...
...
app/controllers/projects/compare_controller.rb
浏览文件 @
ee92dd16
require
'addressable/uri'
class
Projects::CompareController
<
Projects
::
ApplicationController
# Authorize
before_action
:require_non_empty_project
...
...
@@ -7,8 +9,8 @@ class Projects::CompareController < Projects::ApplicationController
end
def
show
base_ref
=
params
[
:from
]
head_ref
=
params
[
:to
]
base_ref
=
Addressable
::
URI
.
unescape
(
params
[
:from
])
head_ref
=
Addressable
::
URI
.
unescape
(
params
[
:to
])
compare_result
=
CompareService
.
new
.
execute
(
current_user
,
...
...
spec/controllers/projects/compare_controller_spec.rb
0 → 100644
浏览文件 @
ee92dd16
require
'spec_helper'
describe
Projects
::
CompareController
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:ref_from
)
{
"improve%2Fawesome"
}
let
(
:ref_to
)
{
"feature"
}
before
do
sign_in
(
user
)
project
.
team
<<
[
user
,
:master
]
end
it
'compare should show some diffs'
do
get
(
:show
,
namespace_id:
project
.
namespace
.
to_param
,
project_id:
project
.
to_param
,
from:
ref_from
,
to:
ref_to
)
expect
(
response
).
to
be_success
expect
(
assigns
(
:diffs
).
length
).
to
be
>=
1
expect
(
assigns
(
:commits
).
length
).
to
be
>=
1
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录