Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
e79b867d
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
e79b867d
编写于
4月 05, 2016
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Ensure empty recipients are rejected in BuildsEmailService
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
1749bd3b
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
30 addition
and
6 deletion
+30
-6
CHANGELOG
CHANGELOG
+1
-0
app/models/project_services/builds_email_service.rb
app/models/project_services/builds_email_service.rb
+7
-4
spec/models/project_services/builds_email_service_spec.rb
spec/models/project_services/builds_email_service_spec.rb
+22
-2
未找到文件。
CHANGELOG
浏览文件 @
e79b867d
...
...
@@ -14,6 +14,7 @@ v 8.7.0 (unreleased)
- Add links to CI setup documentation from project settings and builds pages
- Handle nil descriptions in Slack issue messages (Stan Hu)
- Add default scope to projects to exclude projects pending deletion
- Ensure empty recipients are rejected in BuildsEmailService
- Implement 'Groups View' as an option for dashboard preferences !3379 (Elias W.)
- Implement 'TODOs View' as an option for dashboard preferences !3379 (Elias W.)
- Gracefully handle notes on deleted commits in merge requests (Stan Hu)
...
...
app/models/project_services/builds_email_service.rb
浏览文件 @
e79b867d
...
...
@@ -50,12 +50,15 @@ class BuildsEmailService < Service
def
execute
(
push_data
)
return
unless
supported_events
.
include?
(
push_data
[
:object_kind
])
return
unless
should_build_be_notified?
(
push_data
)
if
should_build_be_notified?
(
push_data
)
recipients
=
all_recipients
(
push_data
)
if
recipients
.
any?
BuildEmailWorker
.
perform_async
(
push_data
[
:build_id
],
all_recipients
(
push_data
)
,
push_data
,
recipients
,
push_data
)
end
end
...
...
@@ -84,7 +87,7 @@ class BuildsEmailService < Service
end
def
all_recipients
(
data
)
all_recipients
=
recipients
.
split
(
','
)
all_recipients
=
recipients
.
split
(
','
)
.
compact
.
reject
(
&
:blank?
)
if
add_pusher?
&&
data
[
:user
][
:email
]
all_recipients
<<
"
#{
data
[
:user
][
:email
]
}
"
...
...
spec/models/project_services/builds_email_service_spec.rb
浏览文件 @
e79b867d
...
...
@@ -6,18 +6,38 @@ describe BuildsEmailService do
let
(
:service
)
{
BuildsEmailService
.
new
}
describe
:execute
do
it
"sends email"
do
it
'sends email'
do
service
.
recipients
=
'test@gitlab.com'
data
[
:build_status
]
=
'failed'
expect
(
BuildEmailWorker
).
to
receive
(
:perform_async
)
service
.
execute
(
data
)
end
it
"does not sends email with failed build and allowed_failure on"
do
it
'does not send email with succeeded build and notify_only_broken_builds on'
do
expect
(
service
).
to
receive
(
:notify_only_broken_builds
).
and_return
(
true
)
data
[
:build_status
]
=
'success'
expect
(
BuildEmailWorker
).
not_to
receive
(
:perform_async
)
service
.
execute
(
data
)
end
it
'does not send email with failed build and build_allow_failure is true'
do
data
[
:build_status
]
=
'failed'
data
[
:build_allow_failure
]
=
true
expect
(
BuildEmailWorker
).
not_to
receive
(
:perform_async
)
service
.
execute
(
data
)
end
it
'does not send email with unknown build status'
do
data
[
:build_status
]
=
'foo'
expect
(
BuildEmailWorker
).
not_to
receive
(
:perform_async
)
service
.
execute
(
data
)
end
it
'does not send email when recipients list is empty'
do
service
.
recipients
=
' ,, '
data
[
:build_status
]
=
'failed'
expect
(
BuildEmailWorker
).
not_to
receive
(
:perform_async
)
service
.
execute
(
data
)
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录