Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
e0b6838a
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e0b6838a
编写于
4月 16, 2019
作者:
H
Heinrich Lee Yu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Set correct timestamps when creating past issues
Sets `system_note_timestamp` from `created_at`
上级
7994db79
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
16 addition
and
2 deletion
+16
-2
app/models/concerns/noteable.rb
app/models/concerns/noteable.rb
+1
-1
changelogs/unreleased/58361-issue-create-system-note-timestamp.yml
...s/unreleased/58361-issue-create-system-note-timestamp.yml
+5
-0
lib/api/issues.rb
lib/api/issues.rb
+1
-0
spec/requests/api/issues_spec.rb
spec/requests/api/issues_spec.rb
+9
-1
未找到文件。
app/models/concerns/noteable.rb
浏览文件 @
e0b6838a
...
...
@@ -13,7 +13,7 @@ module Noteable
end
end
# The timestamp of the note (e.g. the :updated_at attribute if provided via
# The timestamp of the note (e.g. the :
created_at or :
updated_at attribute if provided via
# API call)
def
system_note_timestamp
@system_note_timestamp
||
Time
.
now
# rubocop:disable Gitlab/ModuleWithInstanceVariables
...
...
changelogs/unreleased/58361-issue-create-system-note-timestamp.yml
0 → 100644
浏览文件 @
e0b6838a
---
title
:
Fix system notes timestamp when creating issue in the past
merge_request
:
27406
author
:
type
:
fixed
lib/api/issues.rb
浏览文件 @
e0b6838a
...
...
@@ -192,6 +192,7 @@ module API
params
.
delete
(
:iid
)
unless
current_user
.
can?
(
:set_issue_iid
,
user_project
)
issue_params
=
declared_params
(
include_missing:
false
)
issue_params
[
:system_note_timestamp
]
=
params
[
:created_at
]
issue_params
=
convert_parameters_from_legacy_format
(
issue_params
)
...
...
spec/requests/api/issues_spec.rb
浏览文件 @
e0b6838a
...
...
@@ -1480,12 +1480,20 @@ describe API::Issues do
let
(
:params
)
{
{
title:
'new issue'
,
labels:
'label, label2'
,
created_at:
creation_time
}
}
context
'by an admin'
do
it
'sets the creation time on the new issue'
do
before
do
post
api
(
"/projects/
#{
project
.
id
}
/issues"
,
admin
),
params:
params
end
it
'sets the creation time on the new issue'
do
expect
(
response
).
to
have_gitlab_http_status
(
201
)
expect
(
Time
.
parse
(
json_response
[
'created_at'
])).
to
be_like_time
(
creation_time
)
end
it
'sets the system notes timestamp based on creation time'
do
issue
=
Issue
.
find
(
json_response
[
'id'
])
expect
(
issue
.
resource_label_events
.
last
.
created_at
).
to
be_like_time
(
creation_time
)
end
end
context
'by a project owner'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录