Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
dce4a92b
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
dce4a92b
编写于
10月 28, 2018
作者:
A
Andreas Brandl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Finish refactoring specs.
The goal is to reflect separation of concern also in specs.
上级
e5e4c6b7
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
15 addition
and
56 deletion
+15
-56
spec/lib/gitlab/database/count_spec.rb
spec/lib/gitlab/database/count_spec.rb
+15
-56
未找到文件。
spec/lib/gitlab/database/count_spec.rb
浏览文件 @
dce4a92b
...
...
@@ -55,60 +55,6 @@ describe Gitlab::Database::Count do
subject
end
end
xcontext
'with PostgreSQL'
,
:postgresql
do
let
(
:reltuples_strategy
)
{
double
(
'reltuples_strategy'
,
count:
{})
}
let
(
:exact_strategy
)
{
double
(
'exact_strategy'
,
count:
{})
}
before
do
allow
(
Gitlab
::
Database
::
Count
::
ReltuplesCountStrategy
).
to
receive
(
:new
).
with
(
models
).
and_return
(
reltuples_strategy
)
end
describe
'when reltuples have not been updated'
do
it
'counts all models the normal way'
do
expect
(
Project
).
to
receive
(
:count
).
and_call_original
expect
(
Identity
).
to
receive
(
:count
).
and_call_original
expect
(
described_class
.
approximate_counts
(
models
)).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
end
end
describe
'no permission'
do
it
'falls back to standard query'
do
allow
(
ActiveRecord
::
Base
).
to
receive
(
:transaction
).
and_raise
(
PG
::
InsufficientPrivilege
)
expect
(
Project
).
to
receive
(
:count
).
and_call_original
expect
(
Identity
).
to
receive
(
:count
).
and_call_original
expect
(
described_class
.
approximate_counts
(
models
)).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
end
end
describe
'when some reltuples have been updated'
do
it
'counts projects in the fast way'
do
expect
(
reltuples_strategy
).
to
receive
(
:count
).
and_return
({
Project
=>
3
})
expect
(
Project
).
not_to
receive
(
:count
).
and_call_original
expect
(
Identity
).
to
receive
(
:count
).
and_call_original
expect
(
described_class
.
approximate_counts
(
models
)).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
end
end
# TODO: This covers two parts: reltuple strategy itself and the fallback
# TODO: Add spec that covers strategy details for reltuple strategy
describe
'when all reltuples have been updated'
do
#before do
#ActiveRecord::Base.connection.execute('ANALYZE projects')
#ActiveRecord::Base.connection.execute('ANALYZE identities')
#end
it
'counts models with the standard way'
do
allow
(
reltuples_strategy
).
to
receive
(
:count
).
and_return
({
Project
=>
3
,
Identity
=>
1
})
expect
(
Project
).
not_to
receive
(
:count
)
expect
(
Identity
).
not_to
receive
(
:count
)
expect
(
described_class
.
approximate_counts
(
models
)).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
end
end
end
end
describe
Gitlab
::
Database
::
Count
::
ExactCountStrategy
do
...
...
@@ -141,10 +87,23 @@ describe Gitlab::Database::Count do
subject
{
described_class
.
new
(
models
).
count
}
describe
'#count'
do
context
'when reltuples is not up to date'
do
it
'returns an empty hash'
do
context
'when reltuples is up to date'
do
before
do
ActiveRecord
::
Base
.
connection
.
execute
(
'ANALYZE projects'
)
ActiveRecord
::
Base
.
connection
.
execute
(
'ANALYZE identities'
)
end
it
'uses statistics to do the count'
do
models
.
each
{
|
model
|
expect
(
model
).
not_to
receive
(
:count
)
}
expect
(
subject
).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
end
end
context
'insufficient permissions'
do
it
'returns an empty hash'
do
allow
(
ActiveRecord
::
Base
).
to
receive
(
:transaction
).
and_raise
(
PG
::
InsufficientPrivilege
)
expect
(
subject
).
to
eq
({})
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录