Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
d7324f0e
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
d7324f0e
编写于
10月 14, 2016
作者:
D
Dmitriy Zaporozhets
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Move edit group scenario to rspec and refactor groups_spec
Signed-off-by:
N
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
上级
17e23b4c
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
42 addition
and
54 deletion
+42
-54
config/routes/group.rb
config/routes/group.rb
+0
-1
features/groups.feature
features/groups.feature
+0
-5
features/steps/groups.rb
features/steps/groups.rb
+0
-12
spec/features/groups_spec.rb
spec/features/groups_spec.rb
+42
-36
未找到文件。
config/routes/group.rb
浏览文件 @
d7324f0e
...
...
@@ -3,7 +3,6 @@ require 'constraints/group_url_constrainer'
constraints
(
GroupUrlConstrainer
.
new
)
do
scope
(
path:
':id'
,
as: :group
,
controller: :groups
)
do
get
'/'
,
action: :show
post
'/'
,
action: :create
patch
'/'
,
action: :update
put
'/'
,
action: :update
delete
'/'
,
action: :destroy
...
...
features/groups.feature
浏览文件 @
d7324f0e
...
...
@@ -39,11 +39,6 @@ Feature: Groups
When
I visit group
"Owned"
merge requests page
Then
I should not see merge requests from the archived project
Scenario
:
I
should see edit group
"Owned"
page
When
I visit group
"Owned"
settings page
And
I change group
"Owned"
name to
"new-name"
Then
I should see new group
"Owned"
name
Scenario
:
I
edit group
"Owned"
avatar
When
I visit group
"Owned"
settings page
And
I change group
"Owned"
avatar
...
...
features/steps/groups.rb
浏览文件 @
d7324f0e
...
...
@@ -73,18 +73,6 @@ class Spinach::Features::Groups < Spinach::FeatureSteps
author:
current_user
end
step
'I change group "Owned" name to "new-name"'
do
fill_in
'group_name'
,
with:
'new-name'
fill_in
'group_path'
,
with:
'new-name'
click_button
"Save group"
end
step
'I should see new group "Owned" name'
do
page
.
within
".navbar-gitlab"
do
expect
(
page
).
to
have_content
"new-name"
end
end
step
'I change group "Owned" avatar'
do
attach_file
(
:group_avatar
,
File
.
join
(
Rails
.
root
,
'spec'
,
'fixtures'
,
'banana_sample.gif'
))
click_button
"Save group"
...
...
spec/features/groups_spec.rb
浏览文件 @
d7324f0e
...
...
@@ -11,93 +11,99 @@ feature 'Group', feature: true do
end
end
describe
'creating a group with space in group path'
do
it
'renders new group form with validation errors'
do
visit
new_group_path
fill_in
'Group path'
,
with:
'space group'
describe
'create a group'
do
before
{
visit
new_group_path
}
click_button
'Create group'
describe
'with space in group path'
do
it
'renders new group form with validation errors'
do
fill_in
'Group path'
,
with:
'space group'
click_button
'Create group'
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
end
end
end
describe
'creating a group with .atom at end of group path'
do
it
'renders new group form with validation errors'
do
visit
new_group_path
fill_in
'Group path'
,
with:
'atom_group.atom'
click_button
'Create group'
describe
'with .atom at end of group path'
do
it
'renders new group form with validation errors'
do
fill_in
'Group path'
,
with:
'atom_group.atom'
click_button
'Create group'
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
end
end
end
describe
'creating a group with .git at end of group path'
do
it
'renders new group form with validation errors'
do
visit
new_group_path
fill_in
'Group path'
,
with:
'git_group.git'
click_button
'Create group'
describe
'with .git at end of group path'
do
it
'renders new group form with validation errors'
do
fill_in
'Group path'
,
with:
'git_group.git'
click_button
'Create group'
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_namespace_error_message
end
end
end
describe
'
Group E
dit'
do
describe
'
group e
dit'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:path
)
{
edit_group_path
(
group
)
}
let
(
:new_name
)
{
'new-name'
}
it
'saves new settings'
do
expect
(
group
.
request_access_enabled
).
to
be_truthy
visit
path
find
(
'#group_request_access_enabled'
).
set
(
false
)
before
{
visit
path
}
it
'saves new settings'
do
fill_in
'group_name'
,
with:
new_name
click_button
'Save group'
expect
(
page
).
to
have_content
'successfully updated'
group
.
reload
expect
(
group
.
request_access_enabled
).
to
be_falsey
expect
(
find
(
'#group_name'
).
value
).
to
eq
(
new_name
)
page
.
within
".navbar-gitlab"
do
expect
(
page
).
to
have_content
new_name
end
end
it
'removes group'
do
visit
path
click_link
'Remove Group'
expect
(
page
).
to
have_content
"scheduled for deletion"
end
end
describe
'description'
do
describe
'
group page with markdown
description'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:path
)
{
group_path
(
group
)
}
it
'parses Markdown'
do
group
.
update_attribute
(
:description
,
'This is **my** group'
)
visit
path
expect
(
page
).
to
have_css
(
'.description > p > strong'
)
end
it
'passes through html-pipeline'
do
group
.
update_attribute
(
:description
,
'This group is the :poop:'
)
visit
path
expect
(
page
).
to
have_css
(
'.description > p > img'
)
end
it
'sanitizes unwanted tags'
do
group
.
update_attribute
(
:description
,
'# Group Description'
)
visit
path
expect
(
page
).
not_to
have_css
(
'.description h1'
)
end
it
'permits `rel` attribute on links'
do
group
.
update_attribute
(
:description
,
'https://google.com/'
)
visit
path
expect
(
page
).
to
have_css
(
'.description a[rel]'
)
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录