Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
d27e36f3
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d27e36f3
编写于
7月 27, 2016
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add specs for caching commit author
上级
8a9fc2b6
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
35 addition
and
7 deletion
+35
-7
app/models/commit.rb
app/models/commit.rb
+15
-7
spec/models/commit_spec.rb
spec/models/commit_spec.rb
+20
-0
未找到文件。
app/models/commit.rb
浏览文件 @
d27e36f3
...
...
@@ -178,14 +178,18 @@ class Commit
end
def
author
key
=
"commit_author:
#{
author_email
}
"
# nil is a valid value since no author may exist in the system
unless
RequestStore
.
store
.
has_key?
(
key
)
RequestStore
.
store
[
key
]
=
User
.
find_by_any_email
(
author_email
.
downcase
)
if
RequestStore
.
active?
key
=
"commit_author:
#{
author_email
.
downcase
}
"
# nil is a valid value since no author may exist in the system
if
RequestStore
.
store
.
has_key?
(
key
)
@author
=
RequestStore
.
store
[
key
]
else
@author
=
find_author_by_any_email
RequestStore
.
store
[
key
]
=
@author
end
else
@author
||=
find_author_by_any_email
end
@author
||=
RequestStore
.
store
[
key
]
end
def
committer
...
...
@@ -313,6 +317,10 @@ class Commit
private
def
find_author_by_any_email
User
.
find_by_any_email
(
author_email
.
downcase
)
end
def
repo_changes
changes
=
{
added:
[],
modified:
[],
removed:
[]
}
...
...
spec/models/commit_spec.rb
浏览文件 @
d27e36f3
...
...
@@ -13,6 +13,26 @@ describe Commit, models: true do
it
{
is_expected
.
to
include_module
(
StaticModel
)
}
end
describe
'#author'
do
it
'looks up the author in a case-insensitive way'
do
user
=
create
(
:user
,
email:
commit
.
author_email
.
upcase
)
expect
(
commit
.
author
).
to
eq
(
user
)
end
it
'caches the author'
do
user
=
create
(
:user
,
email:
commit
.
author_email
)
expect
(
RequestStore
).
to
receive
(
:active?
).
twice
.
and_return
(
true
)
expect_any_instance_of
(
Commit
).
to
receive
(
:find_author_by_any_email
).
and_call_original
expect
(
commit
.
author
).
to
eq
(
user
)
key
=
"commit_author:
#{
commit
.
author_email
}
"
expect
(
RequestStore
.
store
[
key
]).
to
eq
(
user
)
expect
(
commit
.
author
).
to
eq
(
user
)
RequestStore
.
store
.
clear
end
end
describe
'#to_reference'
do
it
'returns a String reference to the object'
do
expect
(
commit
.
to_reference
).
to
eq
commit
.
id
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录