Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
cda0b7e1
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
cda0b7e1
编写于
3月 10, 2016
作者:
J
Jacob Vosmaer
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Rename ExpiringLock to ExclusiveLease
上级
acd9bc02
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
39 addition
and
54 deletion
+39
-54
app/controllers/application_controller.rb
app/controllers/application_controller.rb
+1
-1
lib/gitlab/exclusive_lease.rb
lib/gitlab/exclusive_lease.rb
+37
-0
lib/gitlab/expiring_lock.rb
lib/gitlab/expiring_lock.rb
+0
-52
lib/gitlab/ldap/access.rb
lib/gitlab/ldap/access.rb
+1
-1
未找到文件。
app/controllers/application_controller.rb
浏览文件 @
cda0b7e1
...
...
@@ -246,7 +246,7 @@ class ApplicationController < ActionController::Base
def
ldap_security_check
if
current_user
&&
current_user
.
requires_ldap_check?
return
unless
Gitlab
::
LDAP
::
Access
.
try_lock_user
(
user
)
return
unless
Gitlab
::
LDAP
::
Access
.
try_lock_user
(
current_
user
)
unless
Gitlab
::
LDAP
::
Access
.
allowed?
(
current_user
)
sign_out
current_user
...
...
lib/gitlab/exclusive_lease.rb
0 → 100644
浏览文件 @
cda0b7e1
require
'securerandom'
module
Gitlab
# This class implements an 'exclusive lease'. We call it a 'lease'
# because it has a set expiry time. We call it 'exclusive' because only
# one caller may obtain a lease for a given key at a time. The
# implementation is intended to work across GitLab processes and across
# servers. It is a 'cheap' alternative to using SQL queries and updates:
# you do not need to change the SQL schema to start using
# ExclusiveLease.
class
ExclusiveLease
def
initialize
(
key
,
timeout
)
@key
,
@timeout
=
key
,
timeout
end
# Try to obtain the lease. Return true on succes,
# false if the lease is already taken.
def
try_obtain
!!
redis
.
set
(
redis_key
,
redis_value
,
nx:
true
,
ex:
@timeout
)
end
private
def
redis
# Maybe someday we want to use a connection pool...
@redis
||=
Redis
.
new
(
url:
Gitlab
::
RedisConfig
.
url
)
end
def
redis_key
"gitlab:exclusive_lease:
#{
@key
}
"
end
def
redis_value
@redis_value
||=
SecureRandom
.
hex
(
10
)
end
end
end
lib/gitlab/expiring_lock.rb
已删除
100644 → 0
浏览文件 @
acd9bc02
module
Gitlab
# This class implements a distributed self-expiring lock.
#
# [2] pry(main)> l = Gitlab::ExpiringLock.new('foobar', 5)
# => #<Gitlab::ExpiringLock:0x007ffb9d7cb7f8 @key="foobar", @timeout=5>
# [3] pry(main)> l.try_lock
# => true
# [4] pry(main)> l.try_lock # Only the first try_lock succeeds
# => false
# [5] pry(main)> l.locked?
# => true
# [6] pry(main)> sleep 5
# => 5
# [7] pry(main)> l.locked? # After the timeout the lock is released
# => false
#
class
ExpiringLock
def
initialize
(
key
,
timeout
)
@key
,
@timeout
=
key
,
timeout
end
# Try to obtain the lock. Return true on succes,
# false if the lock is already taken.
def
try_lock
# INCR does not change the key TTL
if
redis
.
incr
(
redis_key
)
==
1
# We won the race to insert the key into Redis
redis
.
expire
(
redis_key
,
@timeout
)
true
else
# Somebody else won the race
false
end
end
# Check if somebody somewhere locked this key
def
locked?
!!
redis
.
get
(
redis_key
)
end
private
def
redis
# Maybe someday we want to use a connection pool...
@redis
||=
Redis
.
new
(
url:
Gitlab
::
RedisConfig
.
url
)
end
def
redis_key
"gitlab:expiring_lock:
#{
@key
}
"
end
end
end
lib/gitlab/ldap/access.rb
浏览文件 @
cda0b7e1
...
...
@@ -10,7 +10,7 @@ module Gitlab
LOCK_TIMEOUT
=
600
def
self
.
try_lock_user
(
user
)
Gitlab
::
Ex
piringLock
.
new
(
"user_ldap_check:
#{
user
.
id
}
"
,
LOCK_TIMEOUT
).
try_lock
Gitlab
::
Ex
clusiveLease
.
new
(
"user_ldap_check:
#{
user
.
id
}
"
,
LOCK_TIMEOUT
).
try_obtain
end
def
self
.
open
(
user
,
&
block
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录