Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
cd834b46
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
cd834b46
编写于
5月 10, 2018
作者:
D
Dylan Griffith
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Ensure Ci::Runner#assign_to errors for group runners
上级
84fa0610
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
22 addition
and
7 deletion
+22
-7
app/models/ci/runner.rb
app/models/ci/runner.rb
+2
-0
spec/models/ci/runner_spec.rb
spec/models/ci/runner_spec.rb
+20
-7
未找到文件。
app/models/ci/runner.rb
浏览文件 @
cd834b46
...
...
@@ -111,6 +111,8 @@ module Ci
if
shared?
self
.
is_shared
=
false
if
shared?
self
.
runner_type
=
:project_type
elsif
group_type?
raise
ArgumentError
,
'Transitioning a group runner to a project runner is not supported'
end
self
.
save
...
...
spec/models/ci/runner_spec.rb
浏览文件 @
cd834b46
...
...
@@ -200,16 +200,29 @@ describe Ci::Runner do
describe
'#assign_to'
do
let!
(
:project
)
{
FactoryBot
.
create
(
:project
)
}
let!
(
:shared_runner
)
{
FactoryBot
.
create
(
:ci_runner
,
:shared
)
}
before
do
shared_runner
.
assign_to
(
project
)
subject
{
runner
.
assign_to
(
project
)
}
context
'with shared_runner'
do
let!
(
:runner
)
{
FactoryBot
.
create
(
:ci_runner
,
:shared
)
}
it
'transitions shared runner to project runner and assigns project'
do
subject
expect
(
runner
).
to
be_specific
expect
(
runner
).
to
be_project_type
expect
(
runner
.
projects
).
to
eq
([
project
])
expect
(
runner
.
only_for?
(
project
)).
to
be_truthy
end
end
it
{
expect
(
shared_runner
).
to
be_specific
}
it
{
expect
(
shared_runner
).
to
be_project_type
}
it
{
expect
(
shared_runner
.
projects
).
to
eq
([
project
])
}
it
{
expect
(
shared_runner
.
only_for?
(
project
)).
to
be_truthy
}
context
'with group runner'
do
let!
(
:runner
)
{
FactoryBot
.
create
(
:ci_runner
,
runner_type: :group_type
)
}
it
'raises an error'
do
expect
{
subject
}
.
to
raise_error
(
ArgumentError
,
'Transitioning a group runner to a project runner is not supported'
)
end
end
end
describe
'.online'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录