Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
cae27eae
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
cae27eae
编写于
10月 27, 2016
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
API: Fix booleans not recognized as such when using the `to_boolean` helper
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
b3210df3
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
20 addition
and
11 deletion
+20
-11
CHANGELOG.md
CHANGELOG.md
+1
-0
lib/api/helpers.rb
lib/api/helpers.rb
+1
-0
spec/requests/api/api_helpers_spec.rb
spec/requests/api/api_helpers_spec.rb
+18
-11
未找到文件。
CHANGELOG.md
浏览文件 @
cae27eae
...
...
@@ -11,6 +11,7 @@ Please view this file on the master branch, on stable branches it's out of date.
-
Fix HipChat notifications rendering (airatshigapov, eisnerd)
-
Add hover to trash icon in notes !7008 (blackst0ne)
-
Fix sidekiq stats in admin area (blackst0ne)
-
API: Fix booleans not recognized as such when using the
`to_boolean`
helper
-
Removed delete branch tooltip !6954
-
Escape ref and path for relative links !6050 (winniehell)
-
Fixed link typo on /help/ui to Alerts section. !6915 (Sam Rose)
...
...
lib/api/helpers.rb
浏览文件 @
cae27eae
...
...
@@ -6,6 +6,7 @@ module API
SUDO_PARAM
=
:sudo
def
to_boolean
(
value
)
return
value
if
[
true
,
false
].
include?
(
value
)
return
true
if
value
=~
/^(true|t|yes|y|1|on)$/i
return
false
if
value
=~
/^(false|f|no|n|0|off)$/i
...
...
spec/requests/api/api_helpers_spec.rb
浏览文件 @
cae27eae
...
...
@@ -266,18 +266,25 @@ describe API::Helpers, api: true do
end
describe
'.to_boolean'
do
it
'accepts booleans'
do
expect
(
to_boolean
(
true
)).
to
be
(
true
)
expect
(
to_boolean
(
false
)).
to
be
(
false
)
end
it
'converts a valid string to a boolean'
do
expect
(
to_boolean
(
'true'
)).
to
be_truthy
expect
(
to_boolean
(
'YeS'
)).
to
be_truthy
expect
(
to_boolean
(
't'
)).
to
be_truthy
expect
(
to_boolean
(
'1'
)).
to
be_truthy
expect
(
to_boolean
(
'ON'
)).
to
be_truthy
expect
(
to_boolean
(
'FaLse'
)).
to
be_falsy
expect
(
to_boolean
(
'F'
)).
to
be_falsy
expect
(
to_boolean
(
'NO'
)).
to
be_falsy
expect
(
to_boolean
(
'n'
)).
to
be_falsy
expect
(
to_boolean
(
'0'
)).
to
be_falsy
expect
(
to_boolean
(
'oFF'
)).
to
be_falsy
expect
(
to_boolean
(
true
)).
to
be
(
true
)
expect
(
to_boolean
(
'true'
)).
to
be
(
true
)
expect
(
to_boolean
(
'YeS'
)).
to
be
(
true
)
expect
(
to_boolean
(
't'
)).
to
be
(
true
)
expect
(
to_boolean
(
'1'
)).
to
be
(
true
)
expect
(
to_boolean
(
'ON'
)).
to
be
(
true
)
expect
(
to_boolean
(
'FaLse'
)).
to
be
(
false
)
expect
(
to_boolean
(
'F'
)).
to
be
(
false
)
expect
(
to_boolean
(
'NO'
)).
to
be
(
false
)
expect
(
to_boolean
(
'n'
)).
to
be
(
false
)
expect
(
to_boolean
(
'0'
)).
to
be
(
false
)
expect
(
to_boolean
(
'oFF'
)).
to
be
(
false
)
end
it
'converts an invalid string to nil'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录