Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
c9abdadd
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
c9abdadd
编写于
3月 14, 2017
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Ensure dots in project path is allowed in the commits API
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
e52529e2
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
19 addition
and
17 deletion
+19
-17
lib/api/commits.rb
lib/api/commits.rb
+1
-1
lib/api/v3/commits.rb
lib/api/v3/commits.rb
+1
-1
spec/requests/api/commits_spec.rb
spec/requests/api/commits_spec.rb
+9
-8
spec/requests/api/v3/commits_spec.rb
spec/requests/api/v3/commits_spec.rb
+8
-7
未找到文件。
lib/api/commits.rb
浏览文件 @
c9abdadd
...
...
@@ -10,7 +10,7 @@ module API
params
do
requires
:id
,
type:
String
,
desc:
'The ID of a project'
end
resource
:projects
do
resource
:projects
,
requirements:
{
id:
/.+/
}
do
desc
'Get a project repository commits'
do
success
Entities
::
RepoCommit
end
...
...
lib/api/v3/commits.rb
浏览文件 @
c9abdadd
...
...
@@ -11,7 +11,7 @@ module API
params
do
requires
:id
,
type:
String
,
desc:
'The ID of a project'
end
resource
:projects
do
resource
:projects
,
requirements:
{
id:
/.+/
}
do
desc
'Get a project repository commits'
do
success
::
API
::
Entities
::
RepoCommit
end
...
...
spec/requests/api/commits_spec.rb
浏览文件 @
c9abdadd
...
...
@@ -178,7 +178,7 @@ describe API::Commits, api: true do
end
end
describe
"
Create a commit with multiple files and action
s"
do
describe
"
POST /projects/:id/repository/commit
s"
do
let!
(
:url
)
{
"/projects/
#{
project
.
id
}
/repository/commits"
}
it
'returns a 403 unauthorized for user without permissions'
do
...
...
@@ -193,7 +193,7 @@ describe API::Commits, api: true do
expect
(
response
).
to
have_http_status
(
400
)
end
context
:create
do
describe
'create'
do
let
(
:message
)
{
'Created file'
}
let!
(
:invalid_c_params
)
do
{
...
...
@@ -237,8 +237,9 @@ describe API::Commits, api: true do
expect
(
response
).
to
have_http_status
(
400
)
end
context
'with project path in URL'
do
let
(
:url
)
{
"/projects/
#{
project
.
full_path
.
gsub
(
'/'
,
'%2F'
)
}
/repository/commits"
}
context
'with project path containing a dot in URL'
do
let!
(
:user
)
{
create
(
:user
,
username:
'foo.bar'
)
}
let
(
:url
)
{
"/projects/
#{
CGI
.
escape
(
project
.
full_path
)
}
/repository/commits"
}
it
'a new file in project repo'
do
post
api
(
url
,
user
),
valid_c_params
...
...
@@ -248,7 +249,7 @@ describe API::Commits, api: true do
end
end
context
:delete
do
describe
'delete'
do
let
(
:message
)
{
'Deleted file'
}
let!
(
:invalid_d_params
)
do
{
...
...
@@ -289,7 +290,7 @@ describe API::Commits, api: true do
end
end
context
:move
do
describe
'move'
do
let
(
:message
)
{
'Moved file'
}
let!
(
:invalid_m_params
)
do
{
...
...
@@ -334,7 +335,7 @@ describe API::Commits, api: true do
end
end
context
:update
do
describe
'update'
do
let
(
:message
)
{
'Updated file'
}
let!
(
:invalid_u_params
)
do
{
...
...
@@ -377,7 +378,7 @@ describe API::Commits, api: true do
end
end
context
"multiple operations"
do
describe
'multiple operations'
do
let
(
:message
)
{
'Multiple actions'
}
let!
(
:invalid_mo_params
)
do
{
...
...
spec/requests/api/v3/commits_spec.rb
浏览文件 @
c9abdadd
...
...
@@ -88,7 +88,7 @@ describe API::V3::Commits, api: true do
end
end
describe
"
Create a commit with multiple files and action
s"
do
describe
"
POST /projects/:id/repository/commit
s"
do
let!
(
:url
)
{
"/projects/
#{
project
.
id
}
/repository/commits"
}
it
'returns a 403 unauthorized for user without permissions'
do
...
...
@@ -103,7 +103,7 @@ describe API::V3::Commits, api: true do
expect
(
response
).
to
have_http_status
(
400
)
end
context
:create
do
describe
'create'
do
let
(
:message
)
{
'Created file'
}
let!
(
:invalid_c_params
)
do
{
...
...
@@ -147,8 +147,9 @@ describe API::V3::Commits, api: true do
expect
(
response
).
to
have_http_status
(
400
)
end
context
'with project path in URL'
do
let
(
:url
)
{
"/projects/
#{
project
.
full_path
.
gsub
(
'/'
,
'%2F'
)
}
/repository/commits"
}
context
'with project path containing a dot in URL'
do
let!
(
:user
)
{
create
(
:user
,
username:
'foo.bar'
)
}
let
(
:url
)
{
"/projects/
#{
CGI
.
escape
(
project
.
full_path
)
}
/repository/commits"
}
it
'a new file in project repo'
do
post
v3_api
(
url
,
user
),
valid_c_params
...
...
@@ -158,7 +159,7 @@ describe API::V3::Commits, api: true do
end
end
context
:delete
do
describe
'delete'
do
let
(
:message
)
{
'Deleted file'
}
let!
(
:invalid_d_params
)
do
{
...
...
@@ -199,7 +200,7 @@ describe API::V3::Commits, api: true do
end
end
context
:move
do
describe
'move'
do
let
(
:message
)
{
'Moved file'
}
let!
(
:invalid_m_params
)
do
{
...
...
@@ -244,7 +245,7 @@ describe API::V3::Commits, api: true do
end
end
context
:update
do
describe
'update'
do
let
(
:message
)
{
'Updated file'
}
let!
(
:invalid_u_params
)
do
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录