Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
c6511235
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c6511235
编写于
8月 16, 2016
作者:
D
Douglas Barbosa Alexandre
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add a destroyable scope and a destroyable? method to List model
上级
29a91c5b
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
33 addition
and
10 deletion
+33
-10
app/controllers/projects/boards/lists_controller.rb
app/controllers/projects/boards/lists_controller.rb
+4
-7
app/models/list.rb
app/models/list.rb
+8
-2
app/services/boards/lists/destroy_service.rb
app/services/boards/lists/destroy_service.rb
+1
-1
spec/models/list_spec.rb
spec/models/list_spec.rb
+20
-0
未找到文件。
app/controllers/projects/boards/lists_controller.rb
浏览文件 @
c6511235
...
...
@@ -3,7 +3,6 @@ module Projects
class
ListsController
<
Boards
::
ApplicationController
before_action
:authorize_admin_list!
,
only:
[
:create
,
:update
,
:destroy
,
:generate
]
before_action
:authorize_read_list!
,
only:
[
:index
]
before_action
:load_list
,
only:
[
:update
,
:destroy
]
def
index
render
json:
serialize_as_json
(
project
.
board
.
lists
)
...
...
@@ -20,9 +19,10 @@ module Projects
end
def
update
list
=
project
.
board
.
lists
.
find
(
params
[
:id
])
service
=
::
Boards
::
Lists
::
MoveService
.
new
(
project
,
current_user
,
move_params
)
if
service
.
execute
(
@
list
)
if
service
.
execute
(
list
)
head
:ok
else
head
:unprocessable_entity
...
...
@@ -30,9 +30,10 @@ module Projects
end
def
destroy
list
=
project
.
board
.
lists
.
destroyable
.
find
(
params
[
:id
])
service
=
::
Boards
::
Lists
::
DestroyService
.
new
(
project
,
current_user
,
params
)
if
service
.
execute
(
@
list
)
if
service
.
execute
(
list
)
head
:ok
else
head
:unprocessable_entity
...
...
@@ -59,10 +60,6 @@ module Projects
return
render_403
unless
can?
(
current_user
,
:read_list
,
project
)
end
def
load_list
@list
=
project
.
board
.
lists
.
find
(
params
[
:id
])
end
def
list_params
params
.
require
(
:list
).
permit
(
:label_id
)
end
...
...
app/models/list.rb
浏览文件 @
c6511235
...
...
@@ -9,7 +9,13 @@ class List < ActiveRecord::Base
validates
:label_id
,
uniqueness:
{
scope: :board_id
},
if: :label?
validates
:position
,
numericality:
{
only_integer:
true
,
greater_than_or_equal_to:
0
},
if: :label?
before_destroy
:can_be_destroyed
,
unless: :label?
before_destroy
:can_be_destroyed
scope
:destroyable
,
->
{
where
(
list_type:
list_types
[
:label
])
}
def
destroyable?
label?
end
def
title
label?
?
label
.
name
:
list_type
.
humanize
...
...
@@ -18,6 +24,6 @@ class List < ActiveRecord::Base
private
def
can_be_destroyed
false
destroyable?
end
end
app/services/boards/lists/destroy_service.rb
浏览文件 @
c6511235
...
...
@@ -2,7 +2,7 @@ module Boards
module
Lists
class
DestroyService
<
Boards
::
BaseService
def
execute
(
list
)
return
false
unless
list
.
label
?
return
false
unless
list
.
destroyable
?
list
.
with_lock
do
decrement_higher_lists
(
list
)
...
...
spec/models/list_spec.rb
浏览文件 @
c6511235
...
...
@@ -54,6 +54,26 @@ describe List do
end
end
describe
'#destroyable?'
do
it
'retruns true when list_type is set to label'
do
subject
.
list_type
=
:label
expect
(
subject
).
to
be_destroyable
end
it
'retruns false when list_type is set to backlog'
do
subject
.
list_type
=
:backlog
expect
(
subject
).
not_to
be_destroyable
end
it
'retruns false when list_type is set to done'
do
subject
.
list_type
=
:done
expect
(
subject
).
not_to
be_destroyable
end
end
describe
'#title'
do
it
'returns label name when list_type is set to label'
do
subject
.
list_type
=
:label
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录