Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
c5fb4682
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
c5fb4682
编写于
10月 28, 2018
作者:
A
Andreas Brandl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Flexible approximate counts with fallback strategies.
上级
b6a530c9
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
32 addition
and
21 deletion
+32
-21
lib/gitlab/database/count.rb
lib/gitlab/database/count.rb
+18
-14
spec/lib/gitlab/database/count_spec.rb
spec/lib/gitlab/database/count_spec.rb
+14
-7
未找到文件。
lib/gitlab/database/count.rb
浏览文件 @
c5fb4682
...
...
@@ -25,21 +25,17 @@ module Gitlab
#
# @param [Array]
# @return [Hash] of Model -> count mapping
def
self
.
approximate_counts
(
models
)
counts_by_model
=
{}
if
Gitlab
::
Database
.
postgresql?
#counts_by_model = ReltuplesCountStrategy.new(models).count
counts_by_model
=
reltuples_from_recently_updated
(
models
)
end
missing_models
=
models
-
counts_by_model
.
keys
ExactCountStrategy
.
new
(
missing_models
).
count
.
each
do
|
model
,
count
|
counts_by_model
[
model
]
=
count
def
self
.
approximate_counts
(
models
,
strategies
=
[
ReltuplesCountStrategy
,
ExactCountStrategy
])
strategies
.
each_with_object
({})
do
|
strategy
,
counts_by_model
|
if
strategy
.
enabled?
models_with_missing_counts
=
models
-
counts_by_model
.
keys
counts
=
strategy
.
new
(
models_with_missing_counts
).
count
counts
.
each
do
|
model
,
count
|
counts_by_model
[
model
]
=
count
end
end
end
counts_by_model
end
# Returns a hash of the table names that have recently updated tuples.
...
...
@@ -61,6 +57,10 @@ module Gitlab
data
[
model
]
=
model
.
count
end
end
def
self
.
enabled?
true
end
end
class
ReltuplesCountStrategy
...
...
@@ -92,6 +92,10 @@ module Gitlab
{}
end
def
self
.
enabled?
Gitlab
::
Database
.
postgresql?
end
private
def
table_names
...
...
spec/lib/gitlab/database/count_spec.rb
浏览文件 @
c5fb4682
...
...
@@ -23,10 +23,14 @@ describe Gitlab::Database::Count do
end
context
'with PostgreSQL'
,
:postgresql
do
let
(
:reltuples_strategy
)
{
double
(
'reltuples_strategy'
,
count:
{})
}
before
do
allow
(
Gitlab
::
Database
::
Count
::
ReltuplesCountStrategy
).
to
receive
(
:new
).
with
(
models
).
and_return
(
reltuples_strategy
)
end
describe
'when reltuples have not been updated'
do
it
'counts all models the normal way'
do
expect
(
described_class
).
to
receive
(
:reltuples_from_recently_updated
).
with
(
models
).
and_return
({})
expect
(
Project
).
to
receive
(
:count
).
and_call_original
expect
(
Identity
).
to
receive
(
:count
).
and_call_original
expect
(
described_class
.
approximate_counts
(
models
)).
to
eq
({
Project
=>
3
,
Identity
=>
1
})
...
...
@@ -45,7 +49,7 @@ describe Gitlab::Database::Count do
describe
'when some reltuples have been updated'
do
it
'counts projects in the fast way'
do
expect
(
described_class
).
to
receive
(
:reltuples_from_recently_updated
).
with
(
models
).
and_return
({
Project
=>
3
})
expect
(
reltuples_strategy
).
to
receive
(
:count
).
and_return
({
Project
=>
3
})
expect
(
Project
).
not_to
receive
(
:count
).
and_call_original
expect
(
Identity
).
to
receive
(
:count
).
and_call_original
...
...
@@ -53,13 +57,16 @@ describe Gitlab::Database::Count do
end
end
# TODO: This covers two parts: reltuple strategy itself and the fallback
# TODO: Add spec that covers strategy details for reltuple strategy
describe
'when all reltuples have been updated'
do
before
do
ActiveRecord
::
Base
.
connection
.
execute
(
'ANALYZE projects'
)
ActiveRecord
::
Base
.
connection
.
execute
(
'ANALYZE identities'
)
end
#
before do
#
ActiveRecord::Base.connection.execute('ANALYZE projects')
#
ActiveRecord::Base.connection.execute('ANALYZE identities')
#
end
it
'counts models with the standard way'
do
allow
(
reltuples_strategy
).
to
receive
(
:count
).
and_return
({
Project
=>
3
,
Identity
=>
1
})
expect
(
Project
).
not_to
receive
(
:count
)
expect
(
Identity
).
not_to
receive
(
:count
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录