Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
bf07af9b
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
bf07af9b
编写于
2月 16, 2017
作者:
C
Clement Ho
浏览文件
操作
浏览文件
下载
差异文件
Merge branch '26957-tanuki-anim-hang' into 'master'
don't trigger tanuki loader when downloading files See merge request !9290
上级
f86c4938
1a299121
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
26 addition
and
6 deletion
+26
-6
app/assets/javascripts/vue_pipelines_index/pipeline_actions.js.es6
...s/javascripts/vue_pipelines_index/pipeline_actions.js.es6
+1
-0
app/views/projects/buttons/_download.html.haml
app/views/projects/buttons/_download.html.haml
+5
-5
app/views/projects/ci/pipelines/_pipeline.html.haml
app/views/projects/ci/pipelines/_pipeline.html.haml
+1
-1
changelogs/unreleased/26957-tanuki-anim-hang.yml
changelogs/unreleased/26957-tanuki-anim-hang.yml
+4
-0
spec/features/projects/main/download_buttons_spec.rb
spec/features/projects/main/download_buttons_spec.rb
+7
-0
spec/features/projects/pipelines/pipelines_spec.rb
spec/features/projects/pipelines/pipelines_spec.rb
+8
-0
未找到文件。
app/assets/javascripts/vue_pipelines_index/pipeline_actions.js.es6
浏览文件 @
bf07af9b
...
...
@@ -62,6 +62,7 @@
<li v-for='artifact in pipeline.details.artifacts'>
<a
rel="nofollow"
download
:href='artifact.path'
>
<i class="fa fa-download" aria-hidden="true"></i>
...
...
app/views/projects/buttons/_download.html.haml
浏览文件 @
bf07af9b
...
...
@@ -8,19 +8,19 @@
%ul
.dropdown-menu.dropdown-menu-align-right
{
role:
'menu'
}
%li
.dropdown-header
Source code
%li
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'zip'
),
rel:
'nofollow'
do
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'zip'
),
rel:
'nofollow'
,
download:
''
do
%i
.fa.fa-download
%span
Download zip
%li
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar.gz'
),
rel:
'nofollow'
do
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar.gz'
),
rel:
'nofollow'
,
download:
''
do
%i
.fa.fa-download
%span
Download tar.gz
%li
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar.bz2'
),
rel:
'nofollow'
do
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar.bz2'
),
rel:
'nofollow'
,
download:
''
do
%i
.fa.fa-download
%span
Download tar.bz2
%li
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar'
),
rel:
'nofollow'
do
=
link_to
archive_namespace_project_repository_path
(
project
.
namespace
,
project
,
ref:
ref
,
format:
'tar'
),
rel:
'nofollow'
,
download:
''
do
%i
.fa.fa-download
%span
Download tar
...
...
@@ -36,6 +36,6 @@
%li
.dropdown-header
Previous Artifacts
-
artifacts
.
each
do
|
job
|
%li
=
link_to
latest_succeeded_namespace_project_artifacts_path
(
project
.
namespace
,
project
,
"
#{
ref
}
/download"
,
job:
job
.
name
),
rel:
'nofollow'
do
=
link_to
latest_succeeded_namespace_project_artifacts_path
(
project
.
namespace
,
project
,
"
#{
ref
}
/download"
,
job:
job
.
name
),
rel:
'nofollow'
,
download:
''
do
%i
.fa.fa-download
%span
Download '
#{
job
.
name
}
'
app/views/projects/ci/pipelines/_pipeline.html.haml
浏览文件 @
bf07af9b
...
...
@@ -78,7 +78,7 @@
%ul
.dropdown-menu.dropdown-menu-align-right
-
artifacts
.
each
do
|
build
|
%li
=
link_to
download_namespace_project_build_artifacts_path
(
pipeline
.
project
.
namespace
,
pipeline
.
project
,
build
),
rel:
'nofollow'
do
=
link_to
download_namespace_project_build_artifacts_path
(
pipeline
.
project
.
namespace
,
pipeline
.
project
,
build
),
rel:
'nofollow'
,
download:
''
do
=
icon
(
"download"
)
%span
Download '
#{
build
.
name
}
' artifacts
...
...
changelogs/unreleased/26957-tanuki-anim-hang.yml
0 → 100644
浏览文件 @
bf07af9b
---
title
:
don't animate logo when downloading files
merge_request
:
author
:
spec/features/projects/main/download_buttons_spec.rb
浏览文件 @
bf07af9b
...
...
@@ -39,6 +39,13 @@ feature 'Download buttons in project main page', feature: true do
expect
(
page
).
to
have_link
"Download '
#{
build
.
name
}
'"
,
href:
href
end
scenario
'download links have download attribute'
do
expect
(
page
).
to
have_selector
(
'a'
,
text:
'Download'
)
page
.
all
(
'a'
,
text:
'Download'
).
each
do
|
link
|
expect
(
link
[
:download
]).
to
eq
''
end
end
end
end
end
spec/features/projects/pipelines/pipelines_spec.rb
浏览文件 @
bf07af9b
...
...
@@ -218,6 +218,14 @@ describe 'Pipelines', :feature, :js do
expect
(
page
).
to
have_link
(
with_artifacts
.
name
)
end
it
'has download attribute on download links'
do
find
(
'.js-pipeline-dropdown-download'
).
click
expect
(
page
).
to
have_selector
(
'a'
,
text:
'Download'
)
page
.
all
(
'.build-artifacts a'
,
text:
'Download'
).
each
do
|
link
|
expect
(
link
[
:download
]).
to
eq
''
end
end
end
context
'with artifacts expired'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录