Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
b85b6590
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
b85b6590
编写于
2月 20, 2019
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix and document an RSpec::Parameterized::TableSyntax edge-case
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
e0fc809b
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
11 addition
and
12 deletion
+11
-12
doc/development/testing_guide/best_practices.md
doc/development/testing_guide/best_practices.md
+5
-5
spec/models/prometheus_metric_spec.rb
spec/models/prometheus_metric_spec.rb
+6
-7
未找到文件。
doc/development/testing_guide/best_practices.md
浏览文件 @
b85b6590
...
@@ -358,16 +358,11 @@ range of inputs, might look like this:
...
@@ -358,16 +358,11 @@ range of inputs, might look like this:
describe
"#=="
do
describe
"#=="
do
using
RSpec
::
Parameterized
::
TableSyntax
using
RSpec
::
Parameterized
::
TableSyntax
let
(
:project1
)
{
create
(
:project
)
}
let
(
:project2
)
{
create
(
:project
)
}
where
(
:a
,
:b
,
:result
)
do
where
(
:a
,
:b
,
:result
)
do
1
|
1
|
true
1
|
1
|
true
1
|
2
|
false
1
|
2
|
false
true
|
true
|
true
true
|
true
|
true
true
|
false
|
false
true
|
false
|
false
project1
|
project1
|
true
project2
|
project2
|
true
project
1
|
project2
|
false
end
end
with_them
do
with_them
do
...
@@ -380,6 +375,11 @@ describe "#==" do
...
@@ -380,6 +375,11 @@ describe "#==" do
end
end
```
```
CAUTION:
**Caution:**
Only use simple values as input in the
`where`
block. Using procs, stateful
objects, FactoryBot-created objects etc. can lead to
[
unexpected results
](
https://github.com/tomykaira/rspec-parameterized/issues/8
)
.
### Prometheus tests
### Prometheus tests
Prometheus metrics may be preserved from one test run to another. To ensure that metrics are
Prometheus metrics may be preserved from one test run to another. To ensure that metrics are
...
...
spec/models/prometheus_metric_spec.rb
浏览文件 @
b85b6590
...
@@ -4,7 +4,6 @@ require 'spec_helper'
...
@@ -4,7 +4,6 @@ require 'spec_helper'
describe
PrometheusMetric
do
describe
PrometheusMetric
do
subject
{
build
(
:prometheus_metric
)
}
subject
{
build
(
:prometheus_metric
)
}
let
(
:other_project
)
{
build
(
:project
)
}
it_behaves_like
'having unique enum values'
it_behaves_like
'having unique enum values'
...
@@ -16,17 +15,17 @@ describe PrometheusMetric do
...
@@ -16,17 +15,17 @@ describe PrometheusMetric do
describe
'common metrics'
do
describe
'common metrics'
do
using
RSpec
::
Parameterized
::
TableSyntax
using
RSpec
::
Parameterized
::
TableSyntax
where
(
:common
,
:project
,
:result
)
do
where
(
:common
,
:
with_
project
,
:result
)
do
false
|
other_project
|
true
false
|
true
|
true
false
|
nil
|
false
false
|
false
|
false
true
|
other_project
|
false
true
|
true
|
false
true
|
nil
|
true
true
|
false
|
true
end
end
with_them
do
with_them
do
before
do
before
do
subject
.
common
=
common
subject
.
common
=
common
subject
.
project
=
project
subject
.
project
=
with_project
?
build
(
:project
)
:
nil
end
end
it
{
expect
(
subject
.
valid?
).
to
eq
(
result
)
}
it
{
expect
(
subject
.
valid?
).
to
eq
(
result
)
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录