Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
b58744cd
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
b58744cd
编写于
2月 04, 2016
作者:
T
Tomasz Maczukin
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Modify authentication check methods in runners API
上级
553bac57
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
22 addition
and
24 deletion
+22
-24
lib/api/runners.rb
lib/api/runners.rb
+22
-24
未找到文件。
lib/api/runners.rb
浏览文件 @
b58744cd
...
...
@@ -31,7 +31,7 @@ module API
# GET /runners/:id
get
':id'
do
runner
=
get_runner
(
params
[
:id
])
can_show_runner?
(
runner
)
unless
current_user
.
is_admin?
authenticate_show_runner!
(
runner
)
present
runner
,
with:
Entities
::
RunnerDetails
,
user_is_admin:
current_user
.
is_admin?
end
...
...
@@ -47,7 +47,7 @@ module API
# PUT /runners/:id
put
':id'
do
runner
=
get_runner
(
params
[
:id
])
can_update_runner?
(
runner
)
unless
current_user
.
is_admin?
authenticate_update_runner!
(
runner
)
attrs
=
attributes_for_keys
[
:description
,
:active
,
:tag_list
]
if
runner
.
update
(
attrs
)
...
...
@@ -65,7 +65,7 @@ module API
# DELETE /runners/:id
delete
':id'
do
runner
=
get_runner
(
params
[
:id
])
can_delete_runner?
(
runner
)
authenticate_delete_runner!
(
runner
)
runner
.
destroy!
present
runner
,
with:
Entities
::
RunnerDetails
...
...
@@ -93,7 +93,7 @@ module API
# POST /projects/:id/runners/:runner_id
post
':id/runners/:runner_id'
do
runner
=
get_runner
(
params
[
:runner_id
])
can_enable_runner?
(
runner
)
authenticate_enable_runner!
(
runner
)
Ci
::
RunnerProject
.
create
(
runner:
runner
,
project:
user_project
)
present
runner
,
with:
Entities
::
Runner
...
...
@@ -111,7 +111,7 @@ module API
not_found!
(
'Runner'
)
unless
runner_project
runner
=
runner_project
.
runner
forbidden!
(
"
Can't disable runner - only one project associated with it. Please remov
e runner instead"
)
if
runner
.
projects
.
count
==
1
forbidden!
(
"
Only one project associated with the runner. Please remove th
e runner instead"
)
if
runner
.
projects
.
count
==
1
runner_project
.
destroy
...
...
@@ -137,34 +137,32 @@ module API
runner
end
def
can_show_runner?
(
runner
)
return
true
if
runner
.
is_shared
forbidden!
(
"
Can't show runner's details - n
o access granted"
)
unless
user_can_access_runner?
(
runner
)
def
authenticate_show_runner!
(
runner
)
return
if
runner
.
is_shared
||
current_user
.
is_admin?
forbidden!
(
"
N
o access granted"
)
unless
user_can_access_runner?
(
runner
)
end
def
can_update_runner?
(
runner
)
return
true
if
current_user
.
is_admin?
forbidden!
(
"
Can't update shared runner
"
)
if
runner
.
is_shared?
forbidden!
(
"
Can't update runner - n
o access granted"
)
unless
user_can_access_runner?
(
runner
)
def
authenticate_update_runner!
(
runner
)
return
if
current_user
.
is_admin?
forbidden!
(
"
Runner is shared
"
)
if
runner
.
is_shared?
forbidden!
(
"
N
o access granted"
)
unless
user_can_access_runner?
(
runner
)
end
def
can_delete_runner?
(
runner
)
return
true
if
current_user
.
is_admin?
forbidden!
(
"
Can't delete shared runner
"
)
if
runner
.
is_shared?
forbidden!
(
"
Can't delete runner -
associated with more than one project"
)
if
runner
.
projects
.
count
>
1
forbidden!
(
"
Can't delete runner - n
o access granted"
)
unless
user_can_access_runner?
(
runner
)
def
authenticate_delete_runner!
(
runner
)
return
if
current_user
.
is_admin?
forbidden!
(
"
Runner is shared
"
)
if
runner
.
is_shared?
forbidden!
(
"
Runner
associated with more than one project"
)
if
runner
.
projects
.
count
>
1
forbidden!
(
"
N
o access granted"
)
unless
user_can_access_runner?
(
runner
)
end
def
can_enable_runner?
(
runner
)
forbidden!
(
"
Can't enable shared runner directly
"
)
if
runner
.
is_shared?
return
true
if
current_user
.
is_admin?
forbidden!
(
"
Can't update runner - n
o access granted"
)
unless
user_can_access_runner?
(
runner
)
def
authenticate_enable_runner!
(
runner
)
forbidden!
(
"
Runner is shared
"
)
if
runner
.
is_shared?
return
if
current_user
.
is_admin?
forbidden!
(
"
N
o access granted"
)
unless
user_can_access_runner?
(
runner
)
end
def
user_can_access_runner?
(
runner
)
runner
.
projects
.
inject
(
false
)
do
|
final
,
project
|
final
||
abilities
.
allowed?
(
current_user
,
:admin_project
,
project
)
end
current_user
.
ci_authorized_runners
.
exists?
(
runner
.
id
)
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录