Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
a4978030
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a4978030
编写于
10月 17, 2016
作者:
K
Kamil Trzcinski
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Improve spec for pipeline metrics worker
上级
9c6c5c79
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
75 addition
and
23 deletion
+75
-23
app/workers/pipeline_metrics_worker.rb
app/workers/pipeline_metrics_worker.rb
+20
-5
spec/models/ci/pipeline_spec.rb
spec/models/ci/pipeline_spec.rb
+9
-18
spec/workers/pipeline_metrics_worker_spec.rb
spec/workers/pipeline_metrics_worker_spec.rb
+46
-0
未找到文件。
app/workers/pipeline_metrics_worker.rb
浏览文件 @
a4978030
...
@@ -5,11 +5,26 @@ class PipelineMetricsWorker
...
@@ -5,11 +5,26 @@ class PipelineMetricsWorker
def
perform
(
pipeline_id
)
def
perform
(
pipeline_id
)
Ci
::
Pipeline
.
find_by
(
id:
pipeline_id
).
try
do
|
pipeline
|
Ci
::
Pipeline
.
find_by
(
id:
pipeline_id
).
try
do
|
pipeline
|
merge_requests
=
pipeline
.
merge_requests
.
map
(
&
:id
)
update_metrics_for_active_pipeline
(
pipeline
)
if
pipeline
.
active?
update_metrics_for_succeeded_pipeline
(
pipeline
)
if
pipeline
.
success?
metrics
=
MergeRequest
::
Metrics
.
where
(
merge_request_id:
merge_requests
)
metrics
.
update_all
(
latest_build_started_at:
pipeline
.
started_at
)
if
pipeline
.
active?
metrics
.
update_all
(
latest_build_finished_at:
pipeline
.
finished_at
)
if
pipeline
.
success?
end
end
end
end
private
def
update_metrics_for_active_pipeline
(
pipeline
)
metrics
(
pipeline
).
update_all
(
latest_build_started_at:
pipeline
.
started_at
,
latest_build_finished_at:
nil
)
end
def
update_metrics_for_succeeded_pipeline
(
pipeline
)
metrics
(
pipeline
).
update_all
(
latest_build_started_at:
pipeline
.
started_at
,
latest_build_finished_at:
pipeline
.
finished_at
)
end
def
metrics
(
pipeline
)
MergeRequest
::
Metrics
.
where
(
merge_request_id:
merge_requests
(
pipeline
))
end
def
merge_requests
(
pipeline
)
pipeline
.
merge_requests
.
map
(
&
:id
)
end
end
end
spec/models/ci/pipeline_spec.rb
浏览文件 @
a4978030
...
@@ -187,33 +187,24 @@ describe Ci::Pipeline, models: true do
...
@@ -187,33 +187,24 @@ describe Ci::Pipeline, models: true do
end
end
end
end
describe
"merge request metrics"
do
describe
'merge request metrics'
do
let
(
:project
)
{
FactoryGirl
.
create
:project
}
let
(
:project
)
{
FactoryGirl
.
create
:project
}
let
(
:pipeline
)
{
FactoryGirl
.
create
(
:ci_empty_pipeline
,
status:
'created'
,
project:
project
,
ref:
'master'
,
sha:
project
.
repository
.
commit
(
'master'
).
id
)
}
let
(
:pipeline
)
{
FactoryGirl
.
create
(
:ci_empty_pipeline
,
status:
'created'
,
project:
project
,
ref:
'master'
,
sha:
project
.
repository
.
commit
(
'master'
).
id
)
}
let!
(
:merge_request
)
{
create
(
:merge_request
,
source_project:
project
,
source_branch:
pipeline
.
ref
)
}
let!
(
:merge_request
)
{
create
(
:merge_request
,
source_project:
project
,
source_branch:
pipeline
.
ref
)
}
context
'when transitioning to running'
do
before
do
it
'records the build start time'
do
expect
(
PipelineMetricsWorker
).
to
receive
(
:perform_async
).
with
(
pipeline
.
id
)
time
=
Time
.
now
end
Timecop
.
freeze
(
time
)
{
build
.
run
}
expect
(
merge_request
.
reload
.
metrics
.
latest_build_started_at
).
to
be_within
(
1
.
second
).
of
(
time
)
end
it
'clears the build end time'
do
build
.
run
expect
(
merge_request
.
reload
.
metrics
.
latest_build_finished_at
).
to
be_nil
context
'when transitioning to running'
do
it
'schedules metrics workers'
do
pipeline
.
run
end
end
end
end
context
'when transitioning to success'
do
context
'when transitioning to success'
do
it
'records the build end time'
do
it
'schedules metrics workers'
do
build
.
run
pipeline
.
succeed
time
=
Time
.
now
Timecop
.
freeze
(
time
)
{
build
.
success
}
expect
(
merge_request
.
reload
.
metrics
.
latest_build_finished_at
).
to
be_within
(
1
.
second
).
of
(
time
)
end
end
end
end
end
end
...
...
spec/workers/pipeline_metrics_worker_spec.rb
0 → 100644
浏览文件 @
a4978030
require
'spec_helper'
describe
PipelineMetricsWorker
do
let
(
:project
)
{
create
(
:project
)
}
let!
(
:merge_request
)
{
create
(
:merge_request
,
source_project:
project
,
source_branch:
pipeline
.
ref
)
}
let
(
:pipeline
)
do
create
(
:ci_empty_pipeline
,
status:
status
,
project:
project
,
ref:
'master'
,
sha:
project
.
repository
.
commit
(
'master'
).
id
,
started_at:
1
.
hour
.
ago
,
finished_at:
Time
.
now
)
end
describe
'#perform'
do
subject
{
described_class
.
new
.
perform
(
pipeline
.
id
)
}
context
'when pipeline is running'
do
let
(
:status
)
{
'running'
}
it
'records the build start time'
do
subject
expect
(
merge_request
.
reload
.
metrics
.
latest_build_started_at
).
to
eq
(
pipeline
.
started_at
)
end
it
'clears the build end time'
do
subject
expect
(
merge_request
.
reload
.
metrics
.
latest_build_finished_at
).
to
be_nil
end
end
context
'when pipeline succeeded'
do
let
(
:status
)
{
'success'
}
it
'records the build end time'
do
subject
expect
(
merge_request
.
reload
.
metrics
.
latest_build_finished_at
).
to
eq
(
pipeline
.
finished_at
)
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录